[INFO] updating cached repository owtotwo/SimplestTodo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/owtotwo/SimplestTodo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/owtotwo/SimplestTodo" "work/ex/clippy-test-run/sources/stable/gh/owtotwo/SimplestTodo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/owtotwo/SimplestTodo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/owtotwo/SimplestTodo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/owtotwo/SimplestTodo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/owtotwo/SimplestTodo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e6f65860093cacd65745a85f60046f1e0e88ad98 [INFO] sha for GitHub repo owtotwo/SimplestTodo: e6f65860093cacd65745a85f60046f1e0e88ad98 [INFO] validating manifest of owtotwo/SimplestTodo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of owtotwo/SimplestTodo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing owtotwo/SimplestTodo [INFO] finished frobbing owtotwo/SimplestTodo [INFO] frobbed toml for owtotwo/SimplestTodo written to work/ex/clippy-test-run/sources/stable/gh/owtotwo/SimplestTodo/Cargo.toml [INFO] started frobbing owtotwo/SimplestTodo [INFO] finished frobbing owtotwo/SimplestTodo [INFO] frobbed toml for owtotwo/SimplestTodo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/owtotwo/SimplestTodo/Cargo.toml [INFO] crate owtotwo/SimplestTodo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting owtotwo/SimplestTodo against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/owtotwo/SimplestTodo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4d4a13e2cdaf8d921a40fcdd92aaa5705f5556165baa40550bc5690cbecdfcee [INFO] running `"docker" "start" "-a" "4d4a13e2cdaf8d921a40fcdd92aaa5705f5556165baa40550bc5690cbecdfcee"` [INFO] [stderr] Checking json v0.11.2 [INFO] [stderr] Checking todo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/todo.rs:312:13 [INFO] [stderr] | [INFO] [stderr] 312 | write!(f, " [{:2}] {} \n", count + 1, item)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/todo.rs:312:13 [INFO] [stderr] | [INFO] [stderr] 312 | write!(f, " [{:2}] {} \n", count + 1, item)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/todo.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | const TOKEN_ENV_KEY: &'static str = "GITHUB_ACCESS_TOKEN"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/todo.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | const TOKEN_ENV_KEY: &'static str = "GITHUB_ACCESS_TOKEN"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/todo.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | file.write(buffer.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `todo`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/todo.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | file.write(buffer.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `todo`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4d4a13e2cdaf8d921a40fcdd92aaa5705f5556165baa40550bc5690cbecdfcee"` [INFO] running `"docker" "rm" "-f" "4d4a13e2cdaf8d921a40fcdd92aaa5705f5556165baa40550bc5690cbecdfcee"` [INFO] [stdout] 4d4a13e2cdaf8d921a40fcdd92aaa5705f5556165baa40550bc5690cbecdfcee