[INFO] updating cached repository owtotwo/Simple-Calculator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/owtotwo/Simple-Calculator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/owtotwo/Simple-Calculator" "work/ex/clippy-test-run/sources/stable/gh/owtotwo/Simple-Calculator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/owtotwo/Simple-Calculator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/owtotwo/Simple-Calculator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/owtotwo/Simple-Calculator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/owtotwo/Simple-Calculator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a39a3ac091f43aa037e186183e00d67359a25ba3 [INFO] sha for GitHub repo owtotwo/Simple-Calculator: a39a3ac091f43aa037e186183e00d67359a25ba3 [INFO] validating manifest of owtotwo/Simple-Calculator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of owtotwo/Simple-Calculator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing owtotwo/Simple-Calculator [INFO] finished frobbing owtotwo/Simple-Calculator [INFO] frobbed toml for owtotwo/Simple-Calculator written to work/ex/clippy-test-run/sources/stable/gh/owtotwo/Simple-Calculator/Cargo.toml [INFO] started frobbing owtotwo/Simple-Calculator [INFO] finished frobbing owtotwo/Simple-Calculator [INFO] frobbed toml for owtotwo/Simple-Calculator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/owtotwo/Simple-Calculator/Cargo.toml [INFO] crate owtotwo/Simple-Calculator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting owtotwo/Simple-Calculator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/owtotwo/Simple-Calculator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2025542e370f6141083e62ef393bff9a92f6fcdf3cf857d9b3601b9d6ec39bf4 [INFO] running `"docker" "start" "-a" "2025542e370f6141083e62ef393bff9a92f6fcdf3cf857d9b3601b9d6ec39bf4"` [INFO] [stderr] Checking calculator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/calculator/mod.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | const PROMPT_DEFAULT: &'static str = ">> "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/calculator/mod.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | const PROMPT_DEFAULT: &'static str = ">> "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/calculator/expr/operator.rs:19:32 [INFO] [stderr] | [INFO] [stderr] 19 | s if s.starts_with("+") => Ok((Operator::Addition, &s[1..])), [INFO] [stderr] | ^^^ help: try using a char instead: `'+'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/calculator/expr/operator.rs:20:32 [INFO] [stderr] | [INFO] [stderr] 20 | s if s.starts_with("-") => Ok((Operator::Subtraction, &s[1..])), [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/calculator/expr/operator.rs:21:32 [INFO] [stderr] | [INFO] [stderr] 21 | s if s.starts_with("*") => Ok((Operator::Multiplication, &s[1..])), [INFO] [stderr] | ^^^ help: try using a char instead: `'*'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/calculator/expr/operator.rs:22:32 [INFO] [stderr] | [INFO] [stderr] 22 | s if s.starts_with("/") => Ok((Operator::Division, &s[1..])), [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/calculator/expr/operator.rs:23:32 [INFO] [stderr] | [INFO] [stderr] 23 | s if s.starts_with("(") => Ok((Operator::LeftBracket, &s[1..])), [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/calculator/expr/operator.rs:24:32 [INFO] [stderr] | [INFO] [stderr] 24 | s if s.starts_with(")") => Ok((Operator::RightBracket, &s[1..])), [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/calculator/expr/integer.rs:31:32 [INFO] [stderr] | [INFO] [stderr] 31 | Some(digit) => digit as u64, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(digit)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/calculator/expr/integer.rs:41:45 [INFO] [stderr] | [INFO] [stderr] 41 | } else if is_neg && unsigned > -(i32::min_value() as i64) as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i32::min_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/calculator/mod.rs:81:16 [INFO] [stderr] | [INFO] [stderr] 81 | if user_input.len() == 0 { break; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `user_input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/calculator/mod.rs:84:16 [INFO] [stderr] | [INFO] [stderr] 84 | if user_input.trim().len() == 0 { continue; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `user_input.trim().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/calculator/mod.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | stdout.write(msg.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/calculator/mod.rs:122:22 [INFO] [stderr] | [INFO] [stderr] 122 | if newline { stdout.write("\n".as_bytes()).unwrap(); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/calculator/mod.rs:128:16 [INFO] [stderr] | [INFO] [stderr] 128 | if dirty_expr.trim_right().len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `dirty_expr.trim_right().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `calculator`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/calculator/expr/operator.rs:19:32 [INFO] [stderr] | [INFO] [stderr] 19 | s if s.starts_with("+") => Ok((Operator::Addition, &s[1..])), [INFO] [stderr] | ^^^ help: try using a char instead: `'+'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/calculator/expr/operator.rs:20:32 [INFO] [stderr] | [INFO] [stderr] 20 | s if s.starts_with("-") => Ok((Operator::Subtraction, &s[1..])), [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/calculator/expr/operator.rs:21:32 [INFO] [stderr] | [INFO] [stderr] 21 | s if s.starts_with("*") => Ok((Operator::Multiplication, &s[1..])), [INFO] [stderr] | ^^^ help: try using a char instead: `'*'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/calculator/expr/operator.rs:22:32 [INFO] [stderr] | [INFO] [stderr] 22 | s if s.starts_with("/") => Ok((Operator::Division, &s[1..])), [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/calculator/expr/operator.rs:23:32 [INFO] [stderr] | [INFO] [stderr] 23 | s if s.starts_with("(") => Ok((Operator::LeftBracket, &s[1..])), [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/calculator/expr/operator.rs:24:32 [INFO] [stderr] | [INFO] [stderr] 24 | s if s.starts_with(")") => Ok((Operator::RightBracket, &s[1..])), [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/calculator/expr/integer.rs:31:32 [INFO] [stderr] | [INFO] [stderr] 31 | Some(digit) => digit as u64, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(digit)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/calculator/expr/integer.rs:41:45 [INFO] [stderr] | [INFO] [stderr] 41 | } else if is_neg && unsigned > -(i32::min_value() as i64) as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i32::min_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/calculator/mod.rs:81:16 [INFO] [stderr] | [INFO] [stderr] 81 | if user_input.len() == 0 { break; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `user_input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/calculator/mod.rs:84:16 [INFO] [stderr] | [INFO] [stderr] 84 | if user_input.trim().len() == 0 { continue; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `user_input.trim().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/calculator/mod.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | stdout.write(msg.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/calculator/mod.rs:122:22 [INFO] [stderr] | [INFO] [stderr] 122 | if newline { stdout.write("\n".as_bytes()).unwrap(); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/calculator/mod.rs:128:16 [INFO] [stderr] | [INFO] [stderr] 128 | if dirty_expr.trim_right().len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `dirty_expr.trim_right().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `calculator`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2025542e370f6141083e62ef393bff9a92f6fcdf3cf857d9b3601b9d6ec39bf4"` [INFO] running `"docker" "rm" "-f" "2025542e370f6141083e62ef393bff9a92f6fcdf3cf857d9b3601b9d6ec39bf4"` [INFO] [stdout] 2025542e370f6141083e62ef393bff9a92f6fcdf3cf857d9b3601b9d6ec39bf4