[INFO] updating cached repository owlinux1000/rust-comet2 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/owlinux1000/rust-comet2 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/owlinux1000/rust-comet2" "work/ex/clippy-test-run/sources/stable/gh/owlinux1000/rust-comet2"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/owlinux1000/rust-comet2'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/owlinux1000/rust-comet2" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/owlinux1000/rust-comet2"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/owlinux1000/rust-comet2'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5aa5b2ad2418ba5fe198e25db8fa06023dd11129 [INFO] sha for GitHub repo owlinux1000/rust-comet2: 5aa5b2ad2418ba5fe198e25db8fa06023dd11129 [INFO] validating manifest of owlinux1000/rust-comet2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of owlinux1000/rust-comet2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing owlinux1000/rust-comet2 [INFO] finished frobbing owlinux1000/rust-comet2 [INFO] frobbed toml for owlinux1000/rust-comet2 written to work/ex/clippy-test-run/sources/stable/gh/owlinux1000/rust-comet2/Cargo.toml [INFO] started frobbing owlinux1000/rust-comet2 [INFO] finished frobbing owlinux1000/rust-comet2 [INFO] frobbed toml for owlinux1000/rust-comet2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/owlinux1000/rust-comet2/Cargo.toml [INFO] crate owlinux1000/rust-comet2 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting owlinux1000/rust-comet2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/owlinux1000/rust-comet2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 48656a7d8b2d13f0782355ac4b84ccfede32a20fcd117812725647fbf9056911 [INFO] running `"docker" "start" "-a" "48656a7d8b2d13f0782355ac4b84ccfede32a20fcd117812725647fbf9056911"` [INFO] [stderr] Checking rust-comet2 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/sl.rs:103:21 [INFO] [stderr] | [INFO] [stderr] 103 | emu.gr[1] = 0b1111111101001000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_1111_0100_1000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/sl.rs:109:31 [INFO] [stderr] | [INFO] [stderr] 109 | assert_eq!(emu.gr[1], 0b1111101001000000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_1010_0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/sl.rs:116:21 [INFO] [stderr] | [INFO] [stderr] 116 | emu.gr[1] = 0b1111111101001000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_1111_0100_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/sl.rs:122:31 [INFO] [stderr] | [INFO] [stderr] 122 | assert_eq!(emu.gr[1], 0b1111111111101001); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_1111_1110_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Fr` [INFO] [stderr] --> src/hardware.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | struct Fr { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/hardware.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn new() -> Fr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set` [INFO] [stderr] --> src/hardware.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn set(&mut self, i: u8, f: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_all` [INFO] [stderr] --> src/hardware.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn get_all(&self) -> [bool; 3] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get` [INFO] [stderr] --> src/hardware.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn get(&self, i: u8) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/instruction/sl.rs:9:15 [INFO] [stderr] | [INFO] [stderr] 9 | let adr = emu.fetch() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(emu.fetch())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/instruction/sl.rs:10:40 [INFO] [stderr] | [INFO] [stderr] 10 | let idx: u32 = if x == 0 {0} else {emu.gr[x] as u32}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(emu.gr[x])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/instruction/sl.rs:36:15 [INFO] [stderr] | [INFO] [stderr] 36 | let adr = emu.fetch() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(emu.fetch())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/instruction/sl.rs:37:40 [INFO] [stderr] | [INFO] [stderr] 37 | let idx: u32 = if x == 0 {0} else {emu.gr[x] as u32}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(emu.gr[x])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/instruction/sl.rs:57:15 [INFO] [stderr] | [INFO] [stderr] 57 | let adr = emu.fetch() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(emu.fetch())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/instruction/sl.rs:58:40 [INFO] [stderr] | [INFO] [stderr] 58 | let idx: u32 = if x == 0 {0} else {emu.gr[x] as u32}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(emu.gr[x])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/instruction/sl.rs:77:15 [INFO] [stderr] | [INFO] [stderr] 77 | let adr = emu.fetch() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(emu.fetch())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/instruction/sl.rs:78:40 [INFO] [stderr] | [INFO] [stderr] 78 | let idx: u32 = if x == 0 {0} else {emu.gr[x] as u32}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(emu.gr[x])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `hardware::Emu` [INFO] [stderr] --> src/hardware.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | / pub fn new() -> Emu { [INFO] [stderr] 70 | | Emu{ [INFO] [stderr] 71 | | memory: [0; 65536], [INFO] [stderr] 72 | | gr: [0; 8], [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 67 | impl Default for hardware::Emu { [INFO] [stderr] 68 | fn default() -> Self { [INFO] [stderr] 69 | Self::new() [INFO] [stderr] 70 | } [INFO] [stderr] 71 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Fr` [INFO] [stderr] --> src/hardware.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | struct Fr { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/hardware.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn new() -> Fr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set` [INFO] [stderr] --> src/hardware.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn set(&mut self, i: u8, f: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_all` [INFO] [stderr] --> src/hardware.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn get_all(&self) -> [bool; 3] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get` [INFO] [stderr] --> src/hardware.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn get(&self, i: u8) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/instruction/sl.rs:9:15 [INFO] [stderr] | [INFO] [stderr] 9 | let adr = emu.fetch() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(emu.fetch())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/instruction/sl.rs:10:40 [INFO] [stderr] | [INFO] [stderr] 10 | let idx: u32 = if x == 0 {0} else {emu.gr[x] as u32}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(emu.gr[x])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/instruction/sl.rs:36:15 [INFO] [stderr] | [INFO] [stderr] 36 | let adr = emu.fetch() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(emu.fetch())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/instruction/sl.rs:37:40 [INFO] [stderr] | [INFO] [stderr] 37 | let idx: u32 = if x == 0 {0} else {emu.gr[x] as u32}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(emu.gr[x])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/instruction/sl.rs:57:15 [INFO] [stderr] | [INFO] [stderr] 57 | let adr = emu.fetch() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(emu.fetch())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/instruction/sl.rs:58:40 [INFO] [stderr] | [INFO] [stderr] 58 | let idx: u32 = if x == 0 {0} else {emu.gr[x] as u32}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(emu.gr[x])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/instruction/sl.rs:77:15 [INFO] [stderr] | [INFO] [stderr] 77 | let adr = emu.fetch() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(emu.fetch())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/instruction/sl.rs:78:40 [INFO] [stderr] | [INFO] [stderr] 78 | let idx: u32 = if x == 0 {0} else {emu.gr[x] as u32}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(emu.gr[x])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `hardware::Emu` [INFO] [stderr] --> src/hardware.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | / pub fn new() -> Emu { [INFO] [stderr] 70 | | Emu{ [INFO] [stderr] 71 | | memory: [0; 65536], [INFO] [stderr] 72 | | gr: [0; 8], [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 67 | impl Default for hardware::Emu { [INFO] [stderr] 68 | fn default() -> Self { [INFO] [stderr] 69 | Self::new() [INFO] [stderr] 70 | } [INFO] [stderr] 71 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.25s [INFO] running `"docker" "inspect" "48656a7d8b2d13f0782355ac4b84ccfede32a20fcd117812725647fbf9056911"` [INFO] running `"docker" "rm" "-f" "48656a7d8b2d13f0782355ac4b84ccfede32a20fcd117812725647fbf9056911"` [INFO] [stdout] 48656a7d8b2d13f0782355ac4b84ccfede32a20fcd117812725647fbf9056911