[INFO] updating cached repository outofjungle/termiaow
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/outofjungle/termiaow
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/outofjungle/termiaow" "work/ex/clippy-test-run/sources/stable/gh/outofjungle/termiaow"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/outofjungle/termiaow'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/outofjungle/termiaow" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/outofjungle/termiaow"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/outofjungle/termiaow'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] cee68734e77f2decf2807aba0fcaefd4077448ad
[INFO] sha for GitHub repo outofjungle/termiaow: cee68734e77f2decf2807aba0fcaefd4077448ad
[INFO] validating manifest of outofjungle/termiaow on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of outofjungle/termiaow on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing outofjungle/termiaow
[INFO] finished frobbing outofjungle/termiaow
[INFO] frobbed toml for outofjungle/termiaow written to work/ex/clippy-test-run/sources/stable/gh/outofjungle/termiaow/Cargo.toml
[INFO] started frobbing outofjungle/termiaow
[INFO] finished frobbing outofjungle/termiaow
[INFO] frobbed toml for outofjungle/termiaow written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/outofjungle/termiaow/Cargo.toml
[INFO] crate outofjungle/termiaow has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting outofjungle/termiaow against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/outofjungle/termiaow:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] f33f950d886bca50f392da46dbc75e3fa0fd5d1e2f838b765fefafe69274b716
[INFO] running `"docker" "start" "-a" "f33f950d886bca50f392da46dbc75e3fa0fd5d1e2f838b765fefafe69274b716"`
[INFO] [stderr]     Checking sequence_trie v0.0.13
[INFO] [stderr]     Checking url v1.2.3
[INFO] [stderr]     Checking cookie v0.2.5
[INFO] [stderr]     Checking hyper v0.9.13
[INFO] [stderr]     Checking iron v0.4.0
[INFO] [stderr]     Checking mount v0.2.1
[INFO] [stderr]     Checking router v0.4.0
[INFO] [stderr]     Checking staticfile v0.3.1
[INFO] [stderr]     Checking robanukat v0.0.1 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:64:5
[INFO] [stderr]    |
[INFO] [stderr] 64 |     return env::var("PLAINTEXT").unwrap_or("".to_string());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `env::var("PLAINTEXT").unwrap_or("".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:68:5
[INFO] [stderr]    |
[INFO] [stderr] 68 |     return env::var("CIPHERTEXT").unwrap_or("".to_string());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `env::var("CIPHERTEXT").unwrap_or("".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]   --> src/main.rs:82:39
[INFO] [stderr]    |
[INFO] [stderr] 82 |         _ => return Ok(Response::with((status::BadRequest))),
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]   --> src/main.rs:82:39
[INFO] [stderr]    |
[INFO] [stderr] 82 |         _ => return Ok(Response::with((status::BadRequest))),
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]   --> src/main.rs:90:39
[INFO] [stderr]    |
[INFO] [stderr] 90 |         _ => return Ok(Response::with((status::BadRequest))),
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]   --> src/main.rs:90:39
[INFO] [stderr]    |
[INFO] [stderr] 90 |         _ => return Ok(Response::with((status::BadRequest))),
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:64:5
[INFO] [stderr]    |
[INFO] [stderr] 64 |     return env::var("PLAINTEXT").unwrap_or("".to_string());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `env::var("PLAINTEXT").unwrap_or("".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:68:5
[INFO] [stderr]    |
[INFO] [stderr] 68 |     return env::var("CIPHERTEXT").unwrap_or("".to_string());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `env::var("CIPHERTEXT").unwrap_or("".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]   --> src/main.rs:82:39
[INFO] [stderr]    |
[INFO] [stderr] 82 |         _ => return Ok(Response::with((status::BadRequest))),
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]   --> src/main.rs:82:39
[INFO] [stderr]    |
[INFO] [stderr] 82 |         _ => return Ok(Response::with((status::BadRequest))),
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]   --> src/main.rs:90:39
[INFO] [stderr]    |
[INFO] [stderr] 90 |         _ => return Ok(Response::with((status::BadRequest))),
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]   --> src/main.rs:90:39
[INFO] [stderr]    |
[INFO] [stderr] 90 |         _ => return Ok(Response::with((status::BadRequest))),
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:55:31
[INFO] [stderr]    |
[INFO] [stderr] 55 |     pub fn lookup(&self, chr: &char) -> char {
[INFO] [stderr]    |                               ^^^^^ help: consider passing by value instead: `char`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:64:34
[INFO] [stderr]    |
[INFO] [stderr] 64 |     return env::var("PLAINTEXT").unwrap_or("".to_string());
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:68:35
[INFO] [stderr]    |
[INFO] [stderr] 68 |     return env::var("CIPHERTEXT").unwrap_or("".to_string());
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:72:9
[INFO] [stderr]    |
[INFO] [stderr] 72 |     let ref query = req.extensions
[INFO] [stderr]    |         ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 72 |     let query = &req.extensions
[INFO] [stderr] 73 |         .get::<Router>()
[INFO] [stderr] 74 |         .unwrap()
[INFO] [stderr] 75 |         .find("op")
[INFO] [stderr] 76 |         .unwrap_or("")
[INFO] [stderr] 77 |         .to_lowercase();
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:105:13
[INFO] [stderr]     |
[INFO] [stderr] 105 |             times = times + 1;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^ help: replace it with: `times += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:126:33
[INFO] [stderr]     |
[INFO] [stderr] 126 |     let port = env::var("PORT").unwrap_or("3000".to_string());
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "3000".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:55:31
[INFO] [stderr]    |
[INFO] [stderr] 55 |     pub fn lookup(&self, chr: &char) -> char {
[INFO] [stderr]    |                               ^^^^^ help: consider passing by value instead: `char`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:64:34
[INFO] [stderr]    |
[INFO] [stderr] 64 |     return env::var("PLAINTEXT").unwrap_or("".to_string());
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:68:35
[INFO] [stderr]    |
[INFO] [stderr] 68 |     return env::var("CIPHERTEXT").unwrap_or("".to_string());
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:72:9
[INFO] [stderr]    |
[INFO] [stderr] 72 |     let ref query = req.extensions
[INFO] [stderr]    |         ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 72 |     let query = &req.extensions
[INFO] [stderr] 73 |         .get::<Router>()
[INFO] [stderr] 74 |         .unwrap()
[INFO] [stderr] 75 |         .find("op")
[INFO] [stderr] 76 |         .unwrap_or("")
[INFO] [stderr] 77 |         .to_lowercase();
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:105:13
[INFO] [stderr]     |
[INFO] [stderr] 105 |             times = times + 1;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^ help: replace it with: `times += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:126:33
[INFO] [stderr]     |
[INFO] [stderr] 126 |     let port = env::var("PORT").unwrap_or("3000".to_string());
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "3000".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 12.03s
[INFO] running `"docker" "inspect" "f33f950d886bca50f392da46dbc75e3fa0fd5d1e2f838b765fefafe69274b716"`
[INFO] running `"docker" "rm" "-f" "f33f950d886bca50f392da46dbc75e3fa0fd5d1e2f838b765fefafe69274b716"`
[INFO] [stdout] f33f950d886bca50f392da46dbc75e3fa0fd5d1e2f838b765fefafe69274b716