[INFO] updating cached repository ousttrue/rust_gtk_glarea [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ousttrue/rust_gtk_glarea [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ousttrue/rust_gtk_glarea" "work/ex/clippy-test-run/sources/stable/gh/ousttrue/rust_gtk_glarea"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ousttrue/rust_gtk_glarea'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ousttrue/rust_gtk_glarea" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ousttrue/rust_gtk_glarea"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ousttrue/rust_gtk_glarea'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e0740c73224040f2c76dd00c2cbad5ed719cd6fc [INFO] sha for GitHub repo ousttrue/rust_gtk_glarea: e0740c73224040f2c76dd00c2cbad5ed719cd6fc [INFO] validating manifest of ousttrue/rust_gtk_glarea on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ousttrue/rust_gtk_glarea on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ousttrue/rust_gtk_glarea [INFO] finished frobbing ousttrue/rust_gtk_glarea [INFO] frobbed toml for ousttrue/rust_gtk_glarea written to work/ex/clippy-test-run/sources/stable/gh/ousttrue/rust_gtk_glarea/Cargo.toml [INFO] started frobbing ousttrue/rust_gtk_glarea [INFO] finished frobbing ousttrue/rust_gtk_glarea [INFO] frobbed toml for ousttrue/rust_gtk_glarea written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ousttrue/rust_gtk_glarea/Cargo.toml [INFO] crate ousttrue/rust_gtk_glarea has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ousttrue/rust_gtk_glarea against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ousttrue/rust_gtk_glarea:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3b7809676f31c8d3f990624f24419ceeaee75d722445b3357fe3ef04d1b681f9 [INFO] running `"docker" "start" "-a" "3b7809676f31c8d3f990624f24419ceeaee75d722445b3357fe3ef04d1b681f9"` [INFO] [stderr] Compiling gio v0.5.0 [INFO] [stderr] Compiling gdk-pixbuf v0.5.0 [INFO] [stderr] Compiling gdk v0.9.0 [INFO] [stderr] Compiling gtk v0.5.0 [INFO] [stderr] Compiling glib-sys v0.7.0 [INFO] [stderr] Compiling gobject-sys v0.7.0 [INFO] [stderr] Compiling gio-sys v0.7.0 [INFO] [stderr] Compiling pango-sys v0.7.0 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.7.0 [INFO] [stderr] Compiling gdk-sys v0.7.0 [INFO] [stderr] Compiling gtk-sys v0.7.0 [INFO] [stderr] Compiling log v0.4.5 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Compiling cairo-sys-rs v0.7.0 [INFO] [stderr] Compiling atk-sys v0.7.0 [INFO] [stderr] Compiling cairo-rs v0.5.0 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking glib v0.6.0 [INFO] [stderr] Compiling epoxy v0.0.4 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Checking pango v0.5.0 [INFO] [stderr] Checking rust_gtk_glarea v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/renderers/basic_renderer.rs:11:19 [INFO] [stderr] | [INFO] [stderr] 11 | const VS_SOURCE: &'static str = "#version 420 [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/renderers/basic_renderer.rs:18:19 [INFO] [stderr] | [INFO] [stderr] 18 | const FS_SOURCE: &'static str = "#version 420 [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/renderers/basic_renderer.rs:11:19 [INFO] [stderr] | [INFO] [stderr] 11 | const VS_SOURCE: &'static str = "#version 420 [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/renderers/basic_renderer.rs:18:19 [INFO] [stderr] | [INFO] [stderr] 18 | const FS_SOURCE: &'static str = "#version 420 [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/gl_loader.rs:21:53 [INFO] [stderr] | [INFO] [stderr] 21 | move |s| loader.get_proc_addr(s).unwrap_or_else(|| ptr::null()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `ptr::null` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | / match gl_area.get_error() { [INFO] [stderr] 41 | | Some(error) => { [INFO] [stderr] 42 | | println!("gtk::GLArea error: {}", error); [INFO] [stderr] 43 | | return; [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | None => {} [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 40 | if let Some(error) = gl_area.get_error() { [INFO] [stderr] 41 | println!("gtk::GLArea error: {}", error); [INFO] [stderr] 42 | return; [INFO] [stderr] 43 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | / match gl_area.get_context() { [INFO] [stderr] 50 | | Some(context) =>{ [INFO] [stderr] 51 | | [INFO] [stderr] 52 | | let version = context.get_version(); [INFO] [stderr] ... | [INFO] [stderr] 56 | | None=>{} [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 49 | if let Some(context) = gl_area.get_context() { [INFO] [stderr] 50 | [INFO] [stderr] 51 | let version = context.get_version(); [INFO] [stderr] 52 | println!("context version: {}.{}", version.0, version.1); [INFO] [stderr] 53 | [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/gl_loader.rs:21:53 [INFO] [stderr] | [INFO] [stderr] 21 | move |s| loader.get_proc_addr(s).unwrap_or_else(|| ptr::null()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `ptr::null` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | / match gl_area.get_error() { [INFO] [stderr] 41 | | Some(error) => { [INFO] [stderr] 42 | | println!("gtk::GLArea error: {}", error); [INFO] [stderr] 43 | | return; [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | None => {} [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 40 | if let Some(error) = gl_area.get_error() { [INFO] [stderr] 41 | println!("gtk::GLArea error: {}", error); [INFO] [stderr] 42 | return; [INFO] [stderr] 43 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | / match gl_area.get_context() { [INFO] [stderr] 50 | | Some(context) =>{ [INFO] [stderr] 51 | | [INFO] [stderr] 52 | | let version = context.get_version(); [INFO] [stderr] ... | [INFO] [stderr] 56 | | None=>{} [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 49 | if let Some(context) = gl_area.get_context() { [INFO] [stderr] 50 | [INFO] [stderr] 51 | let version = context.get_version(); [INFO] [stderr] 52 | println!("context version: {}.{}", version.0, version.1); [INFO] [stderr] 53 | [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 55s [INFO] running `"docker" "inspect" "3b7809676f31c8d3f990624f24419ceeaee75d722445b3357fe3ef04d1b681f9"` [INFO] running `"docker" "rm" "-f" "3b7809676f31c8d3f990624f24419ceeaee75d722445b3357fe3ef04d1b681f9"` [INFO] [stdout] 3b7809676f31c8d3f990624f24419ceeaee75d722445b3357fe3ef04d1b681f9