[INFO] updating cached repository ouihelp/autodeploy [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ouihelp/autodeploy [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ouihelp/autodeploy" "work/ex/clippy-test-run/sources/stable/gh/ouihelp/autodeploy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ouihelp/autodeploy'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ouihelp/autodeploy" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ouihelp/autodeploy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ouihelp/autodeploy'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e3b9acbe84df1557e34d899ab338ee9895c9c696 [INFO] sha for GitHub repo ouihelp/autodeploy: e3b9acbe84df1557e34d899ab338ee9895c9c696 [INFO] validating manifest of ouihelp/autodeploy on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ouihelp/autodeploy on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ouihelp/autodeploy [INFO] finished frobbing ouihelp/autodeploy [INFO] frobbed toml for ouihelp/autodeploy written to work/ex/clippy-test-run/sources/stable/gh/ouihelp/autodeploy/Cargo.toml [INFO] started frobbing ouihelp/autodeploy [INFO] finished frobbing ouihelp/autodeploy [INFO] frobbed toml for ouihelp/autodeploy written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ouihelp/autodeploy/Cargo.toml [INFO] crate ouihelp/autodeploy has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ouihelp/autodeploy against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ouihelp/autodeploy:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6d3490c81a7e0c388f787c06a2d81193d8f91ce9efbd2971cfcb554cb0f36ec9 [INFO] running `"docker" "start" "-a" "6d3490c81a7e0c388f787c06a2d81193d8f91ce9efbd2971cfcb554cb0f36ec9"` [INFO] [stderr] Checking slog v2.1.1 [INFO] [stderr] Checking take_mut v0.2.0 [INFO] [stderr] Checking isatty v0.1.6 [INFO] [stderr] Compiling openssl-sys v0.9.23 [INFO] [stderr] Compiling libz-sys v1.0.18 [INFO] [stderr] Compiling curl-sys v0.3.15 [INFO] [stderr] Checking unix_socket v0.5.0 [INFO] [stderr] Checking socket2 v0.2.4 [INFO] [stderr] Checking serde_json v1.0.8 [INFO] [stderr] Checking yaml-rust v0.4.0 [INFO] [stderr] Checking hyperlocal v0.3.0 [INFO] [stderr] Checking slog-term v2.3.0 [INFO] [stderr] Checking slog-scope v4.0.1 [INFO] [stderr] Checking slog-async v2.2.0 [INFO] [stderr] Checking serde_yaml v0.7.3 [INFO] [stderr] Checking bodyparser v0.7.0 [INFO] [stderr] Checking curl v0.4.8 [INFO] [stderr] Checking autodeploy v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/redeploy.rs:104:43 [INFO] [stderr] | [INFO] [stderr] 104 | return RedeployOutput::CheckFail{ version: version }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/redeploy.rs:117:44 [INFO] [stderr] | [INFO] [stderr] 117 | return RedeployOutput::DeployFail{ version: version }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/redeploy.rs:122:36 [INFO] [stderr] | [INFO] [stderr] 122 | RedeployOutput::DeploySuccess{ version: version } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/redeploy.rs:104:43 [INFO] [stderr] | [INFO] [stderr] 104 | return RedeployOutput::CheckFail{ version: version }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/redeploy.rs:117:44 [INFO] [stderr] | [INFO] [stderr] 117 | return RedeployOutput::DeployFail{ version: version }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/redeploy.rs:122:36 [INFO] [stderr] | [INFO] [stderr] 122 | RedeployOutput::DeploySuccess{ version: version } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/notify.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | / match message { [INFO] [stderr] 89 | | Some(message) => send_message(&message), [INFO] [stderr] 90 | | None => {}, [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(message) = message { send_message(&message) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/notify.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | / match message { [INFO] [stderr] 89 | | Some(message) => send_message(&message), [INFO] [stderr] 90 | | None => {}, [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(message) = message { send_message(&message) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 46s [INFO] running `"docker" "inspect" "6d3490c81a7e0c388f787c06a2d81193d8f91ce9efbd2971cfcb554cb0f36ec9"` [INFO] running `"docker" "rm" "-f" "6d3490c81a7e0c388f787c06a2d81193d8f91ce9efbd2971cfcb554cb0f36ec9"` [INFO] [stdout] 6d3490c81a7e0c388f787c06a2d81193d8f91ce9efbd2971cfcb554cb0f36ec9