[INFO] updating cached repository orglofch/ecs-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/orglofch/ecs-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/orglofch/ecs-rust" "work/ex/clippy-test-run/sources/stable/gh/orglofch/ecs-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/orglofch/ecs-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/orglofch/ecs-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/orglofch/ecs-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/orglofch/ecs-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7772edaa3ecd251944c61c2270cb4ae8016ad3c9 [INFO] sha for GitHub repo orglofch/ecs-rust: 7772edaa3ecd251944c61c2270cb4ae8016ad3c9 [INFO] validating manifest of orglofch/ecs-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of orglofch/ecs-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing orglofch/ecs-rust [INFO] finished frobbing orglofch/ecs-rust [INFO] frobbed toml for orglofch/ecs-rust written to work/ex/clippy-test-run/sources/stable/gh/orglofch/ecs-rust/Cargo.toml [INFO] started frobbing orglofch/ecs-rust [INFO] finished frobbing orglofch/ecs-rust [INFO] frobbed toml for orglofch/ecs-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/orglofch/ecs-rust/Cargo.toml [INFO] crate orglofch/ecs-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting orglofch/ecs-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/orglofch/ecs-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 71f3cdbd42db55318a1713f9b4f44783181291d0b4126c67404ffc7ad1174305 [INFO] running `"docker" "start" "-a" "71f3cdbd42db55318a1713f9b4f44783181291d0b4126c67404ffc7ad1174305"` [INFO] [stderr] Compiling siphasher v0.2.2 [INFO] [stderr] Compiling libc v0.2.23 [INFO] [stderr] Compiling itoa v0.3.1 [INFO] [stderr] Compiling num-traits v0.1.37 [INFO] [stderr] Compiling dtoa v0.4.1 [INFO] [stderr] Compiling serde v0.9.15 [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Compiling bitflags v0.7.0 [INFO] [stderr] Compiling semver v0.1.20 [INFO] [stderr] Checking lazy_static v0.2.8 [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Compiling rayon-core v1.2.1 [INFO] [stderr] Checking either v1.1.0 [INFO] [stderr] Checking scopeguard v0.3.2 [INFO] [stderr] Compiling pkg-config v0.3.9 [INFO] [stderr] Compiling log v0.3.8 [INFO] [stderr] Checking cfg-if v0.1.2 [INFO] [stderr] Checking futures v0.1.14 [INFO] [stderr] Compiling khronos_api v1.0.1 [INFO] [stderr] Checking adler32 v1.0.2 [INFO] [stderr] Checking byteorder v1.0.0 [INFO] [stderr] Checking bitflags v0.4.0 [INFO] [stderr] Checking color_quant v1.0.0 [INFO] [stderr] Checking bitflags v0.9.1 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking bytes v0.3.0 [INFO] [stderr] Checking inflate v0.2.0 [INFO] [stderr] Checking slab v0.1.3 [INFO] [stderr] Checking approx v0.1.1 [INFO] [stderr] Checking scoped_threadpool v0.1.7 [INFO] [stderr] Compiling xml-rs v0.3.6 [INFO] [stderr] Compiling phf_shared v0.7.21 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Compiling ws2_32-sys v0.2.1 [INFO] [stderr] Compiling rand v0.3.15 [INFO] [stderr] Compiling rustc_version v0.1.7 [INFO] [stderr] Checking coco v0.1.1 [INFO] [stderr] Checking num_cpus v1.6.2 [INFO] [stderr] Checking net2 v0.2.31 [INFO] [stderr] Checking time v0.1.38 [INFO] [stderr] Checking shared_library v0.1.5 [INFO] [stderr] Checking filetime v0.1.10 [INFO] [stderr] Checking inotify v0.3.0 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking deflate v0.7.16 [INFO] [stderr] Compiling x11-dl v2.14.0 [INFO] [stderr] Checking gif v0.9.2 [INFO] [stderr] Checking num-integer v0.1.35 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Compiling phf v0.7.21 [INFO] [stderr] Compiling tempfile v2.1.5 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking cgmath v0.14.1 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Checking num-iter v0.1.34 [INFO] [stderr] Checking num-rational v0.1.39 [INFO] [stderr] Compiling wayland-scanner v0.9.9 [INFO] [stderr] Compiling gl_generator v0.5.3 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking walkdir v0.1.8 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Checking png v0.8.0 [INFO] [stderr] Checking miow v0.1.5 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Compiling wayland-client v0.9.9 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Compiling gl v0.6.2 [INFO] [stderr] Compiling glutin v0.9.2 [INFO] [stderr] Checking notify v4.0.1 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking image v0.14.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.9 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking wayland-window v0.6.1 [INFO] [stderr] Checking winit v0.7.5 [INFO] [stderr] Checking ecs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/mesh.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | vertices: vertices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/mesh.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | indices: indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `indices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/mesh.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | materials: materials, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `materials` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/mesh.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | vao: vao, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vao` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/mesh.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | vbo: vbo, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vbo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/mesh.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | ebo: ebo, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ebo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/obj.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | p_index: p_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `p_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/obj.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | tx_index: tx_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `tx_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/obj.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | n_index: n_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `n_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/obj.rs:184:17 [INFO] [stderr] | [INFO] [stderr] 184 | indices: indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `indices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/obj.rs:289:25 [INFO] [stderr] | [INFO] [stderr] 289 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/obj.rs:290:25 [INFO] [stderr] | [INFO] [stderr] 290 | normal: normal, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/obj.rs:291:25 [INFO] [stderr] | [INFO] [stderr] 291 | tex_coords: tex_coords, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tex_coords` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | gl_window: gl_window, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `gl_window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/mesh.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | vertices: vertices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/mesh.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | indices: indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `indices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/mesh.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | materials: materials, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `materials` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/mesh.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | vao: vao, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vao` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/mesh.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | vbo: vbo, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vbo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/mesh.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | ebo: ebo, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ebo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/obj.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | p_index: p_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `p_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/obj.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | tx_index: tx_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `tx_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/obj.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | n_index: n_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `n_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/obj.rs:184:17 [INFO] [stderr] | [INFO] [stderr] 184 | indices: indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `indices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/obj.rs:289:25 [INFO] [stderr] | [INFO] [stderr] 289 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/obj.rs:290:25 [INFO] [stderr] | [INFO] [stderr] 290 | normal: normal, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/obj.rs:291:25 [INFO] [stderr] | [INFO] [stderr] 291 | tex_coords: tex_coords, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tex_coords` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | gl_window: gl_window, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `gl_window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graphics/obj.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | return reindex_faces(positions, normals, tex_coords, faces, materials); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `reindex_faces(positions, normals, tex_coords, faces, materials)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::Path` [INFO] [stderr] --> src/graphics/shader.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use std::path::Path; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Arc`, `Mutex` [INFO] [stderr] --> src/graphics/shader.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | use std::sync::{Arc, Mutex}; [INFO] [stderr] | ^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::thread` [INFO] [stderr] --> src/graphics/shader.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use std::thread; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graphics/shader.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | return String::from_utf8(buffer).expect("Program info-log couldn't be parsed as utf8"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(buffer).expect("Program info-log couldn't be parsed as utf8")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graphics/shader.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | return String::from_utf8(buffer).expect("Shader info-log couldn't be parsed as utf8"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(buffer).expect("Shader info-log couldn't be parsed as utf8")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/world.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `graphics::mesh::Mesh` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use graphics::mesh::Mesh; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graphics/obj.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | return reindex_faces(positions, normals, tex_coords, faces, materials); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `reindex_faces(positions, normals, tex_coords, faces, materials)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::Path` [INFO] [stderr] --> src/graphics/shader.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use std::path::Path; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Arc`, `Mutex` [INFO] [stderr] --> src/graphics/shader.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | use std::sync::{Arc, Mutex}; [INFO] [stderr] | ^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::thread` [INFO] [stderr] --> src/graphics/shader.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use std::thread; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graphics/shader.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | return String::from_utf8(buffer).expect("Program info-log couldn't be parsed as utf8"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(buffer).expect("Program info-log couldn't be parsed as utf8")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graphics/shader.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | return String::from_utf8(buffer).expect("Shader info-log couldn't be parsed as utf8"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(buffer).expect("Shader info-log couldn't be parsed as utf8")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/world.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `graphics::mesh::Mesh` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use graphics::mesh::Mesh; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/main.rs:53:11 [INFO] [stderr] | [INFO] [stderr] 53 | fn render(state: &State) {} [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `shader` is never read [INFO] [stderr] --> src/main.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | let mut shader: Shader = Shader { id: 0 }; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `model_mat` is never read [INFO] [stderr] --> src/main.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | let mut model_mat = Matrix4::::one(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `shader` [INFO] [stderr] --> src/graphics/shader.rs:171:27 [INFO] [stderr] | [INFO] [stderr] 171 | fn debug_watch_thread(shader: &Shader, path: String) { [INFO] [stderr] | ^^^^^^ help: consider using `_shader` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `path` [INFO] [stderr] --> src/graphics/shader.rs:171:44 [INFO] [stderr] | [INFO] [stderr] 171 | fn debug_watch_thread(shader: &Shader, path: String) { [INFO] [stderr] | ^^^^ help: consider using `_path` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `shader` [INFO] [stderr] --> src/graphics/shader.rs:179:20 [INFO] [stderr] | [INFO] [stderr] 179 | fn debug_watch(shader: &Shader, path: &str) -> notify::Result<()> { [INFO] [stderr] | ^^^^^^ help: consider using `_shader` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `vbo` [INFO] [stderr] --> src/graphics/mesh.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | vbo: u32, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `ebo` [INFO] [stderr] --> src/graphics/mesh.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | ebo: u32, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `mat_index` [INFO] [stderr] --> src/graphics/obj.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | mat_index: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `VERTEX_DEFINE` [INFO] [stderr] --> src/graphics/shader.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | static VERTEX_DEFINE: &'static str = "#define VERTEX \n"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `FRAGMENT_DEFINE` [INFO] [stderr] --> src/graphics/shader.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | static FRAGMENT_DEFINE: &'static str = "#define FRAGMENT \n"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `create_joined` [INFO] [stderr] --> src/graphics/shader.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | pub unsafe fn create_joined(vs_fs_path: &str) -> Shader { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `debug_watch` [INFO] [stderr] --> src/graphics/shader.rs:179:5 [INFO] [stderr] | [INFO] [stderr] 179 | fn debug_watch(shader: &Shader, path: &str) -> notify::Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `World` [INFO] [stderr] --> src/world.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub struct World { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `create_entity` [INFO] [stderr] --> src/world.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn create_entity(&mut self) {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `SystemManager` [INFO] [stderr] --> src/world.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | struct SystemManager {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/graphics/mesh.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | / match material.diffuse_texture { [INFO] [stderr] 115 | | Some(ref texture) => { [INFO] [stderr] 116 | | gl::Uniform1i(gl::GetUniformLocation(shader.id, [INFO] [stderr] 117 | | c_str!("diffuse_texture").as_ptr()), [INFO] [stderr] ... | [INFO] [stderr] 121 | | None => (), [INFO] [stderr] 122 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 114 | if let Some(ref texture) = material.diffuse_texture { [INFO] [stderr] 115 | gl::Uniform1i(gl::GetUniformLocation(shader.id, [INFO] [stderr] 116 | c_str!("diffuse_texture").as_ptr()), [INFO] [stderr] 117 | 0); [INFO] [stderr] 118 | gl::BindTexture(gl::TEXTURE_2D, texture.id); [INFO] [stderr] 119 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/graphics/obj.rs:31:37 [INFO] [stderr] | [INFO] [stderr] 31 | let file = File::open(obj_path).expect(&format!("Failed to to open {}", obj_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to to open {}", obj_path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/graphics/obj.rs:111:37 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn normal(&self, positions: &Vec>) -> Vector3 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Point3]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/graphics/obj.rs:223:26 [INFO] [stderr] | [INFO] [stderr] 223 | .expect(&format!("Failed to load texture {}", texture_path.display())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to load texture {}", texture_path.display()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/graphics/shader.rs:33:47 [INFO] [stderr] | [INFO] [stderr] 33 | let mut vs_file = File::open(vs_path).expect(&format!("Failed to open {}", vs_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to open {}", vs_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/graphics/shader.rs:34:47 [INFO] [stderr] | [INFO] [stderr] 34 | let mut fs_file = File::open(fs_path).expect(&format!("Failed to open {}", fs_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to open {}", fs_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/graphics/shader.rs:41:14 [INFO] [stderr] | [INFO] [stderr] 41 | .expect(&format!("Failed to read {}", vs_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to read {}", vs_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/graphics/shader.rs:44:14 [INFO] [stderr] | [INFO] [stderr] 44 | .expect(&format!("Failed to read {}", fs_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to read {}", fs_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/graphics/shader.rs:68:47 [INFO] [stderr] | [INFO] [stderr] 68 | let mut file = File::open(vs_fs_path).expect(&format!("Failed to open {}", vs_fs_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to open {}", vs_fs_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/graphics/shader.rs:73:14 [INFO] [stderr] | [INFO] [stderr] 73 | .expect(&format!("Failed to read {}", vs_fs_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to read {}", vs_fs_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graphics/shader.rs:92:40 [INFO] [stderr] | [INFO] [stderr] 92 | unsafe fn compile_and_link(vs_src: &String, fs_src: &String) -> u32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graphics/shader.rs:92:57 [INFO] [stderr] | [INFO] [stderr] 92 | unsafe fn compile_and_link(vs_src: &String, fs_src: &String) -> u32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/graphics/shader.rs:105:26 [INFO] [stderr] | [INFO] [stderr] 105 | let mut status = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/graphics/shader.rs:107:22 [INFO] [stderr] | [INFO] [stderr] 107 | if status != (gl::TRUE as GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graphics/shader.rs:115:28 [INFO] [stderr] | [INFO] [stderr] 115 | unsafe fn compile(src: &String, shader_type: GLenum) -> GLuint { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/graphics/shader.rs:126:26 [INFO] [stderr] | [INFO] [stderr] 126 | let mut status = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/graphics/shader.rs:128:22 [INFO] [stderr] | [INFO] [stderr] 128 | if status != (gl::TRUE as GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: unsafe vector initialization [INFO] [stderr] --> src/graphics/shader.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 142 | let mut buffer = Vec::with_capacity(info_len as usize); [INFO] [stderr] | ------------------------------------- help: consider replace allocation with: `vec![0; info_len as usize]` [INFO] [stderr] 143 | buffer.set_len(info_len as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unsafe_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unsafe_vector_initialization [INFO] [stderr] [INFO] [stderr] error: unsafe vector initialization [INFO] [stderr] --> src/graphics/shader.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 160 | let mut buffer = Vec::with_capacity(info_len as usize); [INFO] [stderr] | ------------------------------------- help: consider replace allocation with: `vec![0; info_len as usize]` [INFO] [stderr] 161 | buffer.set_len(info_len as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unsafe_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / match event { [INFO] [stderr] 42 | | glutin::Event::WindowEvent { event, .. } => { [INFO] [stderr] 43 | | match event { [INFO] [stderr] 44 | | glutin::WindowEvent::Closed => state.running = false, [INFO] [stderr] ... | [INFO] [stderr] 49 | | _ => (), [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 41 | if let glutin::Event::WindowEvent { event, .. } = event { [INFO] [stderr] 42 | match event { [INFO] [stderr] 43 | glutin::WindowEvent::Closed => state.running = false, [INFO] [stderr] 44 | glutin::WindowEvent::Resized(w, h) => state.gl_window.resize(w, h), [INFO] [stderr] 45 | _ => (), [INFO] [stderr] 46 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ecs`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/main.rs:53:11 [INFO] [stderr] | [INFO] [stderr] 53 | fn render(state: &State) {} [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `shader` is never read [INFO] [stderr] --> src/main.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | let mut shader: Shader = Shader { id: 0 }; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `model_mat` is never read [INFO] [stderr] --> src/main.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | let mut model_mat = Matrix4::::one(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `shader` [INFO] [stderr] --> src/graphics/shader.rs:171:27 [INFO] [stderr] | [INFO] [stderr] 171 | fn debug_watch_thread(shader: &Shader, path: String) { [INFO] [stderr] | ^^^^^^ help: consider using `_shader` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `path` [INFO] [stderr] --> src/graphics/shader.rs:171:44 [INFO] [stderr] | [INFO] [stderr] 171 | fn debug_watch_thread(shader: &Shader, path: String) { [INFO] [stderr] | ^^^^ help: consider using `_path` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `shader` [INFO] [stderr] --> src/graphics/shader.rs:179:20 [INFO] [stderr] | [INFO] [stderr] 179 | fn debug_watch(shader: &Shader, path: &str) -> notify::Result<()> { [INFO] [stderr] | ^^^^^^ help: consider using `_shader` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `vbo` [INFO] [stderr] --> src/graphics/mesh.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | vbo: u32, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `ebo` [INFO] [stderr] --> src/graphics/mesh.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | ebo: u32, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `mat_index` [INFO] [stderr] --> src/graphics/obj.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | mat_index: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `VERTEX_DEFINE` [INFO] [stderr] --> src/graphics/shader.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | static VERTEX_DEFINE: &'static str = "#define VERTEX \n"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `FRAGMENT_DEFINE` [INFO] [stderr] --> src/graphics/shader.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | static FRAGMENT_DEFINE: &'static str = "#define FRAGMENT \n"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `create_joined` [INFO] [stderr] --> src/graphics/shader.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | pub unsafe fn create_joined(vs_fs_path: &str) -> Shader { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `debug_watch` [INFO] [stderr] --> src/graphics/shader.rs:179:5 [INFO] [stderr] | [INFO] [stderr] 179 | fn debug_watch(shader: &Shader, path: &str) -> notify::Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `World` [INFO] [stderr] --> src/world.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub struct World { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `create_entity` [INFO] [stderr] --> src/world.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn create_entity(&mut self) {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `SystemManager` [INFO] [stderr] --> src/world.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | struct SystemManager {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/graphics/mesh.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | / match material.diffuse_texture { [INFO] [stderr] 115 | | Some(ref texture) => { [INFO] [stderr] 116 | | gl::Uniform1i(gl::GetUniformLocation(shader.id, [INFO] [stderr] 117 | | c_str!("diffuse_texture").as_ptr()), [INFO] [stderr] ... | [INFO] [stderr] 121 | | None => (), [INFO] [stderr] 122 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 114 | if let Some(ref texture) = material.diffuse_texture { [INFO] [stderr] 115 | gl::Uniform1i(gl::GetUniformLocation(shader.id, [INFO] [stderr] 116 | c_str!("diffuse_texture").as_ptr()), [INFO] [stderr] 117 | 0); [INFO] [stderr] 118 | gl::BindTexture(gl::TEXTURE_2D, texture.id); [INFO] [stderr] 119 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/graphics/obj.rs:31:37 [INFO] [stderr] | [INFO] [stderr] 31 | let file = File::open(obj_path).expect(&format!("Failed to to open {}", obj_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to to open {}", obj_path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/graphics/obj.rs:111:37 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn normal(&self, positions: &Vec>) -> Vector3 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Point3]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/graphics/obj.rs:223:26 [INFO] [stderr] | [INFO] [stderr] 223 | .expect(&format!("Failed to load texture {}", texture_path.display())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to load texture {}", texture_path.display()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/graphics/shader.rs:33:47 [INFO] [stderr] | [INFO] [stderr] 33 | let mut vs_file = File::open(vs_path).expect(&format!("Failed to open {}", vs_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to open {}", vs_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/graphics/shader.rs:34:47 [INFO] [stderr] | [INFO] [stderr] 34 | let mut fs_file = File::open(fs_path).expect(&format!("Failed to open {}", fs_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to open {}", fs_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/graphics/shader.rs:41:14 [INFO] [stderr] | [INFO] [stderr] 41 | .expect(&format!("Failed to read {}", vs_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to read {}", vs_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/graphics/shader.rs:44:14 [INFO] [stderr] | [INFO] [stderr] 44 | .expect(&format!("Failed to read {}", fs_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to read {}", fs_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/graphics/shader.rs:68:47 [INFO] [stderr] | [INFO] [stderr] 68 | let mut file = File::open(vs_fs_path).expect(&format!("Failed to open {}", vs_fs_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to open {}", vs_fs_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/graphics/shader.rs:73:14 [INFO] [stderr] | [INFO] [stderr] 73 | .expect(&format!("Failed to read {}", vs_fs_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to read {}", vs_fs_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graphics/shader.rs:92:40 [INFO] [stderr] | [INFO] [stderr] 92 | unsafe fn compile_and_link(vs_src: &String, fs_src: &String) -> u32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graphics/shader.rs:92:57 [INFO] [stderr] | [INFO] [stderr] 92 | unsafe fn compile_and_link(vs_src: &String, fs_src: &String) -> u32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/graphics/shader.rs:105:26 [INFO] [stderr] | [INFO] [stderr] 105 | let mut status = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/graphics/shader.rs:107:22 [INFO] [stderr] | [INFO] [stderr] 107 | if status != (gl::TRUE as GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graphics/shader.rs:115:28 [INFO] [stderr] | [INFO] [stderr] 115 | unsafe fn compile(src: &String, shader_type: GLenum) -> GLuint { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/graphics/shader.rs:126:26 [INFO] [stderr] | [INFO] [stderr] 126 | let mut status = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/graphics/shader.rs:128:22 [INFO] [stderr] | [INFO] [stderr] 128 | if status != (gl::TRUE as GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: unsafe vector initialization [INFO] [stderr] --> src/graphics/shader.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 142 | let mut buffer = Vec::with_capacity(info_len as usize); [INFO] [stderr] | ------------------------------------- help: consider replace allocation with: `vec![0; info_len as usize]` [INFO] [stderr] 143 | buffer.set_len(info_len as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unsafe_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unsafe_vector_initialization [INFO] [stderr] [INFO] [stderr] error: unsafe vector initialization [INFO] [stderr] --> src/graphics/shader.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 160 | let mut buffer = Vec::with_capacity(info_len as usize); [INFO] [stderr] | ------------------------------------- help: consider replace allocation with: `vec![0; info_len as usize]` [INFO] [stderr] 161 | buffer.set_len(info_len as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unsafe_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / match event { [INFO] [stderr] 42 | | glutin::Event::WindowEvent { event, .. } => { [INFO] [stderr] 43 | | match event { [INFO] [stderr] 44 | | glutin::WindowEvent::Closed => state.running = false, [INFO] [stderr] ... | [INFO] [stderr] 49 | | _ => (), [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 41 | if let glutin::Event::WindowEvent { event, .. } = event { [INFO] [stderr] 42 | match event { [INFO] [stderr] 43 | glutin::WindowEvent::Closed => state.running = false, [INFO] [stderr] 44 | glutin::WindowEvent::Resized(w, h) => state.gl_window.resize(w, h), [INFO] [stderr] 45 | _ => (), [INFO] [stderr] 46 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ecs`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "71f3cdbd42db55318a1713f9b4f44783181291d0b4126c67404ffc7ad1174305"` [INFO] running `"docker" "rm" "-f" "71f3cdbd42db55318a1713f9b4f44783181291d0b4126c67404ffc7ad1174305"` [INFO] [stdout] 71f3cdbd42db55318a1713f9b4f44783181291d0b4126c67404ffc7ad1174305