[INFO] updating cached repository ordovicia/rush [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ordovicia/rush [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ordovicia/rush" "work/ex/clippy-test-run/sources/stable/gh/ordovicia/rush"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ordovicia/rush'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ordovicia/rush" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ordovicia/rush"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ordovicia/rush'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e4388c08ee6d22129453f7a8fc5946daa45a3a29 [INFO] sha for GitHub repo ordovicia/rush: e4388c08ee6d22129453f7a8fc5946daa45a3a29 [INFO] validating manifest of ordovicia/rush on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ordovicia/rush on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ordovicia/rush [INFO] finished frobbing ordovicia/rush [INFO] frobbed toml for ordovicia/rush written to work/ex/clippy-test-run/sources/stable/gh/ordovicia/rush/Cargo.toml [INFO] started frobbing ordovicia/rush [INFO] finished frobbing ordovicia/rush [INFO] frobbed toml for ordovicia/rush written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ordovicia/rush/Cargo.toml [INFO] crate ordovicia/rush has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ordovicia/rush against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ordovicia/rush:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 370c5668e2c54495472134db96fb6414d4ddfb48a297abdcf71c54dfe838c3a2 [INFO] running `"docker" "start" "-a" "370c5668e2c54495472134db96fb6414d4ddfb48a297abdcf71c54dfe838c3a2"` [INFO] [stderr] Checking libc v0.2.38 [INFO] [stderr] Checking encode_unicode v0.1.3 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking rustyline v1.0.0 [INFO] [stderr] Checking rush v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser.rs:172:19 [INFO] [stderr] | [INFO] [stderr] 172 | const EMPTY: &'static [u8] = b""; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/builtin/cd.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | env::home_dir().expect("Could not get your home directory") [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/builtin/cd.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | env::home_dir().expect("Could not get your home directory") [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `rush::Rush` [INFO] [stderr] --> src/rush.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Self { [INFO] [stderr] 14 | | Self { [INFO] [stderr] 15 | | reader: Reader::new(), [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for rush::Rush { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `rush::Rush` [INFO] [stderr] --> src/rush.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Self { [INFO] [stderr] 14 | | Self { [INFO] [stderr] 15 | | reader: Reader::new(), [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for rush::Rush { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:307:29 [INFO] [stderr] | [INFO] [stderr] 307 | remained == String::from("< file1") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"< file1"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.45s [INFO] running `"docker" "inspect" "370c5668e2c54495472134db96fb6414d4ddfb48a297abdcf71c54dfe838c3a2"` [INFO] running `"docker" "rm" "-f" "370c5668e2c54495472134db96fb6414d4ddfb48a297abdcf71c54dfe838c3a2"` [INFO] [stdout] 370c5668e2c54495472134db96fb6414d4ddfb48a297abdcf71c54dfe838c3a2