[INFO] updating cached repository ordovicia/git-rup [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ordovicia/git-rup [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ordovicia/git-rup" "work/ex/clippy-test-run/sources/stable/gh/ordovicia/git-rup"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ordovicia/git-rup'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ordovicia/git-rup" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ordovicia/git-rup"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ordovicia/git-rup'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fe23b431e8332af61749cfdad2e66f9e9b8e5129 [INFO] sha for GitHub repo ordovicia/git-rup: fe23b431e8332af61749cfdad2e66f9e9b8e5129 [INFO] validating manifest of ordovicia/git-rup on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ordovicia/git-rup on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ordovicia/git-rup [INFO] finished frobbing ordovicia/git-rup [INFO] frobbed toml for ordovicia/git-rup written to work/ex/clippy-test-run/sources/stable/gh/ordovicia/git-rup/Cargo.toml [INFO] started frobbing ordovicia/git-rup [INFO] finished frobbing ordovicia/git-rup [INFO] frobbed toml for ordovicia/git-rup written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ordovicia/git-rup/Cargo.toml [INFO] crate ordovicia/git-rup has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ordovicia/git-rup against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ordovicia/git-rup:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0df2a388592d82e80dfd059e1d8cd4d86b8e0956ea0679bbe80b9207e7b152d3 [INFO] running `"docker" "start" "-a" "0df2a388592d82e80dfd059e1d8cd4d86b8e0956ea0679bbe80b9207e7b152d3"` [INFO] [stderr] Compiling libz-sys v1.0.13 [INFO] [stderr] Compiling cmake v0.1.21 [INFO] [stderr] Compiling curl-sys v0.3.10 [INFO] [stderr] Compiling libssh2-sys v0.2.5 [INFO] [stderr] Compiling libgit2-sys v0.6.7 [INFO] [stderr] Checking git2 v0.6.4 [INFO] [stderr] Checking git-rup v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/operations.rs:33:24 [INFO] [stderr] | [INFO] [stderr] 33 | if let Some(_) = remote.url() { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 34 | | Ok(repo.find_remote(name).unwrap()) [INFO] [stderr] 35 | | } else { [INFO] [stderr] 36 | | Err(Error::from_str(&format!("x {} non UTF-8 remote URL", name))) [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________________- help: try this: `if remote.url().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 36 [INFO] [stderr] --> src/main.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | / fn main() { [INFO] [stderr] 23 | | let args = env::args().collect::>(); [INFO] [stderr] 24 | | [INFO] [stderr] 25 | | // program options [INFO] [stderr] ... | [INFO] [stderr] 160 | | } [INFO] [stderr] 161 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/main.rs:60:21 [INFO] [stderr] | [INFO] [stderr] 60 | let _ = try_unwrap!(operations::fetch(&mut remote)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:136:12 [INFO] [stderr] | [INFO] [stderr] 136 | if submodules.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!submodules.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/main.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | let _ = try_unwrap!(sb.sync()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/main.rs:151:17 [INFO] [stderr] | [INFO] [stderr] 151 | let _ = try_unwrap!(sb.reload(false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/main.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | let _ = try_unwrap!(operations::stash_pop(&mut repo)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/operations.rs:33:24 [INFO] [stderr] | [INFO] [stderr] 33 | if let Some(_) = remote.url() { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 34 | | Ok(repo.find_remote(name).unwrap()) [INFO] [stderr] 35 | | } else { [INFO] [stderr] 36 | | Err(Error::from_str(&format!("x {} non UTF-8 remote URL", name))) [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________________- help: try this: `if remote.url().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 36 [INFO] [stderr] --> src/main.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | / fn main() { [INFO] [stderr] 23 | | let args = env::args().collect::>(); [INFO] [stderr] 24 | | [INFO] [stderr] 25 | | // program options [INFO] [stderr] ... | [INFO] [stderr] 160 | | } [INFO] [stderr] 161 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/main.rs:60:21 [INFO] [stderr] | [INFO] [stderr] 60 | let _ = try_unwrap!(operations::fetch(&mut remote)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:136:12 [INFO] [stderr] | [INFO] [stderr] 136 | if submodules.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!submodules.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/main.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | let _ = try_unwrap!(sb.sync()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/main.rs:151:17 [INFO] [stderr] | [INFO] [stderr] 151 | let _ = try_unwrap!(sb.reload(false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/main.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | let _ = try_unwrap!(operations::stash_pop(&mut repo)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 29s [INFO] running `"docker" "inspect" "0df2a388592d82e80dfd059e1d8cd4d86b8e0956ea0679bbe80b9207e7b152d3"` [INFO] running `"docker" "rm" "-f" "0df2a388592d82e80dfd059e1d8cd4d86b8e0956ea0679bbe80b9207e7b152d3"` [INFO] [stdout] 0df2a388592d82e80dfd059e1d8cd4d86b8e0956ea0679bbe80b9207e7b152d3