[INFO] updating cached repository ooooak/sql-split [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ooooak/sql-split [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ooooak/sql-split" "work/ex/clippy-test-run/sources/stable/gh/ooooak/sql-split"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ooooak/sql-split'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ooooak/sql-split" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ooooak/sql-split"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ooooak/sql-split'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bbb82aaa91c353d3d4d5c393698ed3bd8f545867 [INFO] sha for GitHub repo ooooak/sql-split: bbb82aaa91c353d3d4d5c393698ed3bd8f545867 [INFO] validating manifest of ooooak/sql-split on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ooooak/sql-split on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ooooak/sql-split [INFO] finished frobbing ooooak/sql-split [INFO] frobbed toml for ooooak/sql-split written to work/ex/clippy-test-run/sources/stable/gh/ooooak/sql-split/Cargo.toml [INFO] started frobbing ooooak/sql-split [INFO] finished frobbing ooooak/sql-split [INFO] frobbed toml for ooooak/sql-split written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ooooak/sql-split/Cargo.toml [INFO] crate ooooak/sql-split has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ooooak/sql-split against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ooooak/sql-split:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 42e47f43a931a5408a163b0c28b568c87b125b18ff475cdb75d5ee2fbac4b829 [INFO] running `"docker" "start" "-a" "42e47f43a931a5408a163b0c28b568c87b125b18ff475cdb75d5ee2fbac4b829"` [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking sql-split v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/splitter.rs:25:47 [INFO] [stderr] | [INFO] [stderr] 25 | FileState::New => write!(f, "{}", "New"), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/splitter.rs:26:52 [INFO] [stderr] | [INFO] [stderr] 26 | FileState::Continue => write!(f, "{}", "Continue") [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/splitter.rs:25:47 [INFO] [stderr] | [INFO] [stderr] 25 | FileState::New => write!(f, "{}", "New"), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/splitter.rs:26:52 [INFO] [stderr] | [INFO] [stderr] 26 | FileState::Continue => write!(f, "{}", "Continue") [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:54:24 [INFO] [stderr] | [INFO] [stderr] 54 | if first_file == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `first_file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/parser.rs:264:5 [INFO] [stderr] | [INFO] [stderr] 264 | / fn tokenizer(){ [INFO] [stderr] 265 | | let file = File::open("./example-files/1.txt").unwrap(); [INFO] [stderr] 266 | | let tokenizer = Tokenizer::new(Reader::new(file)); [INFO] [stderr] 267 | | [INFO] [stderr] ... | [INFO] [stderr] 331 | | assert!(state, msg); [INFO] [stderr] 332 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:54:24 [INFO] [stderr] | [INFO] [stderr] 54 | if first_file == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `first_file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.45s [INFO] running `"docker" "inspect" "42e47f43a931a5408a163b0c28b568c87b125b18ff475cdb75d5ee2fbac4b829"` [INFO] running `"docker" "rm" "-f" "42e47f43a931a5408a163b0c28b568c87b125b18ff475cdb75d5ee2fbac4b829"` [INFO] [stdout] 42e47f43a931a5408a163b0c28b568c87b125b18ff475cdb75d5ee2fbac4b829