[INFO] updating cached repository onur/sysinfo-web [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/onur/sysinfo-web [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/onur/sysinfo-web" "work/ex/clippy-test-run/sources/stable/gh/onur/sysinfo-web"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/onur/sysinfo-web'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/onur/sysinfo-web" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/onur/sysinfo-web"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/onur/sysinfo-web'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] acaf0fd1bdff4976449943b8089df3b948803618 [INFO] sha for GitHub repo onur/sysinfo-web: acaf0fd1bdff4976449943b8089df3b948803618 [INFO] validating manifest of onur/sysinfo-web on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of onur/sysinfo-web on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing onur/sysinfo-web [INFO] finished frobbing onur/sysinfo-web [INFO] frobbed toml for onur/sysinfo-web written to work/ex/clippy-test-run/sources/stable/gh/onur/sysinfo-web/Cargo.toml [INFO] started frobbing onur/sysinfo-web [INFO] finished frobbing onur/sysinfo-web [INFO] frobbed toml for onur/sysinfo-web written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/onur/sysinfo-web/Cargo.toml [INFO] crate onur/sysinfo-web has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting onur/sysinfo-web against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/onur/sysinfo-web:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b72f2d68808b75c330660ae45e703b3ccf4659027a2abf7267183aa5d363579d [INFO] running `"docker" "start" "-a" "b72f2d68808b75c330660ae45e703b3ccf4659027a2abf7267183aa5d363579d"` [INFO] [stderr] Compiling libc v0.2.41 [INFO] [stderr] Compiling sysinfo v0.5.6 [INFO] [stderr] Checking hostname v0.1.4 [INFO] [stderr] Compiling miniz-sys v0.1.10 [INFO] [stderr] Checking hyper v0.10.13 [INFO] [stderr] Compiling rand v0.4.2 [INFO] [stderr] Checking flate2 v1.0.1 [INFO] [stderr] Compiling phf_generator v0.7.22 [INFO] [stderr] Compiling phf_codegen v0.7.22 [INFO] [stderr] Compiling mime_guess v1.8.4 [INFO] [stderr] Checking iron v0.6.0 [INFO] [stderr] Checking sysinfo-web v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/web.rs:28:20 [INFO] [stderr] | [INFO] [stderr] 28 | const INDEX_HTML: &'static [u8] = include_bytes!("index.html"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/web.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | const FAVICON: &'static [u8] = include_bytes!("../resources/favicon.ico"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/web.rs:28:20 [INFO] [stderr] | [INFO] [stderr] 28 | const INDEX_HTML: &'static [u8] = include_bytes!("index.html"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/web.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | const FAVICON: &'static [u8] = include_bytes!("../resources/favicon.ico"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/sysinfo_serde.rs:101:32 [INFO] [stderr] | [INFO] [stderr] 101 | impl<'a> Serialize for Ser<'a, HashMap> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 101 | impl<'a, S: ::std::hash::BuildHasher> Serialize for Ser<'a, HashMap> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/sysinfo_serde.rs:101:32 [INFO] [stderr] | [INFO] [stderr] 101 | impl<'a> Serialize for Ser<'a, HashMap> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 101 | impl<'a, S: ::std::hash::BuildHasher> Serialize for Ser<'a, HashMap> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/sysinfo_ext.rs:40:38 [INFO] [stderr] | [INFO] [stderr] 40 | hostname: get_hostname().unwrap_or("Unknown".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "Unknown".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/sysinfo_ext.rs:41:34 [INFO] [stderr] | [INFO] [stderr] 41 | uptime: get_uptime().unwrap_or("Unknown".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "Unknown".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/sysinfo_ext.rs:85:41 [INFO] [stderr] | [INFO] [stderr] 85 | Ok(String::from_utf8(output.stdout).unwrap_or("Unknown".to_owned())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "Unknown".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/sysinfo_ext.rs:40:38 [INFO] [stderr] | [INFO] [stderr] 40 | hostname: get_hostname().unwrap_or("Unknown".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "Unknown".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/sysinfo_ext.rs:41:34 [INFO] [stderr] | [INFO] [stderr] 41 | uptime: get_uptime().unwrap_or("Unknown".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "Unknown".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/web.rs:153:44 [INFO] [stderr] | [INFO] [stderr] 153 | .unwrap_or(String::from("[]"))).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("[]"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/web.rs:165:35 [INFO] [stderr] | [INFO] [stderr] 165 | let ret = iron.http(sock_addr.unwrap_or("localhost:3000".to_owned())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "localhost:3000".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/sysinfo_ext.rs:85:41 [INFO] [stderr] | [INFO] [stderr] 85 | Ok(String::from_utf8(output.stdout).unwrap_or("Unknown".to_owned())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "Unknown".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/web.rs:153:44 [INFO] [stderr] | [INFO] [stderr] 153 | .unwrap_or(String::from("[]"))).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("[]"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/web.rs:165:35 [INFO] [stderr] | [INFO] [stderr] 165 | let ret = iron.http(sock_addr.unwrap_or("localhost:3000".to_owned())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "localhost:3000".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.43s [INFO] running `"docker" "inspect" "b72f2d68808b75c330660ae45e703b3ccf4659027a2abf7267183aa5d363579d"` [INFO] running `"docker" "rm" "-f" "b72f2d68808b75c330660ae45e703b3ccf4659027a2abf7267183aa5d363579d"` [INFO] [stdout] b72f2d68808b75c330660ae45e703b3ccf4659027a2abf7267183aa5d363579d