[INFO] updating cached repository onur/i3blocks-scripts [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/onur/i3blocks-scripts [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/onur/i3blocks-scripts" "work/ex/clippy-test-run/sources/stable/gh/onur/i3blocks-scripts"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/onur/i3blocks-scripts'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/onur/i3blocks-scripts" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/onur/i3blocks-scripts"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/onur/i3blocks-scripts'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9b305650a99ce4488d303bc159e3232cbc27ee3b [INFO] sha for GitHub repo onur/i3blocks-scripts: 9b305650a99ce4488d303bc159e3232cbc27ee3b [INFO] validating manifest of onur/i3blocks-scripts on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of onur/i3blocks-scripts on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing onur/i3blocks-scripts [INFO] finished frobbing onur/i3blocks-scripts [INFO] frobbed toml for onur/i3blocks-scripts written to work/ex/clippy-test-run/sources/stable/gh/onur/i3blocks-scripts/Cargo.toml [INFO] started frobbing onur/i3blocks-scripts [INFO] finished frobbing onur/i3blocks-scripts [INFO] frobbed toml for onur/i3blocks-scripts written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/onur/i3blocks-scripts/Cargo.toml [INFO] crate onur/i3blocks-scripts has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting onur/i3blocks-scripts against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/onur/i3blocks-scripts:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f1c0622f77631d3339a3c10cf621387a2a2b8ad03e9de87f77b056d77265577e [INFO] running `"docker" "start" "-a" "f1c0622f77631d3339a3c10cf621387a2a2b8ad03e9de87f77b056d77265577e"` [INFO] [stderr] Checking i3blocks-scripts v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:16:19 [INFO] [stderr] | [INFO] [stderr] 16 | pub struct Script(HashMap Option>>); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:30:19 [INFO] [stderr] | [INFO] [stderr] 30 | name: var("BLOCK_name").map(|b| b.to_owned()).unwrap_or(String::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `var("BLOCK_name").map(|b| b.to_owned()).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Script` [INFO] [stderr] --> src/lib.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / pub fn new() -> Script { [INFO] [stderr] 50 | | Script(HashMap::new()) [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:16:19 [INFO] [stderr] | [INFO] [stderr] 16 | pub struct Script(HashMap Option>>); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:30:19 [INFO] [stderr] | [INFO] [stderr] 30 | name: var("BLOCK_name").map(|b| b.to_owned()).unwrap_or(String::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `var("BLOCK_name").map(|b| b.to_owned()).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Script` [INFO] [stderr] --> src/lib.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / pub fn new() -> Script { [INFO] [stderr] 50 | | Script(HashMap::new()) [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.75s [INFO] running `"docker" "inspect" "f1c0622f77631d3339a3c10cf621387a2a2b8ad03e9de87f77b056d77265577e"` [INFO] running `"docker" "rm" "-f" "f1c0622f77631d3339a3c10cf621387a2a2b8ad03e9de87f77b056d77265577e"` [INFO] [stdout] f1c0622f77631d3339a3c10cf621387a2a2b8ad03e9de87f77b056d77265577e