[INFO] updating cached repository onigra/ec2ips
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/onigra/ec2ips
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/onigra/ec2ips" "work/ex/clippy-test-run/sources/stable/gh/onigra/ec2ips"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/onigra/ec2ips'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/onigra/ec2ips" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/onigra/ec2ips"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/onigra/ec2ips'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 734cb2d1249c136e6aec2b18bc385c5747493fb3
[INFO] sha for GitHub repo onigra/ec2ips: 734cb2d1249c136e6aec2b18bc385c5747493fb3
[INFO] validating manifest of onigra/ec2ips on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of onigra/ec2ips on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing onigra/ec2ips
[INFO] finished frobbing onigra/ec2ips
[INFO] frobbed toml for onigra/ec2ips written to work/ex/clippy-test-run/sources/stable/gh/onigra/ec2ips/Cargo.toml
[INFO] started frobbing onigra/ec2ips
[INFO] finished frobbing onigra/ec2ips
[INFO] frobbed toml for onigra/ec2ips written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/onigra/ec2ips/Cargo.toml
[INFO] crate onigra/ec2ips has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting onigra/ec2ips against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/onigra/ec2ips:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 00efac5d203db076e9493566dd6a93d186f9b0b36209f572d193b32609e856d0
[INFO] running `"docker" "start" "-a" "00efac5d203db076e9493566dd6a93d186f9b0b36209f572d193b32609e856d0"`
[INFO] [stderr]     Checking crossbeam-utils v0.3.2
[INFO] [stderr]     Checking log v0.4.3
[INFO] [stderr]    Compiling openssl-sys v0.9.35
[INFO] [stderr]     Checking tokio-executor v0.1.3
[INFO] [stderr]     Checking bytes v0.4.9
[INFO] [stderr]     Checking serde_json v1.0.24
[INFO] [stderr]    Compiling rusoto_core v0.33.1
[INFO] [stderr]     Checking chrono v0.4.5
[INFO] [stderr]     Checking regex v0.2.11
[INFO] [stderr]     Checking sha2 v0.7.1
[INFO] [stderr]     Checking mio v0.6.15
[INFO] [stderr]     Checking want v0.0.6
[INFO] [stderr]     Checking tokio-timer v0.2.5
[INFO] [stderr]     Checking crossbeam-epoch v0.4.3
[INFO] [stderr]     Checking tokio-io v0.1.7
[INFO] [stderr]     Checking http v0.1.10
[INFO] [stderr]    Compiling openssl v0.9.24
[INFO] [stderr]     Checking crossbeam-deque v0.3.1
[INFO] [stderr]     Checking tokio-threadpool v0.1.5
[INFO] [stderr]     Checking tokio-codec v0.1.0
[INFO] [stderr]     Checking tokio-reactor v0.1.3
[INFO] [stderr]     Checking tokio-udp v0.1.1
[INFO] [stderr]     Checking tokio-tcp v0.1.1
[INFO] [stderr]     Checking tokio-fs v0.1.3
[INFO] [stderr]     Checking tokio v0.1.7
[INFO] [stderr]     Checking native-tls v0.1.5
[INFO] [stderr]     Checking tokio-core v0.1.17
[INFO] [stderr]     Checking h2 v0.1.12
[INFO] [stderr]     Checking tokio-tls v0.1.4
[INFO] [stderr]     Checking hyper v0.12.8
[INFO] [stderr]     Checking hyper-tls v0.2.1
[INFO] [stderr]     Checking rusoto_credential v0.12.0
[INFO] [stderr]     Checking rusoto_ec2 v0.33.1
[INFO] [stderr]     Checking ec2ips v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:8:5
[INFO] [stderr]    |
[INFO] [stderr] 8  | /     return reservations
[INFO] [stderr] 9  | |         .into_iter()
[INFO] [stderr] 10 | |         .flat_map(|reservation| reservation.instances)
[INFO] [stderr] 11 | |         .flat_map(|instance| instance)
[INFO] [stderr] 12 | |         .collect::<Vec<Instance>>();
[INFO] [stderr]    | |____________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 8  |     reservations
[INFO] [stderr] 9  |         .into_iter()
[INFO] [stderr] 10 |         .flat_map(|reservation| reservation.instances)
[INFO] [stderr] 11 |         .flat_map(|instance| instance)
[INFO] [stderr] 12 |         .collect::<Vec<Instance>>()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 | /     return tag_list
[INFO] [stderr] 17 | |         .into_iter()
[INFO] [stderr] 18 | |         .find(|tag| tag.key == Some("Name".to_string()))
[INFO] [stderr] 19 | |         .map_or("".to_string(), |t| t.value.unwrap_or("".to_string()));
[INFO] [stderr]    | |_______________________________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 16 |     tag_list
[INFO] [stderr] 17 |         .into_iter()
[INFO] [stderr] 18 |         .find(|tag| tag.key == Some("Name".to_string()))
[INFO] [stderr] 19 |         .map_or("".to_string(), |t| t.value.unwrap_or("".to_string()))
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:8:5
[INFO] [stderr]    |
[INFO] [stderr] 8  | /     return reservations
[INFO] [stderr] 9  | |         .into_iter()
[INFO] [stderr] 10 | |         .flat_map(|reservation| reservation.instances)
[INFO] [stderr] 11 | |         .flat_map(|instance| instance)
[INFO] [stderr] 12 | |         .collect::<Vec<Instance>>();
[INFO] [stderr]    | |____________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 8  |     reservations
[INFO] [stderr] 9  |         .into_iter()
[INFO] [stderr] 10 |         .flat_map(|reservation| reservation.instances)
[INFO] [stderr] 11 |         .flat_map(|instance| instance)
[INFO] [stderr] 12 |         .collect::<Vec<Instance>>()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 | /     return tag_list
[INFO] [stderr] 17 | |         .into_iter()
[INFO] [stderr] 18 | |         .find(|tag| tag.key == Some("Name".to_string()))
[INFO] [stderr] 19 | |         .map_or("".to_string(), |t| t.value.unwrap_or("".to_string()));
[INFO] [stderr]    | |_______________________________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 16 |     tag_list
[INFO] [stderr] 17 |         .into_iter()
[INFO] [stderr] 18 |         .find(|tag| tag.key == Some("Name".to_string()))
[INFO] [stderr] 19 |         .map_or("".to_string(), |t| t.value.unwrap_or("".to_string()))
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:19:45
[INFO] [stderr]    |
[INFO] [stderr] 19 |         .map_or("".to_string(), |t| t.value.unwrap_or("".to_string()));
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:19:45
[INFO] [stderr]    |
[INFO] [stderr] 19 |         .map_or("".to_string(), |t| t.value.unwrap_or("".to_string()));
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:53:58
[INFO] [stderr]    |
[INFO] [stderr] 53 |                         vec![instance.private_ip_address.unwrap_or("".to_string()), tag]
[INFO] [stderr]    |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:53:58
[INFO] [stderr]    |
[INFO] [stderr] 53 |                         vec![instance.private_ip_address.unwrap_or("".to_string()), tag]
[INFO] [stderr]    |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 12s
[INFO] running `"docker" "inspect" "00efac5d203db076e9493566dd6a93d186f9b0b36209f572d193b32609e856d0"`
[INFO] running `"docker" "rm" "-f" "00efac5d203db076e9493566dd6a93d186f9b0b36209f572d193b32609e856d0"`
[INFO] [stdout] 00efac5d203db076e9493566dd6a93d186f9b0b36209f572d193b32609e856d0