[INFO] updating cached repository onesk/aoc2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/onesk/aoc2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/onesk/aoc2018" "work/ex/clippy-test-run/sources/stable/gh/onesk/aoc2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/onesk/aoc2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/onesk/aoc2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/onesk/aoc2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/onesk/aoc2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3d18ae1d341864fb59bb7140504d37c17cf2c8f4 [INFO] sha for GitHub repo onesk/aoc2018: 3d18ae1d341864fb59bb7140504d37c17cf2c8f4 [INFO] validating manifest of onesk/aoc2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of onesk/aoc2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing onesk/aoc2018 [INFO] finished frobbing onesk/aoc2018 [INFO] frobbed toml for onesk/aoc2018 written to work/ex/clippy-test-run/sources/stable/gh/onesk/aoc2018/Cargo.toml [INFO] started frobbing onesk/aoc2018 [INFO] finished frobbing onesk/aoc2018 [INFO] frobbed toml for onesk/aoc2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/onesk/aoc2018/Cargo.toml [INFO] crate onesk/aoc2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting onesk/aoc2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/onesk/aoc2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5938b346b059acca4cc0173641fe8d90e96a51b408376cf903c987ed22677c24 [INFO] running `"docker" "start" "-a" "5938b346b059acca4cc0173641fe8d90e96a51b408376cf903c987ed22677c24"` [INFO] [stderr] Compiling ndarray v0.12.1 [INFO] [stderr] Checking num-complex v0.2.1 [INFO] [stderr] Checking aoc2018 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/6.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | const INPUT: &'static str = include_str!("inputs/6.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/5.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | const INPUT: &'static str = include_str!("inputs/5.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/5.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | const INPUT: &'static str = include_str!("inputs/5.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/1.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | const INPUT: &'static str = include_str!("inputs/1.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bin/5.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / match w { [INFO] [stderr] 10 | | &[c1, c2] => [INFO] [stderr] 11 | | c1.to_ascii_lowercase() == c2.to_ascii_lowercase() && [INFO] [stderr] 12 | | c1.is_lowercase() != c2.is_lowercase(), [INFO] [stderr] 13 | | [INFO] [stderr] 14 | | _ => false [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 9 | match *w { [INFO] [stderr] 10 | [c1, c2] => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/1.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | const INPUT: &'static str = include_str!("inputs/1.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bin/5.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / match w { [INFO] [stderr] 10 | | &[c1, c2] => [INFO] [stderr] 11 | | c1.to_ascii_lowercase() == c2.to_ascii_lowercase() && [INFO] [stderr] 12 | | c1.is_lowercase() != c2.is_lowercase(), [INFO] [stderr] 13 | | [INFO] [stderr] 14 | | _ => false [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 9 | match *w { [INFO] [stderr] 10 | [c1, c2] => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/bin/1.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | let ans = numbers().fold(0, |s, n| s+n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/2.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | const INPUT: &'static str = include_str!("inputs/2.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/bin/1.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | let ans = numbers().fold(0, |s, n| s+n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/6.rs:22:16 [INFO] [stderr] | [INFO] [stderr] 22 | fn adj<'a>(&'a self) -> impl Iterator + 'a { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/6.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | fn dist(&self, other: &Point) -> i32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/6.rs:26:27 [INFO] [stderr] | [INFO] [stderr] 26 | fn dist(&self, other: &Point) -> i32 { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/6.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | self.min..(self.max+1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.min..=self.max` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bin/6.rs:88:25 [INFO] [stderr] | [INFO] [stderr] 88 | .and_then(|vec| match vec.as_slice() { [INFO] [stderr] | _________________________^ [INFO] [stderr] 89 | | &[x, y] => Some(Point{ x, y }), [INFO] [stderr] 90 | | _ => None [INFO] [stderr] 91 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 88 | .and_then(|vec| match *vec.as_slice() { [INFO] [stderr] 89 | [x, y] => Some(Point{ x, y }), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `.filter_map` can be written more simply using `.filter` [INFO] [stderr] --> src/bin/6.rs:185:23 [INFO] [stderr] | [INFO] [stderr] 185 | let region_size = wide_aabb.domain().filter_map(|domain_p| { [INFO] [stderr] | _______________________^ [INFO] [stderr] 186 | | let below_threshold = points.iter() [INFO] [stderr] 187 | | .scan(0, |state, &p| { [INFO] [stderr] 188 | | *state += p.dist(&domain_p); [INFO] [stderr] ... | [INFO] [stderr] 194 | | if below_threshold == points.len() { Some(domain_p) } else { None } [INFO] [stderr] 195 | | }).count(); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_filter_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/4.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | const INPUT: &'static str = include_str!("inputs/4.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/4.rs:3:19 [INFO] [stderr] | [INFO] [stderr] 3 | const RE_PREFIX: &'static str = r"\[\d{4}-\d{2}-\d{2} \d{2}:\d{2}\]"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/4.rs:4:18 [INFO] [stderr] | [INFO] [stderr] 4 | const RE_GUARD: &'static str = r"^ Guard #(?P\d+) begins shift$"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/4.rs:5:18 [INFO] [stderr] | [INFO] [stderr] 5 | const RE_SLEEP: &'static str = r"^ falls asleep$"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/4.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | const RE_AWAKE: &'static str = r"^ wakes up$"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/4.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | const INPUT: &'static str = include_str!("inputs/4.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/4.rs:3:19 [INFO] [stderr] | [INFO] [stderr] 3 | const RE_PREFIX: &'static str = r"\[\d{4}-\d{2}-\d{2} \d{2}:\d{2}\]"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/4.rs:4:18 [INFO] [stderr] | [INFO] [stderr] 4 | const RE_GUARD: &'static str = r"^ Guard #(?P\d+) begins shift$"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/4.rs:5:18 [INFO] [stderr] | [INFO] [stderr] 5 | const RE_SLEEP: &'static str = r"^ falls asleep$"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/4.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | const RE_AWAKE: &'static str = r"^ wakes up$"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/bin/4.rs:20:45 [INFO] [stderr] | [INFO] [stderr] 20 | static ref re_sleep: Regex = Regex::new(RE_SLEEP).expect("regex should compile"); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `==` on `str`s [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/bin/4.rs:21:45 [INFO] [stderr] | [INFO] [stderr] 21 | static ref re_awake: Regex = Regex::new(RE_AWAKE).expect("regex should compile"); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `==` on `str`s [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bin/4.rs:128:63 [INFO] [stderr] | [INFO] [stderr] 128 | let (best_guard_id, _) = stats.iter().max_by_key(|(_, v)| v.total_asleep.clone()).expect("longest sleep exists"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `v.total_asleep` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/bin/4.rs:129:94 [INFO] [stderr] | [INFO] [stderr] 129 | let (best_minute, _) = stats[best_guard_id].freqs.iter().enumerate().max_by_key(|(_, f)| f.clone()).expect("max freq exists"); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 129 | let (best_minute, _) = stats[best_guard_id].freqs.iter().enumerate().max_by_key(|(_, f)| &(*f).clone()).expect("max freq exists"); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 129 | let (best_minute, _) = stats[best_guard_id].freqs.iter().enumerate().max_by_key(|(_, f)| &usize::clone(f)).expect("max freq exists"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/bin/4.rs:138:103 [INFO] [stderr] | [INFO] [stderr] 138 | .map(|(guard_id, Stats{ freqs, .. })| (guard_id, freqs.iter().enumerate().max_by_key(|(_, f)| f.clone()).expect("max freq exists"))) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 138 | .map(|(guard_id, Stats{ freqs, .. })| (guard_id, freqs.iter().enumerate().max_by_key(|(_, f)| &(*f).clone()).expect("max freq exists"))) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 138 | .map(|(guard_id, Stats{ freqs, .. })| (guard_id, freqs.iter().enumerate().max_by_key(|(_, f)| &usize::clone(f)).expect("max freq exists"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/bin/4.rs:139:35 [INFO] [stderr] | [INFO] [stderr] 139 | .max_by_key(|(_, (_, f))| f.clone()).expect("best guard exists"); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 139 | .max_by_key(|(_, (_, f))| &(*f).clone()).expect("best guard exists"); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 139 | .max_by_key(|(_, (_, f))| &usize::clone(f)).expect("best guard exists"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `aoc2018`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/3.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | const INPUT: &'static str = include_str!("inputs/3.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/6.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | const INPUT: &'static str = include_str!("inputs/6.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bin/3.rs:35:27 [INFO] [stderr] | [INFO] [stderr] 35 | .filter_map(|uss| match uss.as_slice() { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 36 | | &[id, x, y, w, h] => Some(Rect{ id, x, y, w, h}), [INFO] [stderr] 37 | | _ => None [INFO] [stderr] 38 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | .filter_map(|uss| match *uss.as_slice() { [INFO] [stderr] 36 | [id, x, y, w, h] => Some(Rect{ id, x, y, w, h}), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/3.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | fn fill(&self) -> CellRect { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/6.rs:22:16 [INFO] [stderr] | [INFO] [stderr] 22 | fn adj<'a>(&'a self) -> impl Iterator + 'a { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/6.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | fn dist(&self, other: &Point) -> i32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/6.rs:26:27 [INFO] [stderr] | [INFO] [stderr] 26 | fn dist(&self, other: &Point) -> i32 { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/6.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | self.min..(self.max+1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.min..=self.max` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bin/6.rs:88:25 [INFO] [stderr] | [INFO] [stderr] 88 | .and_then(|vec| match vec.as_slice() { [INFO] [stderr] | _________________________^ [INFO] [stderr] 89 | | &[x, y] => Some(Point{ x, y }), [INFO] [stderr] 90 | | _ => None [INFO] [stderr] 91 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 88 | .and_then(|vec| match *vec.as_slice() { [INFO] [stderr] 89 | [x, y] => Some(Point{ x, y }), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `.filter_map` can be written more simply using `.filter` [INFO] [stderr] --> src/bin/6.rs:185:23 [INFO] [stderr] | [INFO] [stderr] 185 | let region_size = wide_aabb.domain().filter_map(|domain_p| { [INFO] [stderr] | _______________________^ [INFO] [stderr] 186 | | let below_threshold = points.iter() [INFO] [stderr] 187 | | .scan(0, |state, &p| { [INFO] [stderr] 188 | | *state += p.dist(&domain_p); [INFO] [stderr] ... | [INFO] [stderr] 194 | | if below_threshold == points.len() { Some(domain_p) } else { None } [INFO] [stderr] 195 | | }).count(); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_filter_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/bin/4.rs:20:45 [INFO] [stderr] | [INFO] [stderr] 20 | static ref re_sleep: Regex = Regex::new(RE_SLEEP).expect("regex should compile"); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `==` on `str`s [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/bin/4.rs:21:45 [INFO] [stderr] | [INFO] [stderr] 21 | static ref re_awake: Regex = Regex::new(RE_AWAKE).expect("regex should compile"); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `==` on `str`s [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bin/4.rs:128:63 [INFO] [stderr] | [INFO] [stderr] 128 | let (best_guard_id, _) = stats.iter().max_by_key(|(_, v)| v.total_asleep.clone()).expect("longest sleep exists"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `v.total_asleep` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/bin/4.rs:129:94 [INFO] [stderr] | [INFO] [stderr] 129 | let (best_minute, _) = stats[best_guard_id].freqs.iter().enumerate().max_by_key(|(_, f)| f.clone()).expect("max freq exists"); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 129 | let (best_minute, _) = stats[best_guard_id].freqs.iter().enumerate().max_by_key(|(_, f)| &(*f).clone()).expect("max freq exists"); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 129 | let (best_minute, _) = stats[best_guard_id].freqs.iter().enumerate().max_by_key(|(_, f)| &usize::clone(f)).expect("max freq exists"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/bin/4.rs:138:103 [INFO] [stderr] | [INFO] [stderr] 138 | .map(|(guard_id, Stats{ freqs, .. })| (guard_id, freqs.iter().enumerate().max_by_key(|(_, f)| f.clone()).expect("max freq exists"))) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 138 | .map(|(guard_id, Stats{ freqs, .. })| (guard_id, freqs.iter().enumerate().max_by_key(|(_, f)| &(*f).clone()).expect("max freq exists"))) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 138 | .map(|(guard_id, Stats{ freqs, .. })| (guard_id, freqs.iter().enumerate().max_by_key(|(_, f)| &usize::clone(f)).expect("max freq exists"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/bin/4.rs:139:35 [INFO] [stderr] | [INFO] [stderr] 139 | .max_by_key(|(_, (_, f))| f.clone()).expect("best guard exists"); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 139 | .max_by_key(|(_, (_, f))| &(*f).clone()).expect("best guard exists"); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 139 | .max_by_key(|(_, (_, f))| &usize::clone(f)).expect("best guard exists"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `aoc2018`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/2.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | const INPUT: &'static str = include_str!("inputs/2.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/3.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | const INPUT: &'static str = include_str!("inputs/3.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bin/3.rs:35:27 [INFO] [stderr] | [INFO] [stderr] 35 | .filter_map(|uss| match uss.as_slice() { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 36 | | &[id, x, y, w, h] => Some(Rect{ id, x, y, w, h}), [INFO] [stderr] 37 | | _ => None [INFO] [stderr] 38 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | .filter_map(|uss| match *uss.as_slice() { [INFO] [stderr] 36 | [id, x, y, w, h] => Some(Rect{ id, x, y, w, h}), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/3.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | fn fill(&self) -> CellRect { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "5938b346b059acca4cc0173641fe8d90e96a51b408376cf903c987ed22677c24"` [INFO] running `"docker" "rm" "-f" "5938b346b059acca4cc0173641fe8d90e96a51b408376cf903c987ed22677c24"` [INFO] [stdout] 5938b346b059acca4cc0173641fe8d90e96a51b408376cf903c987ed22677c24