[INFO] updating cached repository onelson/loose-coupling [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/onelson/loose-coupling [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/onelson/loose-coupling" "work/ex/clippy-test-run/sources/stable/gh/onelson/loose-coupling"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/onelson/loose-coupling'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/onelson/loose-coupling" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/onelson/loose-coupling"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/onelson/loose-coupling'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4f9f11af233ce1d8de3d3f1e7f8c419da841f53f [INFO] sha for GitHub repo onelson/loose-coupling: 4f9f11af233ce1d8de3d3f1e7f8c419da841f53f [INFO] validating manifest of onelson/loose-coupling on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of onelson/loose-coupling on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing onelson/loose-coupling [INFO] finished frobbing onelson/loose-coupling [INFO] frobbed toml for onelson/loose-coupling written to work/ex/clippy-test-run/sources/stable/gh/onelson/loose-coupling/Cargo.toml [INFO] started frobbing onelson/loose-coupling [INFO] finished frobbing onelson/loose-coupling [INFO] frobbed toml for onelson/loose-coupling written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/onelson/loose-coupling/Cargo.toml [INFO] crate onelson/loose-coupling has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting onelson/loose-coupling against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/onelson/loose-coupling:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e5da0979e0677accfabce400897ae32e7b215ba3465734a85ff098c34aef3a33 [INFO] running `"docker" "start" "-a" "e5da0979e0677accfabce400897ae32e7b215ba3465734a85ff098c34aef3a33"` [INFO] [stderr] Compiling gcc v0.3.39 [INFO] [stderr] Checking atom v0.3.4 [INFO] [stderr] Checking mopa v0.2.2 [INFO] [stderr] Checking tuple_utils v0.2.0 [INFO] [stderr] Checking threadpool v1.3.2 [INFO] [stderr] Compiling serde_json v0.8.4 [INFO] [stderr] Compiling silverknife-fontconfig-sys v0.1.0 [INFO] [stderr] Checking x11-dl v2.11.0 [INFO] [stderr] Checking rusttype v0.2.1 [INFO] [stderr] Checking jpeg-decoder v0.1.8 [INFO] [stderr] Checking pulse v0.5.3 [INFO] [stderr] Checking enum_primitive v0.1.0 [INFO] [stderr] Compiling miniz-sys v0.1.7 [INFO] [stderr] Compiling backtrace-sys v0.1.5 [INFO] [stderr] Checking specs v0.7.0 [INFO] [stderr] Checking font-loader v0.1.0 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Compiling target_build_utils v0.1.2 [INFO] [stderr] Checking flate2 v0.2.14 [INFO] [stderr] Compiling libloading v0.3.1 [INFO] [stderr] Checking png v0.5.2 [INFO] [stderr] Checking image v0.10.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.5.11 [INFO] [stderr] Checking wayland-client v0.5.12 [INFO] [stderr] Checking wayland-window v0.2.3 [INFO] [stderr] Checking wayland-kbd v0.3.6 [INFO] [stderr] Checking glutin v0.6.2 [INFO] [stderr] Checking glium v0.15.0 [INFO] [stderr] Checking radiant-rs v0.1.1 [INFO] [stderr] Checking loose-coupling v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/main.rs:41:24 [INFO] [stderr] | [INFO] [stderr] 41 | utils::renderloop(|state| { [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/assets.rs:23:24 [INFO] [stderr] | [INFO] [stderr] 23 | fn load(&self, id: &u8) -> Sprite<'a> { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/assets.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | self.sprites.get(&id).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.sprites[&id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/main.rs:41:24 [INFO] [stderr] | [INFO] [stderr] 41 | utils::renderloop(|state| { [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/assets.rs:23:24 [INFO] [stderr] | [INFO] [stderr] 23 | fn load(&self, id: &u8) -> Sprite<'a> { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/assets.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | self.sprites.get(&id).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.sprites[&id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 46.97s [INFO] running `"docker" "inspect" "e5da0979e0677accfabce400897ae32e7b215ba3465734a85ff098c34aef3a33"` [INFO] running `"docker" "rm" "-f" "e5da0979e0677accfabce400897ae32e7b215ba3465734a85ff098c34aef3a33"` [INFO] [stdout] e5da0979e0677accfabce400897ae32e7b215ba3465734a85ff098c34aef3a33