[INFO] updating cached repository omid/gitversion [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/omid/gitversion [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/omid/gitversion" "work/ex/clippy-test-run/sources/stable/gh/omid/gitversion"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/omid/gitversion'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/omid/gitversion" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/omid/gitversion"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/omid/gitversion'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 770b80cbb507cfccb8340c39cef105a201c8805a [INFO] sha for GitHub repo omid/gitversion: 770b80cbb507cfccb8340c39cef105a201c8805a [INFO] validating manifest of omid/gitversion on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of omid/gitversion on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing omid/gitversion [INFO] finished frobbing omid/gitversion [INFO] frobbed toml for omid/gitversion written to work/ex/clippy-test-run/sources/stable/gh/omid/gitversion/Cargo.toml [INFO] started frobbing omid/gitversion [INFO] finished frobbing omid/gitversion [INFO] frobbed toml for omid/gitversion written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/omid/gitversion/Cargo.toml [INFO] crate omid/gitversion has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting omid/gitversion against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/omid/gitversion:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d5f1acad85cb7746239725bace397122d8452a6494df99af06ee778ae498b7cf [INFO] running `"docker" "start" "-a" "d5f1acad85cb7746239725bace397122d8452a6494df99af06ee778ae498b7cf"` [INFO] [stderr] Compiling libssh2-sys v0.2.11 [INFO] [stderr] Compiling curl-sys v0.4.15 [INFO] [stderr] Compiling libgit2-sys v0.7.10 [INFO] [stderr] Checking semver v0.9.0 [INFO] [stderr] Checking libz-sys v1.0.25 [INFO] [stderr] Checking regex v1.0.6 [INFO] [stderr] Checking git2 v0.7.5 [INFO] [stderr] Checking gitversion v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:43:3 [INFO] [stderr] | [INFO] [stderr] 43 | / let last_version; [INFO] [stderr] 44 | | [INFO] [stderr] 45 | | if tag_list_length == 0 { [INFO] [stderr] 46 | | last_version = "0.0.0"; [INFO] [stderr] 47 | | } else { [INFO] [stderr] 48 | | last_version = version_tags[tag_list_length - 1]; [INFO] [stderr] 49 | | } [INFO] [stderr] | |___^ help: it is more idiomatic to write: `let last_version = if tag_list_length == 0 { "0.0.0" } else { version_tags[tag_list_length - 1] };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:36:25 [INFO] [stderr] | [INFO] [stderr] 36 | version_tags.push(tag.unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 36 | version_tags.push(&(*tag.unwrap()).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 36 | version_tags.push(&str::clone(tag.unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:42:25 [INFO] [stderr] | [INFO] [stderr] 42 | let tag_list_length = version_tags.len().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `version_tags.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:43:3 [INFO] [stderr] | [INFO] [stderr] 43 | / let last_version; [INFO] [stderr] 44 | | [INFO] [stderr] 45 | | if tag_list_length == 0 { [INFO] [stderr] 46 | | last_version = "0.0.0"; [INFO] [stderr] 47 | | } else { [INFO] [stderr] 48 | | last_version = version_tags[tag_list_length - 1]; [INFO] [stderr] 49 | | } [INFO] [stderr] | |___^ help: it is more idiomatic to write: `let last_version = if tag_list_length == 0 { "0.0.0" } else { version_tags[tag_list_length - 1] };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: Could not compile `gitversion`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:36:25 [INFO] [stderr] | [INFO] [stderr] 36 | version_tags.push(tag.unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 36 | version_tags.push(&(*tag.unwrap()).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 36 | version_tags.push(&str::clone(tag.unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:42:25 [INFO] [stderr] | [INFO] [stderr] 42 | let tag_list_length = version_tags.len().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `version_tags.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `gitversion`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d5f1acad85cb7746239725bace397122d8452a6494df99af06ee778ae498b7cf"` [INFO] running `"docker" "rm" "-f" "d5f1acad85cb7746239725bace397122d8452a6494df99af06ee778ae498b7cf"` [INFO] [stdout] d5f1acad85cb7746239725bace397122d8452a6494df99af06ee778ae498b7cf