[INFO] updating cached repository olson-dan/risp
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/olson-dan/risp
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/olson-dan/risp" "work/ex/clippy-test-run/sources/stable/gh/olson-dan/risp"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/olson-dan/risp'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/olson-dan/risp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/olson-dan/risp"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/olson-dan/risp'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 5f0b94bed0522d9028e2c64a2e4df53fae4dcf70
[INFO] sha for GitHub repo olson-dan/risp: 5f0b94bed0522d9028e2c64a2e4df53fae4dcf70
[INFO] validating manifest of olson-dan/risp on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of olson-dan/risp on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing olson-dan/risp
[INFO] finished frobbing olson-dan/risp
[INFO] frobbed toml for olson-dan/risp written to work/ex/clippy-test-run/sources/stable/gh/olson-dan/risp/Cargo.toml
[INFO] started frobbing olson-dan/risp
[INFO] finished frobbing olson-dan/risp
[INFO] frobbed toml for olson-dan/risp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/olson-dan/risp/Cargo.toml
[INFO] crate olson-dan/risp has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting olson-dan/risp against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/olson-dan/risp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] dbfb8f84053479795e1b7a4728ef3e46e30751c157e62f1598eb7f8f2ad51869
[INFO] running `"docker" "start" "-a" "dbfb8f84053479795e1b7a4728ef3e46e30751c157e62f1598eb7f8f2ad51869"`
[INFO] [stderr]     Checking itertools v0.5.9
[INFO] [stderr]     Checking risp v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:90:13
[INFO] [stderr]    |
[INFO] [stderr] 90 |             variables: variables,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `variables`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:91:13
[INFO] [stderr]    |
[INFO] [stderr] 91 |             functions: functions,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `functions`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:90:13
[INFO] [stderr]    |
[INFO] [stderr] 90 |             variables: variables,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `variables`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:91:13
[INFO] [stderr]    |
[INFO] [stderr] 91 |             functions: functions,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `functions`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/main.rs:26:24
[INFO] [stderr]    |
[INFO] [stderr] 26 |                   } else {
[INFO] [stderr]    |  ________________________^
[INFO] [stderr] 27 | |                     if let Ok(f) = f32::from_str(s) {
[INFO] [stderr] 28 | |                         Ok(Value::Float(f))
[INFO] [stderr] 29 | |                     } else {
[INFO] [stderr] 30 | |                         Err(format!("Couldn't parse number from '{}'", s))
[INFO] [stderr] 31 | |                     }
[INFO] [stderr] 32 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 26 |                 } else if let Ok(f) = f32::from_str(s) {
[INFO] [stderr] 27 |     Ok(Value::Float(f))
[INFO] [stderr] 28 | } else {
[INFO] [stderr] 29 |     Err(format!("Couldn't parse number from '{}'", s))
[INFO] [stderr] 30 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:88:52
[INFO] [stderr]    |
[INFO] [stderr] 88 |         variables.insert("pi".into(), Value::Float(3.141592));
[INFO] [stderr]    |                                                    ^^^^^^^^ help: consider: `3.141_592`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/main.rs:26:24
[INFO] [stderr]    |
[INFO] [stderr] 26 |                   } else {
[INFO] [stderr]    |  ________________________^
[INFO] [stderr] 27 | |                     if let Ok(f) = f32::from_str(s) {
[INFO] [stderr] 28 | |                         Ok(Value::Float(f))
[INFO] [stderr] 29 | |                     } else {
[INFO] [stderr] 30 | |                         Err(format!("Couldn't parse number from '{}'", s))
[INFO] [stderr] 31 | |                     }
[INFO] [stderr] 32 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 26 |                 } else if let Ok(f) = f32::from_str(s) {
[INFO] [stderr] 27 |     Ok(Value::Float(f))
[INFO] [stderr] 28 | } else {
[INFO] [stderr] 29 |     Err(format!("Couldn't parse number from '{}'", s))
[INFO] [stderr] 30 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:88:52
[INFO] [stderr]    |
[INFO] [stderr] 88 |         variables.insert("pi".into(), Value::Float(3.141592));
[INFO] [stderr]    |                                                    ^^^^^^^^ help: consider: `3.141_592`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:40:9
[INFO] [stderr]    |
[INFO] [stderr] 40 | /         match self {
[INFO] [stderr] 41 | |             &Value::Float(x) => write!(f, "{}", x),
[INFO] [stderr] 42 | |             &Value::Int(x) => write!(f, "{}", x),
[INFO] [stderr] 43 | |             &Value::Bool(b) => if b { write!(f, "#t") } else { write!(f, "#f") },
[INFO] [stderr] 44 | |             &Value::List(ref x) => write!(f, "[{}]", x.iter().join(", ")),
[INFO] [stderr] 45 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 40 |         match *self {
[INFO] [stderr] 41 |             Value::Float(x) => write!(f, "{}", x),
[INFO] [stderr] 42 |             Value::Int(x) => write!(f, "{}", x),
[INFO] [stderr] 43 |             Value::Bool(b) => if b { write!(f, "#t") } else { write!(f, "#f") },
[INFO] [stderr] 44 |             Value::List(ref x) => write!(f, "[{}]", x.iter().join(", ")),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/main.rs:62:16
[INFO] [stderr]    |
[INFO] [stderr] 62 |     functions: HashMap<&'a str, Box<Fn(&[Value]) -> Result<Value, String>>>,
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/main.rs:68:28
[INFO] [stderr]    |
[INFO] [stderr] 68 |         let mut functions: HashMap<&'a str, Box<Fn(&[Value]) -> Result<Value, String>>> =
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:72:44
[INFO] [stderr]    |
[INFO] [stderr] 72 |             args.last().map(|x| x.clone()).ok_or(format!("begin function missing arguments"))
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("begin function missing arguments"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/main.rs:72:13
[INFO] [stderr]    |
[INFO] [stderr] 72 |             args.last().map(|x| x.clone()).ok_or(format!("begin function missing arguments"))
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `args.last().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:72:50
[INFO] [stderr]    |
[INFO] [stderr] 72 |             args.last().map(|x| x.clone()).ok_or(format!("begin function missing arguments"))
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"begin function missing arguments".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly
[INFO] [stderr]   --> src/main.rs:88:52
[INFO] [stderr]    |
[INFO] [stderr] 88 |         variables.insert("pi".into(), Value::Float(3.141592));
[INFO] [stderr]    |                                                    ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::approx_constant)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:98:31
[INFO] [stderr]    |
[INFO] [stderr] 98 |         .flat_map(|x| x.split("(").intersperse("("))
[INFO] [stderr]    |                               ^^^ help: try using a char instead: `'('`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:99:31
[INFO] [stderr]    |
[INFO] [stderr] 99 |         .flat_map(|x| x.split(")").intersperse(")"))
[INFO] [stderr]    |                               ^^^ help: try using a char instead: `')'`
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:40:9
[INFO] [stderr]    |
[INFO] [stderr] 40 | /         match self {
[INFO] [stderr] 41 | |             &Value::Float(x) => write!(f, "{}", x),
[INFO] [stderr] 42 | |             &Value::Int(x) => write!(f, "{}", x),
[INFO] [stderr] 43 | |             &Value::Bool(b) => if b { write!(f, "#t") } else { write!(f, "#f") },
[INFO] [stderr] 44 | |             &Value::List(ref x) => write!(f, "[{}]", x.iter().join(", ")),
[INFO] [stderr] 45 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:100:21
[INFO] [stderr]     |
[INFO] [stderr] 100 |         .filter(|x| x.len() > 0)
[INFO] [stderr]     |                     ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!x.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 40 |         match *self {
[INFO] [stderr] 41 |             Value::Float(x) => write!(f, "{}", x),
[INFO] [stderr] 42 |             Value::Int(x) => write!(f, "{}", x),
[INFO] [stderr] 43 |             Value::Bool(b) => if b { write!(f, "#t") } else { write!(f, "#f") },
[INFO] [stderr] 44 |             Value::List(ref x) => write!(f, "[{}]", x.iter().join(", ")),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/main.rs:62:16
[INFO] [stderr]    |
[INFO] [stderr] 62 |     functions: HashMap<&'a str, Box<Fn(&[Value]) -> Result<Value, String>>>,
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/main.rs:68:28
[INFO] [stderr]    |
[INFO] [stderr] 68 |         let mut functions: HashMap<&'a str, Box<Fn(&[Value]) -> Result<Value, String>>> =
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:129:22
[INFO] [stderr]     |
[INFO] [stderr] 129 |                     .ok_or(format!("expected name at token {}", index + 1))?;
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("expected name at token {}", index + 1))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:145:30
[INFO] [stderr]     |
[INFO] [stderr] 145 |                             .ok_or(format!("expected variable name at token {}", index))?;
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("expected variable name at token {}", index))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:72:44
[INFO] [stderr]    |
[INFO] [stderr] 72 |             args.last().map(|x| x.clone()).ok_or(format!("begin function missing arguments"))
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("begin function missing arguments"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/main.rs:72:13
[INFO] [stderr]    |
[INFO] [stderr] 72 |             args.last().map(|x| x.clone()).ok_or(format!("begin function missing arguments"))
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `args.last().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:72:50
[INFO] [stderr]    |
[INFO] [stderr] 72 |             args.last().map(|x| x.clone()).ok_or(format!("begin function missing arguments"))
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"begin function missing arguments".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly
[INFO] [stderr]   --> src/main.rs:88:52
[INFO] [stderr]    |
[INFO] [stderr] 88 |         variables.insert("pi".into(), Value::Float(3.141592));
[INFO] [stderr]    |                                                    ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::approx_constant)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:98:31
[INFO] [stderr]    |
[INFO] [stderr] 98 |         .flat_map(|x| x.split("(").intersperse("("))
[INFO] [stderr]    |                               ^^^ help: try using a char instead: `'('`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:99:31
[INFO] [stderr]    |
[INFO] [stderr] 99 |         .flat_map(|x| x.split(")").intersperse(")"))
[INFO] [stderr]    |                               ^^^ help: try using a char instead: `')'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:100:21
[INFO] [stderr]     |
[INFO] [stderr] 100 |         .filter(|x| x.len() > 0)
[INFO] [stderr]     |                     ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!x.is_empty()`
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:184:9
[INFO] [stderr]     |
[INFO] [stderr] 184 | /         match x {
[INFO] [stderr] 185 | |             &Ast::Conditional(ref test, ref conseq, ref alt) => {
[INFO] [stderr] 186 | |                 let result = eval(&test, env)?;
[INFO] [stderr] 187 | |                 if match result {
[INFO] [stderr] ...   |
[INFO] [stderr] 218 | |             }
[INFO] [stderr] 219 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 184 |         match *x {
[INFO] [stderr] 185 |             Ast::Conditional(ref test, ref conseq, ref alt) => {
[INFO] [stderr] 186 |                 let result = eval(&test, env)?;
[INFO] [stderr] 187 |                 if match result {
[INFO] [stderr] 188 |                     Value::Bool(b) => b,
[INFO] [stderr] 189 |                     _ => return Err(format!("conditional is not a bool type")),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:189:37
[INFO] [stderr]     |
[INFO] [stderr] 189 |                     _ => return Err(format!("conditional is not a bool type")),
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"conditional is not a bool type".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:129:22
[INFO] [stderr]     |
[INFO] [stderr] 129 |                     .ok_or(format!("expected name at token {}", index + 1))?;
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("expected name at token {}", index + 1))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:209:22
[INFO] [stderr]     |
[INFO] [stderr] 209 |                     .ok_or(format!("Unknown procedure name '{}'", name))?;
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Unknown procedure name '{}'", name))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:145:30
[INFO] [stderr]     |
[INFO] [stderr] 145 |                             .ok_or(format!("expected variable name at token {}", index))?;
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("expected variable name at token {}", index))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:216:22
[INFO] [stderr]     |
[INFO] [stderr] 216 |                     .ok_or(format!("Unknown value for variable '{}'", name))?
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Unknown value for variable '{}'", name))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:184:9
[INFO] [stderr]     |
[INFO] [stderr] 184 | /         match x {
[INFO] [stderr] 185 | |             &Ast::Conditional(ref test, ref conseq, ref alt) => {
[INFO] [stderr] 186 | |                 let result = eval(&test, env)?;
[INFO] [stderr] 187 | |                 if match result {
[INFO] [stderr] ...   |
[INFO] [stderr] 218 | |             }
[INFO] [stderr] 219 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 184 |         match *x {
[INFO] [stderr] 185 |             Ast::Conditional(ref test, ref conseq, ref alt) => {
[INFO] [stderr] 186 |                 let result = eval(&test, env)?;
[INFO] [stderr] 187 |                 if match result {
[INFO] [stderr] 188 |                     Value::Bool(b) => b,
[INFO] [stderr] 189 |                     _ => return Err(format!("conditional is not a bool type")),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:189:37
[INFO] [stderr]     |
[INFO] [stderr] 189 |                     _ => return Err(format!("conditional is not a bool type")),
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"conditional is not a bool type".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:209:22
[INFO] [stderr]     |
[INFO] [stderr] 209 |                     .ok_or(format!("Unknown procedure name '{}'", name))?;
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Unknown procedure name '{}'", name))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:216:22
[INFO] [stderr]     |
[INFO] [stderr] 216 |                     .ok_or(format!("Unknown value for variable '{}'", name))?
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Unknown value for variable '{}'", name))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `risp`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: Could not compile `risp`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "dbfb8f84053479795e1b7a4728ef3e46e30751c157e62f1598eb7f8f2ad51869"`
[INFO] running `"docker" "rm" "-f" "dbfb8f84053479795e1b7a4728ef3e46e30751c157e62f1598eb7f8f2ad51869"`
[INFO] [stdout] dbfb8f84053479795e1b7a4728ef3e46e30751c157e62f1598eb7f8f2ad51869