[INFO] updating cached repository oll3/devsync
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/oll3/devsync
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/oll3/devsync" "work/ex/clippy-test-run/sources/stable/gh/oll3/devsync"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/oll3/devsync'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/oll3/devsync" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/oll3/devsync"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/oll3/devsync'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 329f83cb0092e083353e57e9e539f44c578c5f36
[INFO] sha for GitHub repo oll3/devsync: 329f83cb0092e083353e57e9e539f44c578c5f36
[INFO] validating manifest of oll3/devsync on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of oll3/devsync on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing oll3/devsync
[INFO] finished frobbing oll3/devsync
[INFO] frobbed toml for oll3/devsync written to work/ex/clippy-test-run/sources/stable/gh/oll3/devsync/Cargo.toml
[INFO] started frobbing oll3/devsync
[INFO] finished frobbing oll3/devsync
[INFO] frobbed toml for oll3/devsync written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/oll3/devsync/Cargo.toml
[INFO] crate oll3/devsync has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting oll3/devsync against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/oll3/devsync:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 6389f44c9b92eafe1e3dd281b59afc7027c9e0bb13cb41054fed15a33d089f92
[INFO] running `"docker" "start" "-a" "6389f44c9b92eafe1e3dd281b59afc7027c9e0bb13cb41054fed15a33d089f92"`
[INFO] [stderr]     Checking devsync v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:97:9
[INFO] [stderr]    |
[INFO] [stderr] 97 |         src: src,
[INFO] [stderr]    |         ^^^^^^^^ help: replace it with: `src`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:98:9
[INFO] [stderr]    |
[INFO] [stderr] 98 |         dest: dest,
[INFO] [stderr]    |         ^^^^^^^^^^ help: replace it with: `dest`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:99:9
[INFO] [stderr]    |
[INFO] [stderr] 99 |         dry_run: dry_run,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: replace it with: `dry_run`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:100:9
[INFO] [stderr]     |
[INFO] [stderr] 100 |         block_size: block_size,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_size`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:97:9
[INFO] [stderr]    |
[INFO] [stderr] 97 |         src: src,
[INFO] [stderr]    |         ^^^^^^^^ help: replace it with: `src`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:98:9
[INFO] [stderr]    |
[INFO] [stderr] 98 |         dest: dest,
[INFO] [stderr]    |         ^^^^^^^^^^ help: replace it with: `dest`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:99:9
[INFO] [stderr]    |
[INFO] [stderr] 99 |         dry_run: dry_run,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: replace it with: `dry_run`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:100:9
[INFO] [stderr]     |
[INFO] [stderr] 100 |         block_size: block_size,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_size`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:130:5
[INFO] [stderr]     |
[INFO] [stderr] 130 |     return read_size;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `read_size`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:130:5
[INFO] [stderr]     |
[INFO] [stderr] 130 |     return read_size;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `read_size`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:36:8
[INFO] [stderr]    |
[INFO] [stderr] 36 |     if size_unit.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `size_unit.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/main.rs:105:22
[INFO] [stderr]     |
[INFO] [stderr] 105 | fn size_to_str(size: &usize) -> String {
[INFO] [stderr]     |                      ^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/main.rs:229:10
[INFO] [stderr]     |
[INFO] [stderr] 229 |         .expect(&format!("failed to open file ({})", config.dest));
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to open file ({})", config.dest))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/main.rs:227:16
[INFO] [stderr]     |
[INFO] [stderr] 227 |         .write(config.dry_run == false)
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!config.dry_run`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/main.rs:233:45
[INFO] [stderr]     |
[INFO] [stderr] 233 |         let mut src_file = File::open(&val).expect(&format!("failed to open file ({})", val));
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to open file ({})", val))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:36:8
[INFO] [stderr]    |
[INFO] [stderr] 36 |     if size_unit.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `size_unit.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/main.rs:105:22
[INFO] [stderr]     |
[INFO] [stderr] 105 | fn size_to_str(size: &usize) -> String {
[INFO] [stderr]     |                      ^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/main.rs:229:10
[INFO] [stderr]     |
[INFO] [stderr] 229 |         .expect(&format!("failed to open file ({})", config.dest));
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to open file ({})", config.dest))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/main.rs:227:16
[INFO] [stderr]     |
[INFO] [stderr] 227 |         .write(config.dry_run == false)
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!config.dry_run`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/main.rs:233:45
[INFO] [stderr]     |
[INFO] [stderr] 233 |         let mut src_file = File::open(&val).expect(&format!("failed to open file ({})", val));
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to open file ({})", val))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.07s
[INFO] running `"docker" "inspect" "6389f44c9b92eafe1e3dd281b59afc7027c9e0bb13cb41054fed15a33d089f92"`
[INFO] running `"docker" "rm" "-f" "6389f44c9b92eafe1e3dd281b59afc7027c9e0bb13cb41054fed15a33d089f92"`
[INFO] [stdout] 6389f44c9b92eafe1e3dd281b59afc7027c9e0bb13cb41054fed15a33d089f92