[INFO] updating cached repository oliveroneill/playlist-from-csv [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/oliveroneill/playlist-from-csv [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/oliveroneill/playlist-from-csv" "work/ex/clippy-test-run/sources/stable/gh/oliveroneill/playlist-from-csv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/oliveroneill/playlist-from-csv'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/oliveroneill/playlist-from-csv" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/oliveroneill/playlist-from-csv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/oliveroneill/playlist-from-csv'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 94b47e7a4358ac78f3ed230f4a5031cb6bc5636d [INFO] sha for GitHub repo oliveroneill/playlist-from-csv: 94b47e7a4358ac78f3ed230f4a5031cb6bc5636d [INFO] validating manifest of oliveroneill/playlist-from-csv on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of oliveroneill/playlist-from-csv on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing oliveroneill/playlist-from-csv [INFO] finished frobbing oliveroneill/playlist-from-csv [INFO] frobbed toml for oliveroneill/playlist-from-csv written to work/ex/clippy-test-run/sources/stable/gh/oliveroneill/playlist-from-csv/Cargo.toml [INFO] started frobbing oliveroneill/playlist-from-csv [INFO] finished frobbing oliveroneill/playlist-from-csv [INFO] frobbed toml for oliveroneill/playlist-from-csv written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/oliveroneill/playlist-from-csv/Cargo.toml [INFO] crate oliveroneill/playlist-from-csv has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting oliveroneill/playlist-from-csv against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/oliveroneill/playlist-from-csv:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 12a9f9c59194f93a0540c8c9d1d26e8fe70259e82cbf08a3e1df0f99ef0127f8 [INFO] running `"docker" "start" "-a" "12a9f9c59194f93a0540c8c9d1d26e8fe70259e82cbf08a3e1df0f99ef0127f8"` [INFO] [stderr] Checking webbrowser v0.2.2 [INFO] [stderr] Checking random v0.12.2 [INFO] [stderr] Checking want v0.0.4 [INFO] [stderr] Checking mio v0.6.15 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking tokio-io v0.1.7 [INFO] [stderr] Compiling derive_builder_core v0.2.0 [INFO] [stderr] Compiling derive-error-chain v0.10.1 [INFO] [stderr] Checking csv v1.0.0 [INFO] [stderr] Checking tokio-threadpool v0.1.5 [INFO] [stderr] Compiling phf_shared v0.7.22 [INFO] [stderr] Checking libflate v0.1.16 [INFO] [stderr] Checking env_logger v0.5.10 [INFO] [stderr] Compiling serde_derive v1.0.70 [INFO] [stderr] Checking chrono v0.4.4 [INFO] [stderr] Compiling phf_generator v0.7.22 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Compiling derive_builder v0.5.1 [INFO] [stderr] Checking tokio-reactor v0.1.2 [INFO] [stderr] Checking phf v0.7.22 [INFO] [stderr] Checking tokio-fs v0.1.1 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking url v1.7.1 [INFO] [stderr] Compiling phf_codegen v0.7.22 [INFO] [stderr] Checking dotenv v0.10.1 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio-udp v0.1.1 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.5 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking serde_urlencoded v0.5.2 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking reqwest v0.8.6 [INFO] [stderr] Checking rspotify v0.2.3 [INFO] [stderr] Checking playlist-from-csv v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/csv_to_playlist.rs:163:17 [INFO] [stderr] | [INFO] [stderr] 163 | add_tracks_to_playlist_returns: add_tracks_to_playlist_returns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `add_tracks_to_playlist_returns` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/csv_to_playlist.rs:164:17 [INFO] [stderr] | [INFO] [stderr] 164 | get_track_ids_in_playlist_returns: get_track_ids_in_playlist_returns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `get_track_ids_in_playlist_returns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/playlist.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | get_playlist_id_returns: get_playlist_id_returns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `get_playlist_id_returns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/playlist.rs:119:17 [INFO] [stderr] | [INFO] [stderr] 119 | create_playlist_returns: create_playlist_returns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `create_playlist_returns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spotify.rs:54:31 [INFO] [stderr] | [INFO] [stderr] 54 | Ok(SpotifyAPI{spotify: spotify, username: username.to_owned()}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `spotify` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/csv_to_playlist.rs:163:17 [INFO] [stderr] | [INFO] [stderr] 163 | add_tracks_to_playlist_returns: add_tracks_to_playlist_returns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `add_tracks_to_playlist_returns` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/csv_to_playlist.rs:164:17 [INFO] [stderr] | [INFO] [stderr] 164 | get_track_ids_in_playlist_returns: get_track_ids_in_playlist_returns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `get_track_ids_in_playlist_returns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/playlist.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | get_playlist_id_returns: get_playlist_id_returns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `get_playlist_id_returns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/playlist.rs:119:17 [INFO] [stderr] | [INFO] [stderr] 119 | create_playlist_returns: create_playlist_returns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `create_playlist_returns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spotify.rs:54:31 [INFO] [stderr] | [INFO] [stderr] 54 | Ok(SpotifyAPI{spotify: spotify, username: username.to_owned()}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `spotify` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/csv_to_playlist.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | self.add_tracks_to_playlist_returns.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.add_tracks_to_playlist_returns` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 05s [INFO] running `"docker" "inspect" "12a9f9c59194f93a0540c8c9d1d26e8fe70259e82cbf08a3e1df0f99ef0127f8"` [INFO] running `"docker" "rm" "-f" "12a9f9c59194f93a0540c8c9d1d26e8fe70259e82cbf08a3e1df0f99ef0127f8"` [INFO] [stdout] 12a9f9c59194f93a0540c8c9d1d26e8fe70259e82cbf08a3e1df0f99ef0127f8