[INFO] updating cached repository oliverlars/rust_ray [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/oliverlars/rust_ray [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/oliverlars/rust_ray" "work/ex/clippy-test-run/sources/stable/gh/oliverlars/rust_ray"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/oliverlars/rust_ray'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/oliverlars/rust_ray" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/oliverlars/rust_ray"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/oliverlars/rust_ray'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f8dd0640d0f18460ccfd31f23f7732e30c5784d1 [INFO] sha for GitHub repo oliverlars/rust_ray: f8dd0640d0f18460ccfd31f23f7732e30c5784d1 [INFO] validating manifest of oliverlars/rust_ray on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of oliverlars/rust_ray on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing oliverlars/rust_ray [INFO] finished frobbing oliverlars/rust_ray [INFO] frobbed toml for oliverlars/rust_ray written to work/ex/clippy-test-run/sources/stable/gh/oliverlars/rust_ray/Cargo.toml [INFO] started frobbing oliverlars/rust_ray [INFO] finished frobbing oliverlars/rust_ray [INFO] frobbed toml for oliverlars/rust_ray written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/oliverlars/rust_ray/Cargo.toml [INFO] crate oliverlars/rust_ray has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting oliverlars/rust_ray against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/oliverlars/rust_ray:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9c574d821ad9eb1197570a9eed600cf184983ab4788c242f6c86393a20cb079e [INFO] running `"docker" "start" "-a" "9c574d821ad9eb1197570a9eed600cf184983ab4788c242f6c86393a20cb079e"` [INFO] [stderr] Compiling rayon-core v1.0.2 [INFO] [stderr] Checking num-bigint v0.1.37 [INFO] [stderr] Checking rayon v0.7.1 [INFO] [stderr] Checking num-rational v0.1.36 [INFO] [stderr] Checking num v0.1.37 [INFO] [stderr] Checking jpeg-decoder v0.1.12 [INFO] [stderr] Checking image v0.13.0 [INFO] [stderr] Checking rustray v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:22:22 [INFO] [stderr] | [INFO] [stderr] 22 | return Ray { origin: origin, direction: lower_left_corner + (horizontal * (s as f64)) + vertical * (t as f64) - origin } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:22:22 [INFO] [stderr] | [INFO] [stderr] 22 | return Ray { origin: origin, direction: lower_left_corner + (horizontal * (s as f64)) + vertical * (t as f64) - origin } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/camera.rs:4:19 [INFO] [stderr] | [INFO] [stderr] 4 | const M_PI: f64 = 3.141592653589793; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `3.141_592_653_589_793` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/camera.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | return Ray { origin: origin, direction: lower_left_corner + (horizontal * (s as f64)) + vertical * (t as f64) - origin } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ray { origin: origin, direction: lower_left_corner + (horizontal * (s as f64)) + vertical * (t as f64) - origin }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `ray::Ray` [INFO] [stderr] --> src/sphere.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use ray::Ray; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ray.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | return self.origin + self.direction*(*t as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.origin + self.direction*(*t as f64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::option` [INFO] [stderr] --> src/trace.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::option; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trace.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return 1e10 [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `1e10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trace.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | return sphere_min; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sphere_min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trace.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return ks * f64::max((f64::powf(m, obj.specular as f64)), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ks * f64::max((f64::powf(m, obj.specular as f64)), 0.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/trace.rs:48:26 [INFO] [stderr] | [INFO] [stderr] 48 | return ks * f64::max((f64::powf(m, obj.specular as f64)), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trace.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | return kd * f64::max(Vec3::dot(&normal, &l), 0.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `kd * f64::max(Vec3::dot(&normal, &l), 0.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trace.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | return *ray_dir - normal* 2.0*Vec3::dot(ray_dir, &normal); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*ray_dir - normal* 2.0*Vec3::dot(ray_dir, &normal)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trace.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | return colour; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `colour` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections` [INFO] [stderr] --> src/main.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use std::collections; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `num::iter::range` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use num::iter::range; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `scene::Scene` [INFO] [stderr] --> src/main.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use scene::Scene; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/main.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | let u = (x as f32 /width as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/main.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | let v = ((height - y) as f32 / height as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused variable: `diffuse` [INFO] [stderr] --> src/trace.rs:44:10 [INFO] [stderr] | [INFO] [stderr] 44 | fn phong(diffuse: &Vec3, N: &Vec3, v: &Vec3, obj: &Sphere, l: &Vec3) -> Vec3 { [INFO] [stderr] | ^^^^^^^ help: consider using `_diffuse` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ambient` [INFO] [stderr] --> src/trace.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | let ambient = Vec3{x:0.2, y:0.2, z:0.2}; [INFO] [stderr] | ^^^^^^^ help: consider using `_ambient` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r` [INFO] [stderr] --> src/trace.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | let r = Vec3::unit(&((normal-v) * 2.0* Vec3::dot(&v, &normal))); [INFO] [stderr] | ^ help: consider using `_r` instead [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/camera.rs:4:19 [INFO] [stderr] | [INFO] [stderr] 4 | const M_PI: f64 = 3.141592653589793; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `3.141_592_653_589_793` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/camera.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | return Ray { origin: origin, direction: lower_left_corner + (horizontal * (s as f64)) + vertical * (t as f64) - origin } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ray { origin: origin, direction: lower_left_corner + (horizontal * (s as f64)) + vertical * (t as f64) - origin }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `ray::Ray` [INFO] [stderr] --> src/sphere.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use ray::Ray; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ray.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | return self.origin + self.direction*(*t as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.origin + self.direction*(*t as f64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::option` [INFO] [stderr] --> src/trace.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::option; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trace.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return 1e10 [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `1e10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trace.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | return sphere_min; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sphere_min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trace.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return ks * f64::max((f64::powf(m, obj.specular as f64)), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ks * f64::max((f64::powf(m, obj.specular as f64)), 0.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/trace.rs:48:26 [INFO] [stderr] | [INFO] [stderr] 48 | return ks * f64::max((f64::powf(m, obj.specular as f64)), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trace.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | return kd * f64::max(Vec3::dot(&normal, &l), 0.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `kd * f64::max(Vec3::dot(&normal, &l), 0.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trace.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | return *ray_dir - normal* 2.0*Vec3::dot(ray_dir, &normal); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*ray_dir - normal* 2.0*Vec3::dot(ray_dir, &normal)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trace.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | return colour; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `colour` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections` [INFO] [stderr] --> src/main.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use std::collections; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `num::iter::range` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use num::iter::range; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `scene::Scene` [INFO] [stderr] --> src/main.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use scene::Scene; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/main.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | let u = (x as f32 /width as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/main.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | let v = ((height - y) as f32 / height as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: method is never used: `norm` [INFO] [stderr] --> src/vector.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn norm(&self) -> f64{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `cross` [INFO] [stderr] --> src/vector.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn cross(&self, other : &Vec3) -> Vec3{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `FARAWAY` [INFO] [stderr] --> src/sphere.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | const FARAWAY: f64 = 1e10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/camera.rs:4:19 [INFO] [stderr] | [INFO] [stderr] 4 | const M_PI: f64 = 3.141592653589793; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera.rs:14:22 [INFO] [stderr] | [INFO] [stderr] 14 | let theta = (self.vfov as f64 / 180.0) * M_PI; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(self.vfov)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera.rs:17:40 [INFO] [stderr] | [INFO] [stderr] 17 | let lower_left_corner = Vec3{x:-half_width as f64, y:-half_height as f64, z:-1.0 as f64}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(-half_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera.rs:17:62 [INFO] [stderr] | [INFO] [stderr] 17 | let lower_left_corner = Vec3{x:-half_width as f64, y:-half_height as f64, z:-1.0 as f64}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(-half_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera.rs:18:37 [INFO] [stderr] | [INFO] [stderr] 18 | let horizontal = Vec3{x:2.0*half_width as f64, y:0.0, z:0.0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(half_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera.rs:19:42 [INFO] [stderr] | [INFO] [stderr] 19 | let vertical = Vec3{x:0.0, y:2.0*half_height as f64, z:0.0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(half_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera.rs:22:83 [INFO] [stderr] | [INFO] [stderr] 22 | return Ray { origin: origin, direction: lower_left_corner + (horizontal * (s as f64)) + vertical * (t as f64) - origin } [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera.rs:22:108 [INFO] [stderr] | [INFO] [stderr] 22 | return Ray { origin: origin, direction: lower_left_corner + (horizontal * (s as f64)) + vertical * (t as f64) - origin } [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(t)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ray.rs:11:41 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn point_at_parameter(self, t : &f64) -> vector::Vec3{ [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: variable `N` should have a snake case name such as `n` [INFO] [stderr] --> src/trace.rs:44:26 [INFO] [stderr] | [INFO] [stderr] 44 | fn phong(diffuse: &Vec3, N: &Vec3, v: &Vec3, obj: &Sphere, l: &Vec3) -> Vec3 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/trace.rs:48:40 [INFO] [stderr] | [INFO] [stderr] 48 | return ks * f64::max((f64::powf(m, obj.specular as f64)), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(obj.specular)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused variable: `diffuse` [INFO] [stderr] --> src/trace.rs:44:10 [INFO] [stderr] | [INFO] [stderr] 44 | fn phong(diffuse: &Vec3, N: &Vec3, v: &Vec3, obj: &Sphere, l: &Vec3) -> Vec3 { [INFO] [stderr] | ^^^^^^^ help: consider using `_diffuse` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ambient` [INFO] [stderr] --> src/trace.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | let ambient = Vec3{x:0.2, y:0.2, z:0.2}; [INFO] [stderr] | ^^^^^^^ help: consider using `_ambient` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r` [INFO] [stderr] --> src/trace.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | let r = Vec3::unit(&((normal-v) * 2.0* Vec3::dot(&v, &normal))); [INFO] [stderr] | ^ help: consider using `_r` instead [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | let ref mut fout = File::create(&Path::new("out.png")).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^------------------------------------------------ help: try: `let fout = &mut File::create(&Path::new("out.png")).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/main.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | let _ = image.save(fout, image::PNG).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: method is never used: `norm` [INFO] [stderr] --> src/vector.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn norm(&self) -> f64{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `cross` [INFO] [stderr] --> src/vector.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn cross(&self, other : &Vec3) -> Vec3{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `FARAWAY` [INFO] [stderr] --> src/sphere.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | const FARAWAY: f64 = 1e10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: Could not compile `rustray`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/camera.rs:4:19 [INFO] [stderr] | [INFO] [stderr] 4 | const M_PI: f64 = 3.141592653589793; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera.rs:14:22 [INFO] [stderr] | [INFO] [stderr] 14 | let theta = (self.vfov as f64 / 180.0) * M_PI; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(self.vfov)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera.rs:17:40 [INFO] [stderr] | [INFO] [stderr] 17 | let lower_left_corner = Vec3{x:-half_width as f64, y:-half_height as f64, z:-1.0 as f64}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(-half_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera.rs:17:62 [INFO] [stderr] | [INFO] [stderr] 17 | let lower_left_corner = Vec3{x:-half_width as f64, y:-half_height as f64, z:-1.0 as f64}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(-half_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera.rs:18:37 [INFO] [stderr] | [INFO] [stderr] 18 | let horizontal = Vec3{x:2.0*half_width as f64, y:0.0, z:0.0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(half_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera.rs:19:42 [INFO] [stderr] | [INFO] [stderr] 19 | let vertical = Vec3{x:0.0, y:2.0*half_height as f64, z:0.0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(half_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera.rs:22:83 [INFO] [stderr] | [INFO] [stderr] 22 | return Ray { origin: origin, direction: lower_left_corner + (horizontal * (s as f64)) + vertical * (t as f64) - origin } [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/camera.rs:22:108 [INFO] [stderr] | [INFO] [stderr] 22 | return Ray { origin: origin, direction: lower_left_corner + (horizontal * (s as f64)) + vertical * (t as f64) - origin } [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(t)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ray.rs:11:41 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn point_at_parameter(self, t : &f64) -> vector::Vec3{ [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: variable `N` should have a snake case name such as `n` [INFO] [stderr] --> src/trace.rs:44:26 [INFO] [stderr] | [INFO] [stderr] 44 | fn phong(diffuse: &Vec3, N: &Vec3, v: &Vec3, obj: &Sphere, l: &Vec3) -> Vec3 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/trace.rs:48:40 [INFO] [stderr] | [INFO] [stderr] 48 | return ks * f64::max((f64::powf(m, obj.specular as f64)), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(obj.specular)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | let ref mut fout = File::create(&Path::new("out.png")).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^------------------------------------------------ help: try: `let fout = &mut File::create(&Path::new("out.png")).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/main.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | let _ = image.save(fout, image::PNG).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rustray`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9c574d821ad9eb1197570a9eed600cf184983ab4788c242f6c86393a20cb079e"` [INFO] running `"docker" "rm" "-f" "9c574d821ad9eb1197570a9eed600cf184983ab4788c242f6c86393a20cb079e"` [INFO] [stdout] 9c574d821ad9eb1197570a9eed600cf184983ab4788c242f6c86393a20cb079e