[INFO] updating cached repository ojensen5115/pastebin-actix [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ojensen5115/pastebin-actix [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ojensen5115/pastebin-actix" "work/ex/clippy-test-run/sources/stable/gh/ojensen5115/pastebin-actix"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ojensen5115/pastebin-actix'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ojensen5115/pastebin-actix" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ojensen5115/pastebin-actix"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ojensen5115/pastebin-actix'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 139b8cb64b73b3147d21566f009a81aabdb5f922 [INFO] sha for GitHub repo ojensen5115/pastebin-actix: 139b8cb64b73b3147d21566f009a81aabdb5f922 [INFO] validating manifest of ojensen5115/pastebin-actix on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ojensen5115/pastebin-actix on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ojensen5115/pastebin-actix [INFO] finished frobbing ojensen5115/pastebin-actix [INFO] frobbed toml for ojensen5115/pastebin-actix written to work/ex/clippy-test-run/sources/stable/gh/ojensen5115/pastebin-actix/Cargo.toml [INFO] started frobbing ojensen5115/pastebin-actix [INFO] finished frobbing ojensen5115/pastebin-actix [INFO] frobbed toml for ojensen5115/pastebin-actix written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ojensen5115/pastebin-actix/Cargo.toml [INFO] crate ojensen5115/pastebin-actix has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ojensen5115/pastebin-actix against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ojensen5115/pastebin-actix:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0a9865c2f2f3ded58afc042af383fea67529c39e691059232cb296e61a3d0730 [INFO] running `"docker" "start" "-a" "0a9865c2f2f3ded58afc042af383fea67529c39e691059232cb296e61a3d0730"` [INFO] [stderr] Compiling serde v1.0.70 [INFO] [stderr] Compiling dtoa v0.4.3 [INFO] [stderr] Compiling itoa v0.4.2 [INFO] [stderr] Checking smallvec v0.6.2 [INFO] [stderr] Compiling plist v0.2.4 [INFO] [stderr] Checking same-file v0.1.3 [INFO] [stderr] Compiling cmake v0.1.31 [INFO] [stderr] Compiling crossbeam-utils v0.2.2 [INFO] [stderr] Compiling actix_derive v0.2.0 [INFO] [stderr] Compiling actix-web v0.6.14 [INFO] [stderr] Compiling memchr v1.0.2 [INFO] [stderr] Checking base64 v0.8.0 [INFO] [stderr] Checking walkdir v1.0.7 [INFO] [stderr] Compiling tempdir v0.3.7 [INFO] [stderr] Compiling rand v0.3.22 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Compiling crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling backtrace-sys v0.1.23 [INFO] [stderr] Checking url v1.7.1 [INFO] [stderr] Compiling onig_sys v65.0.1 [INFO] [stderr] Compiling backtrace v0.3.9 [INFO] [stderr] Checking tokio-threadpool v0.1.5 [INFO] [stderr] Checking h2 v0.1.10 [INFO] [stderr] Compiling phf_shared v0.7.22 [INFO] [stderr] Compiling nom v3.2.1 [INFO] [stderr] Checking chrono v0.4.4 [INFO] [stderr] Checking env_logger v0.5.10 [INFO] [stderr] Checking parking_lot v0.5.5 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Compiling crossbeam-deque v0.2.0 [INFO] [stderr] Compiling phf_generator v0.7.22 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking phf v0.7.22 [INFO] [stderr] Checking tokio-fs v0.1.1 [INFO] [stderr] Checking crossbeam-channel v0.1.3 [INFO] [stderr] Checking askama_shared v0.6.2 [INFO] [stderr] Compiling rayon-core v1.4.0 [INFO] [stderr] Compiling phf_codegen v0.7.22 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.5 [INFO] [stderr] Compiling askama_derive v0.6.4 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Compiling rayon v0.8.2 [INFO] [stderr] Compiling serde_json v1.0.22 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking trust-dns-proto v0.3.3 [INFO] [stderr] Checking tokio-signal v0.1.5 [INFO] [stderr] Checking onig v1.6.1 [INFO] [stderr] Compiling ring v0.12.1 [INFO] [stderr] Checking serde_urlencoded v0.5.2 [INFO] [stderr] Checking bincode v0.8.0 [INFO] [stderr] Compiling cargo_metadata v0.5.8 [INFO] [stderr] Compiling askama v0.6.4 [INFO] [stderr] Checking syntect v1.8.1 [INFO] [stderr] Checking trust-dns-resolver v0.8.2 [INFO] [stderr] Compiling pastebin-actix v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Compiling skeptic v0.13.3 [INFO] [stderr] Checking cookie v0.10.1 [INFO] [stderr] Compiling actix v0.5.8 [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:2:45 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:2:45 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:2:45 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:2:45 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | #[macro_use] extern crate askama; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:43:16 [INFO] [stderr] | [INFO] [stderr] 43 | const BASE62: &'static [u8] = b"0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | const UPLOADS_DIR: &'static str = "uploads"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | #[macro_use] extern crate askama; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:43:16 [INFO] [stderr] | [INFO] [stderr] 43 | const BASE62: &'static [u8] = b"0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | const UPLOADS_DIR: &'static str = "uploads"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:238:16 [INFO] [stderr] | [INFO] [stderr] 238 | Ok(HttpResponse::Ok().body(format!( [INFO] [stderr] | ________________^ [INFO] [stderr] 239 | | "View URL: {url}\nEdit URL: {url}/{key}\n\nThis paste will be deleted in {days} days.\n", [INFO] [stderr] 240 | | url = url, key = gen_key(&id), days = PASTE_DAYS)).into()) [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 238 | Ok(HttpResponse::Ok().body(format!( [INFO] [stderr] 239 | "View URL: {url}\nEdit URL: {url}/{key}\n\nThis paste will be deleted in {days} days.\n", [INFO] [stderr] 240 | url = url, key = gen_key(&id), days = PASTE_DAYS))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:259:24 [INFO] [stderr] | [INFO] [stderr] 259 | return Ok(HttpResponse::Unauthorized().content_type("text/plain; charset=utf-8").body("Unauthorized: Invalid key\n")).into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Ok(HttpResponse::Unauthorized().content_type("text/plain; charset=utf-8").body("Unauthorized: Invalid key\n"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:266:16 [INFO] [stderr] | [INFO] [stderr] 266 | Ok(HttpResponse::Ok().body(format!( [INFO] [stderr] | ________________^ [INFO] [stderr] 267 | | "View URL: {url}\nEdit URL: {url}/{key}\n\nThis paste will be deleted in {days} days.\n", [INFO] [stderr] 268 | | url = url, key = gen_key(&id), days = PASTE_DAYS)).into()) [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 266 | Ok(HttpResponse::Ok().body(format!( [INFO] [stderr] 267 | "View URL: {url}\nEdit URL: {url}/{key}\n\nThis paste will be deleted in {days} days.\n", [INFO] [stderr] 268 | url = url, key = gen_key(&id), days = PASTE_DAYS))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:238:16 [INFO] [stderr] | [INFO] [stderr] 238 | Ok(HttpResponse::Ok().body(format!( [INFO] [stderr] | ________________^ [INFO] [stderr] 239 | | "View URL: {url}\nEdit URL: {url}/{key}\n\nThis paste will be deleted in {days} days.\n", [INFO] [stderr] 240 | | url = url, key = gen_key(&id), days = PASTE_DAYS)).into()) [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 238 | Ok(HttpResponse::Ok().body(format!( [INFO] [stderr] 239 | "View URL: {url}\nEdit URL: {url}/{key}\n\nThis paste will be deleted in {days} days.\n", [INFO] [stderr] 240 | url = url, key = gen_key(&id), days = PASTE_DAYS))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:259:24 [INFO] [stderr] | [INFO] [stderr] 259 | return Ok(HttpResponse::Unauthorized().content_type("text/plain; charset=utf-8").body("Unauthorized: Invalid key\n")).into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Ok(HttpResponse::Unauthorized().content_type("text/plain; charset=utf-8").body("Unauthorized: Invalid key\n"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:266:16 [INFO] [stderr] | [INFO] [stderr] 266 | Ok(HttpResponse::Ok().body(format!( [INFO] [stderr] | ________________^ [INFO] [stderr] 267 | | "View URL: {url}\nEdit URL: {url}/{key}\n\nThis paste will be deleted in {days} days.\n", [INFO] [stderr] 268 | | url = url, key = gen_key(&id), days = PASTE_DAYS)).into()) [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 266 | Ok(HttpResponse::Ok().body(format!( [INFO] [stderr] 267 | "View URL: {url}\nEdit URL: {url}/{key}\n\nThis paste will be deleted in {days} days.\n", [INFO] [stderr] 268 | url = url, key = gen_key(&id), days = PASTE_DAYS))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 39s [INFO] running `"docker" "inspect" "0a9865c2f2f3ded58afc042af383fea67529c39e691059232cb296e61a3d0730"` [INFO] running `"docker" "rm" "-f" "0a9865c2f2f3ded58afc042af383fea67529c39e691059232cb296e61a3d0730"` [INFO] [stdout] 0a9865c2f2f3ded58afc042af383fea67529c39e691059232cb296e61a3d0730