[INFO] updating cached repository oinkina/rusty-lisp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/oinkina/rusty-lisp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/oinkina/rusty-lisp" "work/ex/clippy-test-run/sources/stable/gh/oinkina/rusty-lisp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/oinkina/rusty-lisp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/oinkina/rusty-lisp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/oinkina/rusty-lisp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/oinkina/rusty-lisp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] abf1d67171be2705c9cf2c343f6b352f395308f5 [INFO] sha for GitHub repo oinkina/rusty-lisp: abf1d67171be2705c9cf2c343f6b352f395308f5 [INFO] validating manifest of oinkina/rusty-lisp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of oinkina/rusty-lisp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing oinkina/rusty-lisp [INFO] finished frobbing oinkina/rusty-lisp [INFO] frobbed toml for oinkina/rusty-lisp written to work/ex/clippy-test-run/sources/stable/gh/oinkina/rusty-lisp/Cargo.toml [INFO] started frobbing oinkina/rusty-lisp [INFO] finished frobbing oinkina/rusty-lisp [INFO] frobbed toml for oinkina/rusty-lisp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/oinkina/rusty-lisp/Cargo.toml [INFO] crate oinkina/rusty-lisp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting oinkina/rusty-lisp against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/oinkina/rusty-lisp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 692e1f95a7451e39415e46c9906c70d2096a30b36319b0a117fcfe42e00533db [INFO] running `"docker" "start" "-a" "692e1f95a7451e39415e46c9906c70d2096a30b36319b0a117fcfe42e00533db"` [INFO] [stderr] Checking lisp-interpreter v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:69:30 [INFO] [stderr] | [INFO] [stderr] 69 | AST::Cons { head : head, tail : tail }}, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `head` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:69:43 [INFO] [stderr] | [INFO] [stderr] 69 | AST::Cons { head : head, tail : tail }}, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `tail` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:69:30 [INFO] [stderr] | [INFO] [stderr] 69 | AST::Cons { head : head, tail : tail }}, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `head` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:69:43 [INFO] [stderr] | [INFO] [stderr] 69 | AST::Cons { head : head, tail : tail }}, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `tail` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/main.rs:126:30 [INFO] [stderr] | [INFO] [stderr] 126 | AST::Cons { head: h, tail: _ } => match *h { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Cons { head: h, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/main.rs:127:35 [INFO] [stderr] | [INFO] [stderr] 127 | AST::Cons { head: h2, tail: _ } => *h2, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Cons { head: h2, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/main.rs:135:30 [INFO] [stderr] | [INFO] [stderr] 135 | AST::Cons { head: h, tail: _ } => match *h { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Cons { head: h, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/main.rs:136:25 [INFO] [stderr] | [INFO] [stderr] 136 | AST::Cons { head: _, tail: t} => *t, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Cons { tail: t, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / loop { [INFO] [stderr] 19 | | match iter.peek() { [INFO] [stderr] 20 | | Some(&ws) => match ws { [INFO] [stderr] 21 | | ' '|'\n'|'\t' => iter.next(), [INFO] [stderr] 22 | | _ => break, [INFO] [stderr] 23 | | }, None => break, [INFO] [stderr] 24 | | }; }; [INFO] [stderr] | |____________^ help: try: `while let Some(&ws) = iter.peek() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:149:37 [INFO] [stderr] | [INFO] [stderr] 149 | AST::Nil => format!("[]"), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using .to_string(): `"[]".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:151:37 [INFO] [stderr] | [INFO] [stderr] 151 | AST::Word(w) => format!("{}", w), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `w.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/main.rs:126:30 [INFO] [stderr] | [INFO] [stderr] 126 | AST::Cons { head: h, tail: _ } => match *h { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Cons { head: h, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/main.rs:127:35 [INFO] [stderr] | [INFO] [stderr] 127 | AST::Cons { head: h2, tail: _ } => *h2, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Cons { head: h2, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/main.rs:135:30 [INFO] [stderr] | [INFO] [stderr] 135 | AST::Cons { head: h, tail: _ } => match *h { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Cons { head: h, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/main.rs:136:25 [INFO] [stderr] | [INFO] [stderr] 136 | AST::Cons { head: _, tail: t} => *t, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Cons { tail: t, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / loop { [INFO] [stderr] 19 | | match iter.peek() { [INFO] [stderr] 20 | | Some(&ws) => match ws { [INFO] [stderr] 21 | | ' '|'\n'|'\t' => iter.next(), [INFO] [stderr] 22 | | _ => break, [INFO] [stderr] 23 | | }, None => break, [INFO] [stderr] 24 | | }; }; [INFO] [stderr] | |____________^ help: try: `while let Some(&ws) = iter.peek() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:149:37 [INFO] [stderr] | [INFO] [stderr] 149 | AST::Nil => format!("[]"), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using .to_string(): `"[]".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:151:37 [INFO] [stderr] | [INFO] [stderr] 151 | AST::Word(w) => format!("{}", w), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `w.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.79s [INFO] running `"docker" "inspect" "692e1f95a7451e39415e46c9906c70d2096a30b36319b0a117fcfe42e00533db"` [INFO] running `"docker" "rm" "-f" "692e1f95a7451e39415e46c9906c70d2096a30b36319b0a117fcfe42e00533db"` [INFO] [stdout] 692e1f95a7451e39415e46c9906c70d2096a30b36319b0a117fcfe42e00533db