[INFO] updating cached repository ogham/exa [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ogham/exa [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ogham/exa" "work/ex/clippy-test-run/sources/stable/gh/ogham/exa"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ogham/exa'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ogham/exa" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ogham/exa"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ogham/exa'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 058b4a57bdb1e25cbdacc0fbd1eefc09bc5f1e95 [INFO] sha for GitHub repo ogham/exa: 058b4a57bdb1e25cbdacc0fbd1eefc09bc5f1e95 [INFO] validating manifest of ogham/exa on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ogham/exa on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ogham/exa [INFO] finished frobbing ogham/exa [INFO] frobbed toml for ogham/exa written to work/ex/clippy-test-run/sources/stable/gh/ogham/exa/Cargo.toml [INFO] started frobbing ogham/exa [INFO] finished frobbing ogham/exa [INFO] frobbed toml for ogham/exa written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ogham/exa/Cargo.toml [INFO] crate ogham/exa has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ogham/exa against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ogham/exa:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b4e8fc23b666a2a056f8245588c7c7120172041794532f1a0134ec1442cb0a38 [INFO] running `"docker" "start" "-a" "b4e8fc23b666a2a056f8245588c7c7120172041794532f1a0134ec1442cb0a38"` [INFO] [stderr] Compiling nom v1.2.4 [INFO] [stderr] Compiling num-traits v0.2.1 [INFO] [stderr] Compiling cmake v0.1.29 [INFO] [stderr] Compiling libz-sys v1.0.18 [INFO] [stderr] Checking locale v0.2.2 [INFO] [stderr] Checking atty v0.2.10 [INFO] [stderr] Checking users v0.8.1 [INFO] [stderr] Compiling pad v0.1.5 [INFO] [stderr] Checking term_grid v0.1.7 [INFO] [stderr] Checking iso8601 v0.1.1 [INFO] [stderr] Checking number_prefix v0.2.8 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Compiling libgit2-sys v0.7.1 [INFO] [stderr] Compiling num-traits v0.1.43 [INFO] [stderr] Checking regex v0.2.7 [INFO] [stderr] Checking datetime v0.4.7 [INFO] [stderr] Checking zoneinfo_compiled v0.4.7 [INFO] [stderr] Checking env_logger v0.5.9 [INFO] [stderr] Compiling exa v0.9.0-pre (/opt/crater/workdir) [INFO] [stderr] Checking git2 v0.7.0 [INFO] [stderr] warning: All variants have the same postfix: `Next` [INFO] [stderr] --> src/fs/dir.rs:124:1 [INFO] [stderr] | [INFO] [stderr] 124 | / enum Dots { [INFO] [stderr] 125 | | [INFO] [stderr] 126 | | /// List the `.` directory next. [INFO] [stderr] 127 | | DotNext, [INFO] [stderr] ... | [INFO] [stderr] 133 | | FilesNext, [INFO] [stderr] 134 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/fs/file.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: All variants have the same postfix: `Next` [INFO] [stderr] --> src/fs/dir.rs:124:1 [INFO] [stderr] | [INFO] [stderr] 124 | / enum Dots { [INFO] [stderr] 125 | | [INFO] [stderr] 126 | | /// List the `.` directory next. [INFO] [stderr] 127 | | DotNext, [INFO] [stderr] ... | [INFO] [stderr] 133 | | FilesNext, [INFO] [stderr] 134 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/fs/file.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/options/view.rs:534:115 [INFO] [stderr] | [INFO] [stderr] 534 | test!(original_g: Mode <- ["-G"], None; Both => like Ok(Mode::Grid(GridOptions { across: false, console_width: _ }))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `GridOptions { across: false, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/options/view.rs:535:115 [INFO] [stderr] | [INFO] [stderr] 535 | test!(grid: Mode <- ["--grid"], None; Both => like Ok(Mode::Grid(GridOptions { across: false, console_width: _ }))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `GridOptions { across: false, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/options/view.rs:536:115 [INFO] [stderr] | [INFO] [stderr] 536 | test!(across: Mode <- ["--across"], None; Both => like Ok(Mode::Grid(GridOptions { across: true, console_width: _ }))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `GridOptions { across: true, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/options/view.rs:537:115 [INFO] [stderr] | [INFO] [stderr] 537 | test!(gracross: Mode <- ["-xG"], None; Both => like Ok(Mode::Grid(GridOptions { across: true, console_width: _ }))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `GridOptions { across: true, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/output/render/inode.rs:24:27 [INFO] [stderr] | [INFO] [stderr] 24 | let io = f::Inode(1414213); [INFO] [stderr] | ^^^^^^^ help: consider: `1_414_213` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/output/render/size.rs:147:39 [INFO] [stderr] | [INFO] [stderr] 147 | let directory = f::Size::Some(1048576); [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/options/view.rs:278:58 [INFO] [stderr] | [INFO] [stderr] 278 | Err(Misfire::BadArgument(&flags::TIME_STYLE, word.into())) [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `word` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/options/parser.rs:259:48 [INFO] [stderr] | [INFO] [stderr] 259 | for (index, byte) in bytes.into_iter().enumerate().skip(1) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/options/parser.rs:292:22 [INFO] [stderr] | [INFO] [stderr] 292 | match self.0.into_iter().find(|arg| arg.short == Some(short)) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/options/parser.rs:299:22 [INFO] [stderr] | [INFO] [stderr] 299 | match self.0.into_iter().find(|arg| arg.long == long) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/output/mod.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | GridDetails(grid_details::Options), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 35 | GridDetails(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/style/colours.rs:326:5 [INFO] [stderr] | [INFO] [stderr] 326 | fn new(&self) -> Style { self.git.new } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/options/style.rs:411:32 [INFO] [stderr] | [INFO] [stderr] 411 | OsString::from(self.ls.clone()).into() [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 411 | OsString::from(&(*self.ls).clone()).into() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 411 | OsString::from(&str::clone(self.ls)).into() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/options/style.rs:414:32 [INFO] [stderr] | [INFO] [stderr] 414 | OsString::from(self.exa.clone()).into() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 414 | OsString::from(&(*self.exa).clone()).into() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 414 | OsString::from(&str::clone(self.exa)).into() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/options/view.rs:278:58 [INFO] [stderr] | [INFO] [stderr] 278 | Err(Misfire::BadArgument(&flags::TIME_STYLE, word.into())) [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `word` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/options/parser.rs:259:48 [INFO] [stderr] | [INFO] [stderr] 259 | for (index, byte) in bytes.into_iter().enumerate().skip(1) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/options/parser.rs:292:22 [INFO] [stderr] | [INFO] [stderr] 292 | match self.0.into_iter().find(|arg| arg.short == Some(short)) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/options/parser.rs:299:22 [INFO] [stderr] | [INFO] [stderr] 299 | match self.0.into_iter().find(|arg| arg.long == long) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/options/mod.rs:196:27 [INFO] [stderr] | [INFO] [stderr] 196 | let bits = inputs.into_iter().map(|&o| os(o)).collect::>(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/output/render/blocks.rs:46:30 [INFO] [stderr] | [INFO] [stderr] 46 | assert_eq!(expected, blox.render(&TestColours).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `blox.render(&TestColours)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/output/render/blocks.rs:55:30 [INFO] [stderr] | [INFO] [stderr] 55 | assert_eq!(expected, blox.render(&TestColours).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `blox.render(&TestColours)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/output/render/git.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | fn new(&self) -> Style { Fixed(91).normal() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/output/render/git.rs:84:30 [INFO] [stderr] | [INFO] [stderr] 84 | assert_eq!(expected, stati.render(&TestColours).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `stati.render(&TestColours)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/output/render/git.rs:103:30 [INFO] [stderr] | [INFO] [stderr] 103 | assert_eq!(expected, stati.render(&TestColours).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `stati.render(&TestColours)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/output/render/inode.rs:26:30 [INFO] [stderr] | [INFO] [stderr] 26 | assert_eq!(expected, io.render(Cyan.underline()).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `io.render(Cyan.underline())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/output/render/links.rs:55:30 [INFO] [stderr] | [INFO] [stderr] 55 | assert_eq!(expected, stati.render(&TestColours, &locale::Numeric::english()).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `stati.render(&TestColours, &locale::Numeric::english())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/output/render/links.rs:70:30 [INFO] [stderr] | [INFO] [stderr] 70 | assert_eq!(expected, stati.render(&TestColours, &locale::Numeric::english()).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `stati.render(&TestColours, &locale::Numeric::english())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/output/render/links.rs:85:30 [INFO] [stderr] | [INFO] [stderr] 85 | assert_eq!(expected, stati.render(&TestColours, &locale::Numeric::english()).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `stati.render(&TestColours, &locale::Numeric::english())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/output/tree.rs:251:60 [INFO] [stderr] | [INFO] [stderr] 251 | let mut iter = TreeDepth::root().iterate_over(foos.into_iter()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/output/tree.rs:271:63 [INFO] [stderr] | [INFO] [stderr] 271 | let mut iter = TreeDepth::root().iterate_over(nothing.into_iter()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/output/mod.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | GridDetails(grid_details::Options), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 35 | GridDetails(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/style/colours.rs:326:5 [INFO] [stderr] | [INFO] [stderr] 326 | fn new(&self) -> Style { self.git.new } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `exa`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "b4e8fc23b666a2a056f8245588c7c7120172041794532f1a0134ec1442cb0a38"` [INFO] running `"docker" "rm" "-f" "b4e8fc23b666a2a056f8245588c7c7120172041794532f1a0134ec1442cb0a38"` [INFO] [stdout] b4e8fc23b666a2a056f8245588c7c7120172041794532f1a0134ec1442cb0a38