[INFO] updating cached repository oftlisp/oftb [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/oftlisp/oftb [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/oftlisp/oftb" "work/ex/clippy-test-run/sources/stable/gh/oftlisp/oftb"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/oftlisp/oftb'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/oftlisp/oftb" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/oftlisp/oftb"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/oftlisp/oftb'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 42e534cfe5a9c3364cfd6551ce2860367e1c778e [INFO] sha for GitHub repo oftlisp/oftb: 42e534cfe5a9c3364cfd6551ce2860367e1c778e [INFO] validating manifest of oftlisp/oftb on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of oftlisp/oftb on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing oftlisp/oftb [INFO] finished frobbing oftlisp/oftb [INFO] frobbed toml for oftlisp/oftb written to work/ex/clippy-test-run/sources/stable/gh/oftlisp/oftb/Cargo.toml [INFO] started frobbing oftlisp/oftb [INFO] finished frobbing oftlisp/oftb [INFO] frobbed toml for oftlisp/oftb written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/oftlisp/oftb/Cargo.toml [INFO] crate oftlisp/oftb has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting oftlisp/oftb against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/oftlisp/oftb:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f4a68f5a603a431fafcc9ebea1e324d4bc0e8769d18492d31bfd021a0901ee7e [INFO] running `"docker" "start" "-a" "f4a68f5a603a431fafcc9ebea1e324d4bc0e8769d18492d31bfd021a0901ee7e"` [INFO] [stderr] Compiling num-integer v0.1.38 [INFO] [stderr] Checking bit-vec v0.5.0 [INFO] [stderr] Checking zero v0.1.2 [INFO] [stderr] Checking spin v0.4.8 [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Compiling syn v0.13.10 [INFO] [stderr] Checking backtrace-sys v0.1.16 [INFO] [stderr] Checking xmas-elf v0.6.2 [INFO] [stderr] Checking symbol v0.1.1 [INFO] [stderr] Checking backtrace v0.3.7 [INFO] [stderr] Checking bit-set v0.5.0 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking num-iter v0.1.37 [INFO] [stderr] Checking chrono v0.4.2 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking proptest v0.7.0 [INFO] [stderr] Checking stderrlog v0.4.0 [INFO] [stderr] Compiling structopt-derive v0.2.8 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking structopt v0.2.8 [INFO] [stderr] Checking oftb v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | Error { inner: inner } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/util.rs:42:21 [INFO] [stderr] | [INFO] [stderr] 42 | '\n' => write!(fmt, "\\n")?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/flatanf/convert.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | attrs: _, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Module { name: module_name, imports, exports, body, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser/symbolish.rs:9:18 [INFO] [stderr] | [INFO] [stderr] 9 | const _GRAMMAR: &'static str = include_str!("../symbolish.pest"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser/mod.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | const _GRAMMAR: &'static str = include_str!("../oftlisp.pest"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/ast/helpers.rs:8:6 [INFO] [stderr] | [INFO] [stderr] 8 | ) -> Option<(Symbol, Symbol, Vec, Vec<(Symbol, Option)>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/ast/helpers.rs:47:6 [INFO] [stderr] | [INFO] [stderr] 47 | ) -> Option<(Symbol, Vec, Vec<(Symbol, Option)>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ast/helpers.rs:61:16 [INFO] [stderr] | [INFO] [stderr] 61 | if attrs.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `attrs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ast/mod.rs:25:12 [INFO] [stderr] | [INFO] [stderr] 25 | if l.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `l.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/ast/mod.rs:48:18 [INFO] [stderr] | [INFO] [stderr] 48 | .unwrap_or(l.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| l.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `interpreter::env::Env` [INFO] [stderr] --> src/interpreter/env.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Env { [INFO] [stderr] 20 | | Env { [INFO] [stderr] 21 | | inner: Rc::new(EnvInner::Nil), [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | impl Default for interpreter::env::Env { [INFO] [stderr] 18 | fn default() -> Self { [INFO] [stderr] 19 | Self::new() [INFO] [stderr] 20 | } [INFO] [stderr] 21 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/interpreter/eval.rs:14:15 [INFO] [stderr] | [INFO] [stderr] 14 | globals: &HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 11 | pub fn step<'program, S: ::std::hash::BuildHasher>( [INFO] [stderr] 12 | control: Control<'program>, [INFO] [stderr] 13 | mut env: Env, [INFO] [stderr] 14 | globals: &HashMap, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/interpreter/eval.rs:94:15 [INFO] [stderr] | [INFO] [stderr] 94 | globals: &HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 91 | pub fn atomic<'program, S: ::std::hash::BuildHasher>( [INFO] [stderr] 92 | expr: &'program AExpr, [INFO] [stderr] 93 | env: &Env, [INFO] [stderr] 94 | globals: &HashMap, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/interpreter/eval.rs:137:32 [INFO] [stderr] | [INFO] [stderr] 137 | let env = env.push(val.clone()); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `val` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `interpreter::store::Store<'program>` [INFO] [stderr] --> src/interpreter/store.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn new() -> Store<'program> { [INFO] [stderr] 33 | | Store { [INFO] [stderr] 34 | | bytes: Vec::new(), [INFO] [stderr] 35 | | clos: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `interpreter::Interpreter<'program>` [INFO] [stderr] --> src/interpreter/mod.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / pub fn new() -> Interpreter<'program> { [INFO] [stderr] 41 | | Interpreter::with_globals_and_store(HashMap::new(), Store::new()) [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | impl Default for interpreter::Interpreter<'program> { [INFO] [stderr] 38 | fn default() -> Self { [INFO] [stderr] 39 | Self::new() [INFO] [stderr] 40 | } [INFO] [stderr] 41 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/intrinsics/mod.rs:148:39 [INFO] [stderr] | [INFO] [stderr] 148 | Value::Byte(a.rotate_left(b as u32)) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/intrinsics/mod.rs:153:40 [INFO] [stderr] | [INFO] [stderr] 153 | Value::Byte(a.rotate_right(b as u32)) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/intrinsics/mod.rs:158:39 [INFO] [stderr] | [INFO] [stderr] 158 | Value::Byte(a.checked_shl(b as u32).unwrap_or(0)) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/intrinsics/mod.rs:163:39 [INFO] [stderr] | [INFO] [stderr] 163 | Value::Byte(a.checked_shr(b as u32).unwrap_or(0)) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/modules/metadata.rs:148:36 [INFO] [stderr] | [INFO] [stderr] 148 | components: components.ok_or(ErrorKind::MissingField("components".into()))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::MissingField("components".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/modules/metadata.rs:151:24 [INFO] [stderr] | [INFO] [stderr] 151 | name: name.ok_or(ErrorKind::MissingField("name".into()))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::MissingField("name".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/modules/metadata.rs:152:30 [INFO] [stderr] | [INFO] [stderr] 152 | version: version.ok_or(ErrorKind::MissingField("version".into()))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::MissingField("version".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/modules/metadata.rs:157:24 [INFO] [stderr] | [INFO] [stderr] 157 | pub fn to_literals(self) -> Vec { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/modules/metadata.rs:159:12 [INFO] [stderr] | [INFO] [stderr] 159 | if self.authors.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.authors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/modules/metadata.rs:172:29 [INFO] [stderr] | [INFO] [stderr] 172 | Literal::Symbol(self.name.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/modules/metadata.rs:184:12 [INFO] [stderr] | [INFO] [stderr] 184 | if self.dependencies.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.dependencies.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/modules/metadata.rs:190:46 [INFO] [stderr] | [INFO] [stderr] 190 | Box::new(Literal::Symbol(name.into())), [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/modules/metadata.rs:244:23 [INFO] [stderr] | [INFO] [stderr] 244 | pub fn to_literal(self) -> Literal { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/modules/metadata.rs:281:23 [INFO] [stderr] | [INFO] [stderr] 281 | pub fn to_literal(self) -> Literal { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/modules/metadata.rs:337:24 [INFO] [stderr] | [INFO] [stderr] 337 | name: name.ok_or(ErrorKind::MissingField("name".into()))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::MissingField("name".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/modules/metadata.rs:338:24 [INFO] [stderr] | [INFO] [stderr] 338 | path: path.ok_or(ErrorKind::MissingField("path".into()))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::MissingField("path".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/modules/metadata.rs:343:23 [INFO] [stderr] | [INFO] [stderr] 343 | pub fn to_literal(self) -> Literal { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/modules/metadata.rs:405:30 [INFO] [stderr] | [INFO] [stderr] 405 | version: version.ok_or(ErrorKind::MissingField("version".into()))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::MissingField("version".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/modules/metadata.rs:410:23 [INFO] [stderr] | [INFO] [stderr] 410 | pub fn to_literal(self) -> Literal { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `modules::Packages` [INFO] [stderr] --> src/modules/mod.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / pub fn new() -> Packages { [INFO] [stderr] 44 | | Packages { [INFO] [stderr] 45 | | pkgs: HashMap::new(), [INFO] [stderr] 46 | | std_name: None, [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 36 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/modules/mod.rs:140:50 [INFO] [stderr] | [INFO] [stderr] 140 | if main_files.iter().any(|p| { [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 141 | | let p: &Path = p.as_ref(); [INFO] [stderr] 142 | | p == file_name [INFO] [stderr] 143 | | }) { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser/convert.rs:171:24 [INFO] [stderr] | [INFO] [stderr] 171 | n = (n << 4) + (convert_hex_digit(pair.as_str()) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(convert_hex_digit(pair.as_str()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/sanity/locals_valid.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / fn check_expr<'a>(depth: usize, expr: &'a Expr) -> FailRecord<'a> { [INFO] [stderr] 20 | | match *expr { [INFO] [stderr] 21 | | Expr::AExpr(ref e) => check_aexpr(depth, e), [INFO] [stderr] 22 | | Expr::CExpr(ref e) => check_cexpr(depth, e), [INFO] [stderr] ... | [INFO] [stderr] 25 | | }.chain(expr) [INFO] [stderr] 26 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/sanity/locals_valid.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | / fn check_aexpr<'a>(depth: usize, expr: &'a AExpr) -> FailRecord<'a> { [INFO] [stderr] 29 | | match *expr { [INFO] [stderr] 30 | | AExpr::Lambda(_, argn, ref body) => check_expr(depth + argn, body), [INFO] [stderr] 31 | | AExpr::Local(n) if n >= depth => FailRecord::err(n, depth), [INFO] [stderr] ... | [INFO] [stderr] 35 | | }.chain_a(expr) [INFO] [stderr] 36 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/sanity/locals_valid.rs:38:1 [INFO] [stderr] | [INFO] [stderr] 38 | / fn check_cexpr<'a>(depth: usize, expr: &'a CExpr) -> FailRecord<'a> { [INFO] [stderr] 39 | | match *expr { [INFO] [stderr] 40 | | CExpr::Call(ref func, ref args) => check_aexpr(depth, func) [INFO] [stderr] 41 | | .or_else(|| FailRecord::all(args.iter().map(|a| check_aexpr(depth, a)))), [INFO] [stderr] ... | [INFO] [stderr] 53 | | }.chain_c(expr) [INFO] [stderr] 54 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/sanity/locals_valid.rs:67:30 [INFO] [stderr] | [INFO] [stderr] 67 | while let Some(fr) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for fr in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sanity/locals_valid.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | / if let &FailRecord::NoError = fr.root() { [INFO] [stderr] 69 | | continue; [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 68 | if let FailRecord::NoError = *fr.root() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sanity/locals_valid.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | / if let &FailRecord::NoError = self.root() { [INFO] [stderr] 101 | | false [INFO] [stderr] 102 | | } else { [INFO] [stderr] 103 | | true [INFO] [stderr] 104 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 100 | if let FailRecord::NoError = *self.root() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut libc::c_void`) to a reference type (`&mut usize`) [INFO] [stderr] --> src/util.rs:82:40 [INFO] [stderr] | [INFO] [stderr] 82 | let relo: &mut usize = transmute(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&mut *(data as *mut usize)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | Error { inner: inner } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/util.rs:42:21 [INFO] [stderr] | [INFO] [stderr] 42 | '\n' => write!(fmt, "\\n")?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/flatanf/convert.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | attrs: _, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Module { name: module_name, imports, exports, body, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser/symbolish.rs:9:18 [INFO] [stderr] | [INFO] [stderr] 9 | const _GRAMMAR: &'static str = include_str!("../symbolish.pest"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser/mod.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | const _GRAMMAR: &'static str = include_str!("../oftlisp.pest"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bin/options/compile.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | path.into() [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bin/options/run.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | path.into() [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bin/options/compile.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | path.into() [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bin/options/run.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | path.into() [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/ast/helpers.rs:8:6 [INFO] [stderr] | [INFO] [stderr] 8 | ) -> Option<(Symbol, Symbol, Vec, Vec<(Symbol, Option)>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/ast/helpers.rs:47:6 [INFO] [stderr] | [INFO] [stderr] 47 | ) -> Option<(Symbol, Vec, Vec<(Symbol, Option)>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ast/helpers.rs:61:16 [INFO] [stderr] | [INFO] [stderr] 61 | if attrs.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `attrs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ast/mod.rs:25:12 [INFO] [stderr] | [INFO] [stderr] 25 | if l.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `l.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/ast/mod.rs:48:18 [INFO] [stderr] | [INFO] [stderr] 48 | .unwrap_or(l.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| l.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `interpreter::env::Env` [INFO] [stderr] --> src/interpreter/env.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Env { [INFO] [stderr] 20 | | Env { [INFO] [stderr] 21 | | inner: Rc::new(EnvInner::Nil), [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | impl Default for interpreter::env::Env { [INFO] [stderr] 18 | fn default() -> Self { [INFO] [stderr] 19 | Self::new() [INFO] [stderr] 20 | } [INFO] [stderr] 21 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/interpreter/eval.rs:14:15 [INFO] [stderr] | [INFO] [stderr] 14 | globals: &HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 11 | pub fn step<'program, S: ::std::hash::BuildHasher>( [INFO] [stderr] 12 | control: Control<'program>, [INFO] [stderr] 13 | mut env: Env, [INFO] [stderr] 14 | globals: &HashMap, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/interpreter/eval.rs:94:15 [INFO] [stderr] | [INFO] [stderr] 94 | globals: &HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 91 | pub fn atomic<'program, S: ::std::hash::BuildHasher>( [INFO] [stderr] 92 | expr: &'program AExpr, [INFO] [stderr] 93 | env: &Env, [INFO] [stderr] 94 | globals: &HashMap, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/interpreter/eval.rs:137:32 [INFO] [stderr] | [INFO] [stderr] 137 | let env = env.push(val.clone()); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `val` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `interpreter::store::Store<'program>` [INFO] [stderr] --> src/interpreter/store.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn new() -> Store<'program> { [INFO] [stderr] 33 | | Store { [INFO] [stderr] 34 | | bytes: Vec::new(), [INFO] [stderr] 35 | | clos: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `interpreter::Interpreter<'program>` [INFO] [stderr] --> src/interpreter/mod.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / pub fn new() -> Interpreter<'program> { [INFO] [stderr] 41 | | Interpreter::with_globals_and_store(HashMap::new(), Store::new()) [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | impl Default for interpreter::Interpreter<'program> { [INFO] [stderr] 38 | fn default() -> Self { [INFO] [stderr] 39 | Self::new() [INFO] [stderr] 40 | } [INFO] [stderr] 41 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/intrinsics/mod.rs:148:39 [INFO] [stderr] | [INFO] [stderr] 148 | Value::Byte(a.rotate_left(b as u32)) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/intrinsics/mod.rs:153:40 [INFO] [stderr] | [INFO] [stderr] 153 | Value::Byte(a.rotate_right(b as u32)) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/intrinsics/mod.rs:158:39 [INFO] [stderr] | [INFO] [stderr] 158 | Value::Byte(a.checked_shl(b as u32).unwrap_or(0)) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/intrinsics/mod.rs:163:39 [INFO] [stderr] | [INFO] [stderr] 163 | Value::Byte(a.checked_shr(b as u32).unwrap_or(0)) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/modules/metadata.rs:148:36 [INFO] [stderr] | [INFO] [stderr] 148 | components: components.ok_or(ErrorKind::MissingField("components".into()))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::MissingField("components".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/modules/metadata.rs:151:24 [INFO] [stderr] | [INFO] [stderr] 151 | name: name.ok_or(ErrorKind::MissingField("name".into()))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::MissingField("name".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/modules/metadata.rs:152:30 [INFO] [stderr] | [INFO] [stderr] 152 | version: version.ok_or(ErrorKind::MissingField("version".into()))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::MissingField("version".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/modules/metadata.rs:157:24 [INFO] [stderr] | [INFO] [stderr] 157 | pub fn to_literals(self) -> Vec { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/modules/metadata.rs:159:12 [INFO] [stderr] | [INFO] [stderr] 159 | if self.authors.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.authors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/modules/metadata.rs:172:29 [INFO] [stderr] | [INFO] [stderr] 172 | Literal::Symbol(self.name.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/modules/metadata.rs:184:12 [INFO] [stderr] | [INFO] [stderr] 184 | if self.dependencies.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.dependencies.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/modules/metadata.rs:190:46 [INFO] [stderr] | [INFO] [stderr] 190 | Box::new(Literal::Symbol(name.into())), [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/modules/metadata.rs:244:23 [INFO] [stderr] | [INFO] [stderr] 244 | pub fn to_literal(self) -> Literal { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/modules/metadata.rs:281:23 [INFO] [stderr] | [INFO] [stderr] 281 | pub fn to_literal(self) -> Literal { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/modules/metadata.rs:337:24 [INFO] [stderr] | [INFO] [stderr] 337 | name: name.ok_or(ErrorKind::MissingField("name".into()))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::MissingField("name".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/modules/metadata.rs:338:24 [INFO] [stderr] | [INFO] [stderr] 338 | path: path.ok_or(ErrorKind::MissingField("path".into()))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::MissingField("path".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/modules/metadata.rs:343:23 [INFO] [stderr] | [INFO] [stderr] 343 | pub fn to_literal(self) -> Literal { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/modules/metadata.rs:405:30 [INFO] [stderr] | [INFO] [stderr] 405 | version: version.ok_or(ErrorKind::MissingField("version".into()))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::MissingField("version".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/modules/metadata.rs:410:23 [INFO] [stderr] | [INFO] [stderr] 410 | pub fn to_literal(self) -> Literal { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `modules::Packages` [INFO] [stderr] --> src/modules/mod.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / pub fn new() -> Packages { [INFO] [stderr] 44 | | Packages { [INFO] [stderr] 45 | | pkgs: HashMap::new(), [INFO] [stderr] 46 | | std_name: None, [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 36 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/modules/mod.rs:140:50 [INFO] [stderr] | [INFO] [stderr] 140 | if main_files.iter().any(|p| { [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 141 | | let p: &Path = p.as_ref(); [INFO] [stderr] 142 | | p == file_name [INFO] [stderr] 143 | | }) { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser/convert.rs:171:24 [INFO] [stderr] | [INFO] [stderr] 171 | n = (n << 4) + (convert_hex_digit(pair.as_str()) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(convert_hex_digit(pair.as_str()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/sanity/locals_valid.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / fn check_expr<'a>(depth: usize, expr: &'a Expr) -> FailRecord<'a> { [INFO] [stderr] 20 | | match *expr { [INFO] [stderr] 21 | | Expr::AExpr(ref e) => check_aexpr(depth, e), [INFO] [stderr] 22 | | Expr::CExpr(ref e) => check_cexpr(depth, e), [INFO] [stderr] ... | [INFO] [stderr] 25 | | }.chain(expr) [INFO] [stderr] 26 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/sanity/locals_valid.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | / fn check_aexpr<'a>(depth: usize, expr: &'a AExpr) -> FailRecord<'a> { [INFO] [stderr] 29 | | match *expr { [INFO] [stderr] 30 | | AExpr::Lambda(_, argn, ref body) => check_expr(depth + argn, body), [INFO] [stderr] 31 | | AExpr::Local(n) if n >= depth => FailRecord::err(n, depth), [INFO] [stderr] ... | [INFO] [stderr] 35 | | }.chain_a(expr) [INFO] [stderr] 36 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/sanity/locals_valid.rs:38:1 [INFO] [stderr] | [INFO] [stderr] 38 | / fn check_cexpr<'a>(depth: usize, expr: &'a CExpr) -> FailRecord<'a> { [INFO] [stderr] 39 | | match *expr { [INFO] [stderr] 40 | | CExpr::Call(ref func, ref args) => check_aexpr(depth, func) [INFO] [stderr] 41 | | .or_else(|| FailRecord::all(args.iter().map(|a| check_aexpr(depth, a)))), [INFO] [stderr] ... | [INFO] [stderr] 53 | | }.chain_c(expr) [INFO] [stderr] 54 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/sanity/locals_valid.rs:67:30 [INFO] [stderr] | [INFO] [stderr] 67 | while let Some(fr) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for fr in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sanity/locals_valid.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | / if let &FailRecord::NoError = fr.root() { [INFO] [stderr] 69 | | continue; [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 68 | if let FailRecord::NoError = *fr.root() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sanity/locals_valid.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | / if let &FailRecord::NoError = self.root() { [INFO] [stderr] 101 | | false [INFO] [stderr] 102 | | } else { [INFO] [stderr] 103 | | true [INFO] [stderr] 104 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 100 | if let FailRecord::NoError = *self.root() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut libc::c_void`) to a reference type (`&mut usize`) [INFO] [stderr] --> src/util.rs:82:40 [INFO] [stderr] | [INFO] [stderr] 82 | let relo: &mut usize = transmute(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&mut *(data as *mut usize)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 39.58s [INFO] running `"docker" "inspect" "f4a68f5a603a431fafcc9ebea1e324d4bc0e8769d18492d31bfd021a0901ee7e"` [INFO] running `"docker" "rm" "-f" "f4a68f5a603a431fafcc9ebea1e324d4bc0e8769d18492d31bfd021a0901ee7e"` [INFO] [stdout] f4a68f5a603a431fafcc9ebea1e324d4bc0e8769d18492d31bfd021a0901ee7e