[INFO] updating cached repository ocrickard/circ [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ocrickard/circ [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ocrickard/circ" "work/ex/clippy-test-run/sources/stable/gh/ocrickard/circ"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ocrickard/circ'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ocrickard/circ" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ocrickard/circ"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ocrickard/circ'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a3424007a5a1290d5cf5184ac08a4b629701f8cd [INFO] sha for GitHub repo ocrickard/circ: a3424007a5a1290d5cf5184ac08a4b629701f8cd [INFO] validating manifest of ocrickard/circ on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ocrickard/circ on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ocrickard/circ [INFO] finished frobbing ocrickard/circ [INFO] frobbed toml for ocrickard/circ written to work/ex/clippy-test-run/sources/stable/gh/ocrickard/circ/Cargo.toml [INFO] started frobbing ocrickard/circ [INFO] finished frobbing ocrickard/circ [INFO] frobbed toml for ocrickard/circ written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ocrickard/circ/Cargo.toml [INFO] crate ocrickard/circ has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ocrickard/circ against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ocrickard/circ:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 18ecda7edfcb3fadf9a56bafeab5bc13c4f78c5c34d88def5d83330b7d5a09fa [INFO] running `"docker" "start" "-a" "18ecda7edfcb3fadf9a56bafeab5bc13c4f78c5c34d88def5d83330b7d5a09fa"` [INFO] [stderr] Compiling ring v0.13.0-alpha5 [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Compiling syn v0.14.2 [INFO] [stderr] Compiling structopt-derive v0.2.10 [INFO] [stderr] Checking structopt v0.2.10 [INFO] [stderr] Checking circ v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/digest.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / arg_enum! { [INFO] [stderr] 13 | | #[derive(Debug)] [INFO] [stderr] 14 | | pub enum Algorithm { [INFO] [stderr] 15 | | SHA1, [INFO] [stderr] ... | [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/digest.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / arg_enum! { [INFO] [stderr] 13 | | #[derive(Debug)] [INFO] [stderr] 14 | | pub enum Algorithm { [INFO] [stderr] 15 | | SHA1, [INFO] [stderr] ... | [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/hex.rs:23:26 [INFO] [stderr] | [INFO] [stderr] 23 | fn encode_hex_byte(byte: &u8) -> Result { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/digest.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | / match matched { [INFO] [stderr] 110 | | true => Ok(format!( [INFO] [stderr] 111 | | "{green}Digest match{reset}. calculated:\n\t{green}{actual_digest}{reset}", [INFO] [stderr] 112 | | actual_digest = encode_digest_to_string(actual_digest), [INFO] [stderr] ... | [INFO] [stderr] 123 | | yellow = color::Fg(color::Yellow))) [INFO] [stderr] 124 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 109 | if matched { Ok(format!( [INFO] [stderr] 110 | "{green}Digest match{reset}. calculated:\n\t{green}{actual_digest}{reset}", [INFO] [stderr] 111 | actual_digest = encode_digest_to_string(actual_digest), [INFO] [stderr] 112 | green = color::Fg(color::Green), [INFO] [stderr] 113 | reset = style::Reset)) } else { Err(format!( [INFO] [stderr] 114 | "{bold}Digest mismatch{reset}! expected:\n\t{green}{expected}{reset}\nbut calculated:\n\t{red}{actual}{reset}\nYour data may be {yellow}corrupt{reset} or may have been {red}maliciously altered{reset}. {bold}Beware.{reset}", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/hex.rs:23:26 [INFO] [stderr] | [INFO] [stderr] 23 | fn encode_hex_byte(byte: &u8) -> Result { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/digest.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | / match matched { [INFO] [stderr] 110 | | true => Ok(format!( [INFO] [stderr] 111 | | "{green}Digest match{reset}. calculated:\n\t{green}{actual_digest}{reset}", [INFO] [stderr] 112 | | actual_digest = encode_digest_to_string(actual_digest), [INFO] [stderr] ... | [INFO] [stderr] 123 | | yellow = color::Fg(color::Yellow))) [INFO] [stderr] 124 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 109 | if matched { Ok(format!( [INFO] [stderr] 110 | "{green}Digest match{reset}. calculated:\n\t{green}{actual_digest}{reset}", [INFO] [stderr] 111 | actual_digest = encode_digest_to_string(actual_digest), [INFO] [stderr] 112 | green = color::Fg(color::Green), [INFO] [stderr] 113 | reset = style::Reset)) } else { Err(format!( [INFO] [stderr] 114 | "{bold}Digest mismatch{reset}! expected:\n\t{green}{expected}{reset}\nbut calculated:\n\t{red}{actual}{reset}\nYour data may be {yellow}corrupt{reset} or may have been {red}maliciously altered{reset}. {bold}Beware.{reset}", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.71s [INFO] running `"docker" "inspect" "18ecda7edfcb3fadf9a56bafeab5bc13c4f78c5c34d88def5d83330b7d5a09fa"` [INFO] running `"docker" "rm" "-f" "18ecda7edfcb3fadf9a56bafeab5bc13c4f78c5c34d88def5d83330b7d5a09fa"` [INFO] [stdout] 18ecda7edfcb3fadf9a56bafeab5bc13c4f78c5c34d88def5d83330b7d5a09fa