[INFO] updating cached repository ocelotconsulting/prjs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ocelotconsulting/prjs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ocelotconsulting/prjs" "work/ex/clippy-test-run/sources/stable/gh/ocelotconsulting/prjs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ocelotconsulting/prjs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ocelotconsulting/prjs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ocelotconsulting/prjs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ocelotconsulting/prjs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3717a41fe049fce012fdf97dc6433d04ec55f01d [INFO] sha for GitHub repo ocelotconsulting/prjs: 3717a41fe049fce012fdf97dc6433d04ec55f01d [INFO] validating manifest of ocelotconsulting/prjs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ocelotconsulting/prjs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ocelotconsulting/prjs [INFO] finished frobbing ocelotconsulting/prjs [INFO] frobbed toml for ocelotconsulting/prjs written to work/ex/clippy-test-run/sources/stable/gh/ocelotconsulting/prjs/Cargo.toml [INFO] started frobbing ocelotconsulting/prjs [INFO] finished frobbing ocelotconsulting/prjs [INFO] frobbed toml for ocelotconsulting/prjs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ocelotconsulting/prjs/Cargo.toml [INFO] crate ocelotconsulting/prjs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ocelotconsulting/prjs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ocelotconsulting/prjs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ea6104db9a1d12cbda27988805572efab4b3d2605277d438a1d02cf9874e358b [INFO] running `"docker" "start" "-a" "ea6104db9a1d12cbda27988805572efab4b3d2605277d438a1d02cf9874e358b"` [INFO] [stderr] Checking time v0.1.39 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking prjs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: for loop over `entry.path().to_str()`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/main.rs:49:35 [INFO] [stderr] | [INFO] [stderr] 49 | for child_path in entry.path().to_str() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::for_loop_over_option)] on by default [INFO] [stderr] = help: consider replacing `for child_path in entry.path().to_str()` with `if let Some(child_path) = entry.path().to_str()` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] error: for loop over `entry.path().to_str()`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/main.rs:81:24 [INFO] [stderr] | [INFO] [stderr] 81 | for path_string in entry.path().to_str() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for path_string in entry.path().to_str()` with `if let Some(path_string) = entry.path().to_str()` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] error: for loop over `to_project(&entry)?`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/main.rs:96:32 [INFO] [stderr] | [INFO] [stderr] 96 | for project in to_project(&entry)? { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for project in to_project(&entry)?` with `if let Some(project) = to_project(&entry)?` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] error: for loop over `path.to_str()`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/main.rs:101:36 [INFO] [stderr] | [INFO] [stderr] 101 | for path_string in path.to_str() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for path_string in path.to_str()` with `if let Some(path_string) = path.to_str()` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `prjs`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: for loop over `entry.path().to_str()`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/main.rs:49:35 [INFO] [stderr] | [INFO] [stderr] 49 | for child_path in entry.path().to_str() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::for_loop_over_option)] on by default [INFO] [stderr] = help: consider replacing `for child_path in entry.path().to_str()` with `if let Some(child_path) = entry.path().to_str()` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] error: for loop over `entry.path().to_str()`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/main.rs:81:24 [INFO] [stderr] | [INFO] [stderr] 81 | for path_string in entry.path().to_str() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for path_string in entry.path().to_str()` with `if let Some(path_string) = entry.path().to_str()` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] error: for loop over `to_project(&entry)?`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/main.rs:96:32 [INFO] [stderr] | [INFO] [stderr] 96 | for project in to_project(&entry)? { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for project in to_project(&entry)?` with `if let Some(project) = to_project(&entry)?` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] error: for loop over `path.to_str()`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/main.rs:101:36 [INFO] [stderr] | [INFO] [stderr] 101 | for path_string in path.to_str() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for path_string in path.to_str()` with `if let Some(path_string) = path.to_str()` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `prjs`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "ea6104db9a1d12cbda27988805572efab4b3d2605277d438a1d02cf9874e358b"` [INFO] running `"docker" "rm" "-f" "ea6104db9a1d12cbda27988805572efab4b3d2605277d438a1d02cf9874e358b"` [INFO] [stdout] ea6104db9a1d12cbda27988805572efab4b3d2605277d438a1d02cf9874e358b