[INFO] updating cached repository obrok/piston_test [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/obrok/piston_test [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/obrok/piston_test" "work/ex/clippy-test-run/sources/stable/gh/obrok/piston_test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/obrok/piston_test'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/obrok/piston_test" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/obrok/piston_test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/obrok/piston_test'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4360c9bce321bc70ee042b7534228aea3b2200ab [INFO] sha for GitHub repo obrok/piston_test: 4360c9bce321bc70ee042b7534228aea3b2200ab [INFO] validating manifest of obrok/piston_test on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of obrok/piston_test on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing obrok/piston_test [INFO] finished frobbing obrok/piston_test [INFO] frobbed toml for obrok/piston_test written to work/ex/clippy-test-run/sources/stable/gh/obrok/piston_test/Cargo.toml [INFO] started frobbing obrok/piston_test [INFO] finished frobbing obrok/piston_test [INFO] frobbed toml for obrok/piston_test written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/obrok/piston_test/Cargo.toml [INFO] crate obrok/piston_test has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting obrok/piston_test against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/obrok/piston_test:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 66f136c3e036cf0e6fd47a61d02d8893f4f9977c6cf1d05d381c54fd2ec2ed49 [INFO] running `"docker" "start" "-a" "66f136c3e036cf0e6fd47a61d02d8893f4f9977c6cf1d05d381c54fd2ec2ed49"` [INFO] [stderr] Compiling khronos_api v2.1.0 [INFO] [stderr] Checking memmap v0.6.2 [INFO] [stderr] Checking shared_library v0.1.8 [INFO] [stderr] Checking stb_truetype v0.2.2 [INFO] [stderr] Checking crossbeam-epoch v0.3.0 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking ordered-float v0.5.0 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Checking uuid v0.1.18 [INFO] [stderr] Checking x11-dl v2.17.3 [INFO] [stderr] Checking gfx_core v0.8.2 [INFO] [stderr] Compiling gl_generator v0.8.0 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking rusttype v0.4.1 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Checking rayon v1.0.0 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Compiling glutin v0.12.2 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Checking pistoncore-window v0.31.0 [INFO] [stderr] Checking piston-ai_behavior v0.22.0 [INFO] [stderr] Checking pistoncore-event_loop v0.36.0 [INFO] [stderr] Checking piston2d-sprite v0.43.0 [INFO] [stderr] Checking wayland-window v0.13.2 [INFO] [stderr] Checking piston v0.36.0 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking winit v0.10.0 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.45.2 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.1 [INFO] [stderr] Checking piston-gfx_texture v0.31.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.50.0 [INFO] [stderr] Checking piston_window v0.77.0 [INFO] [stderr] Checking piston_test v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/mod.rs:127:17 [INFO] [stderr] | [INFO] [stderr] 127 | player: player, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `player` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/mod.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | player: player, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `player` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/mod.rs:127:17 [INFO] [stderr] | [INFO] [stderr] 127 | player: player, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `player` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/mod.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | player: player, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `player` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::Game` [INFO] [stderr] --> src/game/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Game { [INFO] [stderr] 18 | | Game::InProgress(InProgressGame::new()) [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | impl Default for game::Game { [INFO] [stderr] 17 | fn default() -> Self { [INFO] [stderr] 18 | Self::new() [INFO] [stderr] 19 | } [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/game/mod.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match self { [INFO] [stderr] 42 | | &Game::Lost(_) => None, [INFO] [stderr] 43 | | &Game::InProgress(ref game) => Some(game), [INFO] [stderr] 44 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 41 | match *self { [INFO] [stderr] 42 | Game::Lost(_) => None, [INFO] [stderr] 43 | Game::InProgress(ref game) => Some(game), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::InProgressGame` [INFO] [stderr] --> src/game/mod.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / pub fn new() -> InProgressGame { [INFO] [stderr] 72 | | InProgressGame { [INFO] [stderr] 73 | | player: Position { [INFO] [stderr] 74 | | x: XPosition::middle(), [INFO] [stderr] ... | [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 70 | impl Default for game::InProgressGame { [INFO] [stderr] 71 | fn default() -> Self { [INFO] [stderr] 72 | Self::new() [INFO] [stderr] 73 | } [INFO] [stderr] 74 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/mod.rs:185:13 [INFO] [stderr] | [INFO] [stderr] 185 | fn left(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/game/mod.rs:186:12 [INFO] [stderr] | [INFO] [stderr] 186 | if self.0 <= 0 { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using self.0 == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/mod.rs:193:14 [INFO] [stderr] | [INFO] [stderr] 193 | fn right(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/mod.rs:214:13 [INFO] [stderr] | [INFO] [stderr] 214 | fn down(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/game/mod.rs:215:12 [INFO] [stderr] | [INFO] [stderr] 215 | if self.0 <= 0 { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using self.0 == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `piston_test`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::Game` [INFO] [stderr] --> src/game/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Game { [INFO] [stderr] 18 | | Game::InProgress(InProgressGame::new()) [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | impl Default for game::Game { [INFO] [stderr] 17 | fn default() -> Self { [INFO] [stderr] 18 | Self::new() [INFO] [stderr] 19 | } [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/game/mod.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match self { [INFO] [stderr] 42 | | &Game::Lost(_) => None, [INFO] [stderr] 43 | | &Game::InProgress(ref game) => Some(game), [INFO] [stderr] 44 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 41 | match *self { [INFO] [stderr] 42 | Game::Lost(_) => None, [INFO] [stderr] 43 | Game::InProgress(ref game) => Some(game), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::InProgressGame` [INFO] [stderr] --> src/game/mod.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / pub fn new() -> InProgressGame { [INFO] [stderr] 72 | | InProgressGame { [INFO] [stderr] 73 | | player: Position { [INFO] [stderr] 74 | | x: XPosition::middle(), [INFO] [stderr] ... | [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 70 | impl Default for game::InProgressGame { [INFO] [stderr] 71 | fn default() -> Self { [INFO] [stderr] 72 | Self::new() [INFO] [stderr] 73 | } [INFO] [stderr] 74 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/mod.rs:185:13 [INFO] [stderr] | [INFO] [stderr] 185 | fn left(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/game/mod.rs:186:12 [INFO] [stderr] | [INFO] [stderr] 186 | if self.0 <= 0 { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using self.0 == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/mod.rs:193:14 [INFO] [stderr] | [INFO] [stderr] 193 | fn right(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/mod.rs:214:13 [INFO] [stderr] | [INFO] [stderr] 214 | fn down(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/game/mod.rs:215:12 [INFO] [stderr] | [INFO] [stderr] 215 | if self.0 <= 0 { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using self.0 == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `piston_test`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "66f136c3e036cf0e6fd47a61d02d8893f4f9977c6cf1d05d381c54fd2ec2ed49"` [INFO] running `"docker" "rm" "-f" "66f136c3e036cf0e6fd47a61d02d8893f4f9977c6cf1d05d381c54fd2ec2ed49"` [INFO] [stdout] 66f136c3e036cf0e6fd47a61d02d8893f4f9977c6cf1d05d381c54fd2ec2ed49