[INFO] updating cached repository oblique/docker-guard [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/oblique/docker-guard [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/oblique/docker-guard" "work/ex/clippy-test-run/sources/stable/gh/oblique/docker-guard"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/oblique/docker-guard'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/oblique/docker-guard" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/oblique/docker-guard"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/oblique/docker-guard'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 34dc8eb36b44c7faec1e870998f07ba1f3ae1d62 [INFO] sha for GitHub repo oblique/docker-guard: 34dc8eb36b44c7faec1e870998f07ba1f3ae1d62 [INFO] validating manifest of oblique/docker-guard on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of oblique/docker-guard on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing oblique/docker-guard [INFO] finished frobbing oblique/docker-guard [INFO] frobbed toml for oblique/docker-guard written to work/ex/clippy-test-run/sources/stable/gh/oblique/docker-guard/Cargo.toml [INFO] started frobbing oblique/docker-guard [INFO] finished frobbing oblique/docker-guard [INFO] frobbed toml for oblique/docker-guard written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/oblique/docker-guard/Cargo.toml [INFO] crate oblique/docker-guard has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting oblique/docker-guard against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/oblique/docker-guard:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d503dd397910d19fa82342448b9bcd50c92506090149953d351c29edd68f6361 [INFO] running `"docker" "start" "-a" "d503dd397910d19fa82342448b9bcd50c92506090149953d351c29edd68f6361"` [INFO] [stderr] Checking rust-ini v0.12.2 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking serde_test v0.8.23 [INFO] [stderr] Checking epoll v4.0.0 [INFO] [stderr] Checking nom v4.0.0 [INFO] [stderr] Checking serde_json v1.0.22 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking error-chain v0.12.0 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking linked-hash-map v0.3.0 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking serde-hjson v0.8.1 [INFO] [stderr] Checking config v0.9.0 [INFO] [stderr] Checking docker-guard v0.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | docker_host: docker_host, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `docker_host` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | env_whitelist: env_whitelist, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `env_whitelist` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | docker_host: docker_host, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `docker_host` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | env_whitelist: env_whitelist, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `env_whitelist` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:325:20 [INFO] [stderr] | [INFO] [stderr] 325 | } else if fd == stream2.as_raw_fd() { [INFO] [stderr] | ____________________^ [INFO] [stderr] 326 | | if forward_data(stream2.as_read_mut(), stream1.as_write_mut())? == 0 { [INFO] [stderr] 327 | | break 'outer; [INFO] [stderr] 328 | | } [INFO] [stderr] 329 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 325 | } else if fd == stream2.as_raw_fd() && forward_data(stream2.as_read_mut(), stream1.as_write_mut())? == 0 { [INFO] [stderr] 326 | break 'outer; [INFO] [stderr] 327 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:325:20 [INFO] [stderr] | [INFO] [stderr] 325 | } else if fd == stream2.as_raw_fd() { [INFO] [stderr] | ____________________^ [INFO] [stderr] 326 | | if forward_data(stream2.as_read_mut(), stream1.as_write_mut())? == 0 { [INFO] [stderr] 327 | | break 'outer; [INFO] [stderr] 328 | | } [INFO] [stderr] 329 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 325 | } else if fd == stream2.as_raw_fd() && forward_data(stream2.as_read_mut(), stream1.as_write_mut())? == 0 { [INFO] [stderr] 326 | break 'outer; [INFO] [stderr] 327 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/config.rs:31:31 [INFO] [stderr] | [INFO] [stderr] 31 | Some(envs) => envs.into_iter().map(|x| x.to_owned()).collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `envs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/config.rs:73:50 [INFO] [stderr] | [INFO] [stderr] 73 | pub fn match_http_path(&self, path: &str) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/main.rs:116:16 [INFO] [stderr] | [INFO] [stderr] 116 | if let Ok(_) = res.parse(&http) { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 117 | | return Ok(Http::Res(res)); [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________- help: try this: `if res.parse(&http).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/main.rs:123:12 [INFO] [stderr] | [INFO] [stderr] 123 | if let Ok(_) = req.parse(&http) { [INFO] [stderr] | _____- ^^^^^ [INFO] [stderr] 124 | | return Ok(Http::Req(req)); [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____- help: try this: `if req.parse(&http).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:245:8 [INFO] [stderr] | [INFO] [stderr] 245 | if content.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!content.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/config.rs:31:31 [INFO] [stderr] | [INFO] [stderr] 31 | Some(envs) => envs.into_iter().map(|x| x.to_owned()).collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `envs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/config.rs:73:50 [INFO] [stderr] | [INFO] [stderr] 73 | pub fn match_http_path(&self, path: &str) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/main.rs:116:16 [INFO] [stderr] | [INFO] [stderr] 116 | if let Ok(_) = res.parse(&http) { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 117 | | return Ok(Http::Res(res)); [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________- help: try this: `if res.parse(&http).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/main.rs:123:12 [INFO] [stderr] | [INFO] [stderr] 123 | if let Ok(_) = req.parse(&http) { [INFO] [stderr] | _____- ^^^^^ [INFO] [stderr] 124 | | return Ok(Http::Req(req)); [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____- help: try this: `if req.parse(&http).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:245:8 [INFO] [stderr] | [INFO] [stderr] 245 | if content.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!content.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.31s [INFO] running `"docker" "inspect" "d503dd397910d19fa82342448b9bcd50c92506090149953d351c29edd68f6361"` [INFO] running `"docker" "rm" "-f" "d503dd397910d19fa82342448b9bcd50c92506090149953d351c29edd68f6361"` [INFO] [stdout] d503dd397910d19fa82342448b9bcd50c92506090149953d351c29edd68f6361