[INFO] updating cached repository obaiyan/barragekyi [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/obaiyan/barragekyi [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/obaiyan/barragekyi" "work/ex/clippy-test-run/sources/stable/gh/obaiyan/barragekyi"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/obaiyan/barragekyi'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/obaiyan/barragekyi" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/obaiyan/barragekyi"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/obaiyan/barragekyi'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7529c813230fe12d778269e21967d77c80bda286 [INFO] sha for GitHub repo obaiyan/barragekyi: 7529c813230fe12d778269e21967d77c80bda286 [INFO] validating manifest of obaiyan/barragekyi on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of obaiyan/barragekyi on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing obaiyan/barragekyi [INFO] finished frobbing obaiyan/barragekyi [INFO] frobbed toml for obaiyan/barragekyi written to work/ex/clippy-test-run/sources/stable/gh/obaiyan/barragekyi/Cargo.toml [INFO] started frobbing obaiyan/barragekyi [INFO] finished frobbing obaiyan/barragekyi [INFO] frobbed toml for obaiyan/barragekyi written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/obaiyan/barragekyi/Cargo.toml [INFO] crate obaiyan/barragekyi has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting obaiyan/barragekyi against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/obaiyan/barragekyi:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 15927d46588fc32d042fc02938a146e45c8420a99f81dcaf0e692f3067944b04 [INFO] running `"docker" "start" "-a" "15927d46588fc32d042fc02938a146e45c8420a99f81dcaf0e692f3067944b04"` [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking tokio-service v0.1.0 [INFO] [stderr] Checking relay v0.1.0 [INFO] [stderr] Checking bytes v0.4.5 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking tokio-io v0.1.4 [INFO] [stderr] Checking regex v0.2.5 [INFO] [stderr] Checking tokio-core v0.1.11 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking hyper v0.11.11 [INFO] [stderr] Checking barragekyi v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/client/barrage_client.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | print!("]\r\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/barrage_client.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | room_id: room_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `room_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/barrage_client.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | barrage_address: barrage_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `barrage_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/message.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | room_id: room_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `room_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/client/message.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | print!("]\r\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/message.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | room_id: room_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `room_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/client/message.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | print!("]\r\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/model.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | number: number, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/client/barrage_client.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | print!("]\r\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/barrage_client.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | room_id: room_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `room_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/barrage_client.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | barrage_address: barrage_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `barrage_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/message.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | room_id: room_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `room_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/client/message.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | print!("]\r\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/message.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | room_id: room_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `room_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/client/message.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | print!("]\r\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/model.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | number: number, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/client/barrage_client.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Arc`, `Mutex` [INFO] [stderr] --> src/client/barrage_client.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | use std::sync::{Arc, Mutex}; [INFO] [stderr] | ^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/barrage_client.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | return real_room_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `real_room_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/message.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / return EnterRoomMessage { [INFO] [stderr] 16 | | room_id: room_id, [INFO] [stderr] 17 | | uid: 155973685728160, [INFO] [stderr] 18 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 15 | EnterRoomMessage { [INFO] [stderr] 16 | room_id: room_id, [INFO] [stderr] 17 | uid: 155973685728160, [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/client/message.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | uid: 155973685728160, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `155_973_685_728_160` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/message.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | return data; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/message.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | / return BeatMessage { [INFO] [stderr] 57 | | room_id: room_id, [INFO] [stderr] 58 | | uid: 0, [INFO] [stderr] 59 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 56 | BeatMessage { [INFO] [stderr] 57 | room_id: room_id, [INFO] [stderr] 58 | uid: 0, [INFO] [stderr] 59 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/message.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | return data; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/client/barrage_client.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Arc`, `Mutex` [INFO] [stderr] --> src/client/barrage_client.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | use std::sync::{Arc, Mutex}; [INFO] [stderr] | ^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/barrage_client.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | return real_room_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `real_room_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/model.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | return model; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/model.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | return data.command == "DANMU_MSG"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `data.command == "DANMU_MSG"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/model.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | return data.command == "SEND_GIFT"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `data.command == "SEND_GIFT"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/model.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | / return GeneralBarrage { [INFO] [stderr] 55 | | user: user.to_string(), [INFO] [stderr] 56 | | text: text.to_string(), [INFO] [stderr] 57 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 54 | GeneralBarrage { [INFO] [stderr] 55 | user: user.to_string(), [INFO] [stderr] 56 | text: text.to_string(), [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/model.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | / return GiftBarrage { [INFO] [stderr] 83 | | user: user.to_string(), [INFO] [stderr] 84 | | gift_name: gift_name.to_string(), [INFO] [stderr] 85 | | number: number, [INFO] [stderr] 86 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 82 | GiftBarrage { [INFO] [stderr] 83 | user: user.to_string(), [INFO] [stderr] 84 | gift_name: gift_name.to_string(), [INFO] [stderr] 85 | number: number, [INFO] [stderr] 86 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/message.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / return EnterRoomMessage { [INFO] [stderr] 16 | | room_id: room_id, [INFO] [stderr] 17 | | uid: 155973685728160, [INFO] [stderr] 18 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 15 | EnterRoomMessage { [INFO] [stderr] 16 | room_id: room_id, [INFO] [stderr] 17 | uid: 155973685728160, [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/client/message.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | uid: 155973685728160, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `155_973_685_728_160` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/message.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | return data; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/message.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | / return BeatMessage { [INFO] [stderr] 57 | | room_id: room_id, [INFO] [stderr] 58 | | uid: 0, [INFO] [stderr] 59 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 56 | BeatMessage { [INFO] [stderr] 57 | room_id: room_id, [INFO] [stderr] 58 | uid: 0, [INFO] [stderr] 59 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/message.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | return data; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/model.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | return model; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/model.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | return data.command == "DANMU_MSG"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `data.command == "DANMU_MSG"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/model.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | return data.command == "SEND_GIFT"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `data.command == "SEND_GIFT"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/model.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | / return GeneralBarrage { [INFO] [stderr] 55 | | user: user.to_string(), [INFO] [stderr] 56 | | text: text.to_string(), [INFO] [stderr] 57 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 54 | GeneralBarrage { [INFO] [stderr] 55 | user: user.to_string(), [INFO] [stderr] 56 | text: text.to_string(), [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/model.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | / return GiftBarrage { [INFO] [stderr] 83 | | user: user.to_string(), [INFO] [stderr] 84 | | gift_name: gift_name.to_string(), [INFO] [stderr] 85 | | number: number, [INFO] [stderr] 86 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 82 | GiftBarrage { [INFO] [stderr] 83 | user: user.to_string(), [INFO] [stderr] 84 | gift_name: gift_name.to_string(), [INFO] [stderr] 85 | number: number, [INFO] [stderr] 86 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `handler` [INFO] [stderr] --> src/client/barrage_client.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | let handler = thread::spawn(move || { [INFO] [stderr] | ^^^^^^^ help: consider using `_handler` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `message` [INFO] [stderr] --> src/client/barrage_client.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | let mut message = receiver.recv().unwrap(); [INFO] [stderr] | ^^^^^^^ help: consider using `_message` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `handler` [INFO] [stderr] --> src/client/barrage_client.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | let handler = thread::spawn(move || { [INFO] [stderr] | ^^^^^^^ help: consider using `_handler` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `message` [INFO] [stderr] --> src/client/barrage_client.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | let mut message = receiver.recv().unwrap(); [INFO] [stderr] | ^^^^^^^ help: consider using `_message` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/client/barrage_client.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | let mut message = receiver.recv().unwrap(); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/client/barrage_client.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | let mut message = receiver.recv().unwrap(); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `print_bytes` [INFO] [stderr] --> src/client/barrage_client.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | fn print_bytes(data: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `print_hello` [INFO] [stderr] --> src/client/barrage_client.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | fn print_hello(&self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/client/barrage_client.rs:21:22 [INFO] [stderr] | [INFO] [stderr] 21 | fn print_bytes(data: &Vec) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: function is never used: `print_bytes` [INFO] [stderr] --> src/client/barrage_client.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | fn print_bytes(data: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `print_hello` [INFO] [stderr] --> src/client/barrage_client.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | fn print_hello(&self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/client/barrage_client.rs:21:22 [INFO] [stderr] | [INFO] [stderr] 21 | fn print_bytes(data: &Vec) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/client/barrage_client.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | / self.stream [INFO] [stderr] 233 | | .as_ref() [INFO] [stderr] 234 | | .unwrap() [INFO] [stderr] 235 | | .write(&message.to_bytes().as_slice()) [INFO] [stderr] 236 | | .unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/client/barrage_client.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | / self.stream [INFO] [stderr] 233 | | .as_ref() [INFO] [stderr] 234 | | .unwrap() [INFO] [stderr] 235 | | .write(&message.to_bytes().as_slice()) [INFO] [stderr] 236 | | .unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: empty `loop {}` detected. You may want to either use `panic!()` or add `std::thread::sleep(..);` to the loop body. [INFO] [stderr] --> src/main.rs:23:3 [INFO] [stderr] | [INFO] [stderr] 23 | loop {} [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::empty_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop [INFO] [stderr] [INFO] [stderr] warning: empty `loop {}` detected. You may want to either use `panic!()` or add `std::thread::sleep(..);` to the loop body. [INFO] [stderr] --> src/main.rs:23:3 [INFO] [stderr] | [INFO] [stderr] 23 | loop {} [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::empty_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `barragekyi`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Could not compile `barragekyi`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "15927d46588fc32d042fc02938a146e45c8420a99f81dcaf0e692f3067944b04"` [INFO] running `"docker" "rm" "-f" "15927d46588fc32d042fc02938a146e45c8420a99f81dcaf0e692f3067944b04"` [INFO] [stdout] 15927d46588fc32d042fc02938a146e45c8420a99f81dcaf0e692f3067944b04