[INFO] updating cached repository o2sh/onefetch [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/o2sh/onefetch [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/o2sh/onefetch" "work/ex/clippy-test-run/sources/stable/gh/o2sh/onefetch"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/o2sh/onefetch'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/o2sh/onefetch" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/o2sh/onefetch"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/o2sh/onefetch'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e79e867a7fc44e55736fb41dacadc9ad83ccf20a [INFO] sha for GitHub repo o2sh/onefetch: e79e867a7fc44e55736fb41dacadc9ad83ccf20a [INFO] validating manifest of o2sh/onefetch on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of o2sh/onefetch on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing o2sh/onefetch [INFO] finished frobbing o2sh/onefetch [INFO] frobbed toml for o2sh/onefetch written to work/ex/clippy-test-run/sources/stable/gh/o2sh/onefetch/Cargo.toml [INFO] started frobbing o2sh/onefetch [INFO] finished frobbing o2sh/onefetch [INFO] frobbed toml for o2sh/onefetch written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/o2sh/onefetch/Cargo.toml [INFO] crate o2sh/onefetch has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting o2sh/onefetch against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/o2sh/onefetch:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e2653d6452643d1769ff8c79f8e88129170f38568041267bc181cfd508e375c4 [INFO] running `"docker" "start" "-a" "e2653d6452643d1769ff8c79f8e88129170f38568041267bc181cfd508e375c4"` [INFO] [stderr] Compiling stable_deref_trait v1.1.1 [INFO] [stderr] Compiling crossbeam-utils v0.5.0 [INFO] [stderr] Compiling same-file v1.0.3 [INFO] [stderr] Compiling fnv v1.0.6 [INFO] [stderr] Checking term_size v0.3.1 [INFO] [stderr] Compiling libz-sys v1.0.23 [INFO] [stderr] Compiling libgit2-sys v0.7.10 [INFO] [stderr] Checking encoding_rs_io v0.1.3 [INFO] [stderr] Compiling lazy_static v1.1.0 [INFO] [stderr] Compiling memchr v2.1.0 [INFO] [stderr] Compiling serde_json v1.0.31 [INFO] [stderr] Compiling owning_ref v0.3.3 [INFO] [stderr] Compiling walkdir v2.2.5 [INFO] [stderr] Compiling thread_local v0.3.6 [INFO] [stderr] Compiling crossbeam-epoch v0.6.0 [INFO] [stderr] Compiling parking_lot_core v0.3.1 [INFO] [stderr] Checking license v0.7.1 [INFO] [stderr] Compiling lock_api v0.1.4 [INFO] [stderr] Checking globset v0.4.2 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Compiling aho-corasick v0.6.8 [INFO] [stderr] Compiling regex v1.0.5 [INFO] [stderr] Compiling parking_lot v0.6.4 [INFO] [stderr] Checking ignore v0.4.4 [INFO] [stderr] Compiling handlebars v1.0.4 [INFO] [stderr] Compiling tokei v8.0.1 [INFO] [stderr] Checking git2 v0.7.5 [INFO] [stderr] Checking onefetch v1.0.5 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:118:52 [INFO] [stderr] | [INFO] [stderr] 118 | let mut colors_in_str: Vec = line.split("{").fold(Vec::new(), |mut acc, s| { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/main.rs:121:23 [INFO] [stderr] | [INFO] [stderr] 121 | acc.push(*colors.iter().nth(i as usize).unwrap_or(&Color::White)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_nth)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:135:30 [INFO] [stderr] | [INFO] [stderr] 135 | let out_str = line.split("{").fold(String::new(), |mut acc, s| { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:152:16 [INFO] [stderr] | [INFO] [stderr] 152 | line.split("{") [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:118:52 [INFO] [stderr] | [INFO] [stderr] 118 | let mut colors_in_str: Vec = line.split("{").fold(Vec::new(), |mut acc, s| { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/main.rs:121:23 [INFO] [stderr] | [INFO] [stderr] 121 | acc.push(*colors.iter().nth(i as usize).unwrap_or(&Color::White)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_nth)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:135:30 [INFO] [stderr] | [INFO] [stderr] 135 | let out_str = line.split("{").fold(String::new(), |mut acc, s| { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:152:16 [INFO] [stderr] | [INFO] [stderr] 152 | line.split("{") [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 49.35s [INFO] running `"docker" "inspect" "e2653d6452643d1769ff8c79f8e88129170f38568041267bc181cfd508e375c4"` [INFO] running `"docker" "rm" "-f" "e2653d6452643d1769ff8c79f8e88129170f38568041267bc181cfd508e375c4"` [INFO] [stdout] e2653d6452643d1769ff8c79f8e88129170f38568041267bc181cfd508e375c4