[INFO] updating cached repository o2sh/add-one
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/o2sh/add-one
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/o2sh/add-one" "work/ex/clippy-test-run/sources/stable/gh/o2sh/add-one"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/o2sh/add-one'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/o2sh/add-one" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/o2sh/add-one"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/o2sh/add-one'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 31b1f696840c5e32e2a7c9d85c56ffead9c418bc
[INFO] sha for GitHub repo o2sh/add-one: 31b1f696840c5e32e2a7c9d85c56ffead9c418bc
[INFO] validating manifest of o2sh/add-one on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of o2sh/add-one on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing o2sh/add-one
[INFO] finished frobbing o2sh/add-one
[INFO] frobbed toml for o2sh/add-one written to work/ex/clippy-test-run/sources/stable/gh/o2sh/add-one/Cargo.toml
[INFO] started frobbing o2sh/add-one
[INFO] finished frobbing o2sh/add-one
[INFO] frobbed toml for o2sh/add-one written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/o2sh/add-one/Cargo.toml
[INFO] crate o2sh/add-one has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting o2sh/add-one against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/o2sh/add-one:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] fa88f6373913e96f93256c7c8846ad69ff626a312aca02352a9b32670d1bb46d
[INFO] running `"docker" "start" "-a" "fa88f6373913e96f93256c7c8846ad69ff626a312aca02352a9b32670d1bb46d"`
[INFO] [stderr]     Checking add-one v1.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:45:65
[INFO] [stderr]    |
[INFO] [stderr] 45 |     let digits = &digits[digits.iter().position(|&c| c != b'0').unwrap_or(digits.len())..];
[INFO] [stderr]    |                                                                 ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| digits.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:47:52
[INFO] [stderr]    |
[INFO] [stderr] 47 |     let z = digits.iter().position(|&c| c == b'.').unwrap_or(digits.len()); // position of decimal
[INFO] [stderr]    |                                                    ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| digits.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/lib.rs:75:24
[INFO] [stderr]    |
[INFO] [stderr] 75 |     } else if minus && digits.len() > 0 && digits[0] == b'.' && !digits[1..].iter().all(|&d| d == b'0') {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!digits.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/lib.rs:91:16
[INFO] [stderr]    |
[INFO] [stderr] 91 |           if let Some(_) = iter.peek() {
[INFO] [stderr]    |  _________-      ^^^^^^^
[INFO] [stderr] 92 | |             decimal_digits.push(b'9' - *iter.next().unwrap() + b'0' + 1);
[INFO] [stderr] 93 | |         }
[INFO] [stderr]    | |_________- help: try this: `if iter.peek().is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:45:65
[INFO] [stderr]    |
[INFO] [stderr] 45 |     let digits = &digits[digits.iter().position(|&c| c != b'0').unwrap_or(digits.len())..];
[INFO] [stderr]    |                                                                 ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| digits.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:47:52
[INFO] [stderr]    |
[INFO] [stderr] 47 |     let z = digits.iter().position(|&c| c == b'.').unwrap_or(digits.len()); // position of decimal
[INFO] [stderr]    |                                                    ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| digits.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/lib.rs:75:24
[INFO] [stderr]    |
[INFO] [stderr] 75 |     } else if minus && digits.len() > 0 && digits[0] == b'.' && !digits[1..].iter().all(|&d| d == b'0') {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!digits.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/lib.rs:91:16
[INFO] [stderr]    |
[INFO] [stderr] 91 |           if let Some(_) = iter.peek() {
[INFO] [stderr]    |  _________-      ^^^^^^^
[INFO] [stderr] 92 | |             decimal_digits.push(b'9' - *iter.next().unwrap() + b'0' + 1);
[INFO] [stderr] 93 | |         }
[INFO] [stderr]    | |_________- help: try this: `if iter.peek().is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.38s
[INFO] running `"docker" "inspect" "fa88f6373913e96f93256c7c8846ad69ff626a312aca02352a9b32670d1bb46d"`
[INFO] running `"docker" "rm" "-f" "fa88f6373913e96f93256c7c8846ad69ff626a312aca02352a9b32670d1bb46d"`
[INFO] [stdout] fa88f6373913e96f93256c7c8846ad69ff626a312aca02352a9b32670d1bb46d