[INFO] updating cached repository nykh/zeppelin2jupyter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nykh/zeppelin2jupyter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nykh/zeppelin2jupyter" "work/ex/clippy-test-run/sources/stable/gh/nykh/zeppelin2jupyter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nykh/zeppelin2jupyter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nykh/zeppelin2jupyter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nykh/zeppelin2jupyter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nykh/zeppelin2jupyter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f564b7a3adb4da1229800f62dba241bc8a6b615b [INFO] sha for GitHub repo nykh/zeppelin2jupyter: f564b7a3adb4da1229800f62dba241bc8a6b615b [INFO] validating manifest of nykh/zeppelin2jupyter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nykh/zeppelin2jupyter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nykh/zeppelin2jupyter [INFO] finished frobbing nykh/zeppelin2jupyter [INFO] frobbed toml for nykh/zeppelin2jupyter written to work/ex/clippy-test-run/sources/stable/gh/nykh/zeppelin2jupyter/Cargo.toml [INFO] started frobbing nykh/zeppelin2jupyter [INFO] finished frobbing nykh/zeppelin2jupyter [INFO] frobbed toml for nykh/zeppelin2jupyter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nykh/zeppelin2jupyter/Cargo.toml [INFO] crate nykh/zeppelin2jupyter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nykh/zeppelin2jupyter against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nykh/zeppelin2jupyter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3dd7f8a4f40a9a81d9138a321be40827b16c9932c79c47420be0bdbde7b48169 [INFO] running `"docker" "start" "-a" "3dd7f8a4f40a9a81d9138a321be40827b16c9932c79c47420be0bdbde7b48169"` [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking zeppelin2jupyter v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/converter.rs:65:22 [INFO] [stderr] | [INFO] [stderr] 65 | const IMAGE_PREFIX: &'static str = "
src/converter.rs:66:23 [INFO] [stderr] | [INFO] [stderr] 66 | const IMAGE_POSTFIX: &'static str = " style='width=auto;height:auto'>
\n"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:51:40 [INFO] [stderr] | [INFO] [stderr] 51 | Err(e) => { println!("{}", e); () } [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/converter.rs:65:22 [INFO] [stderr] | [INFO] [stderr] 65 | const IMAGE_PREFIX: &'static str = "
src/converter.rs:66:23 [INFO] [stderr] | [INFO] [stderr] 66 | const IMAGE_POSTFIX: &'static str = " style='width=auto;height:auto'>
\n"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:51:40 [INFO] [stderr] | [INFO] [stderr] 51 | Err(e) => { println!("{}", e); () } [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/converter.rs:29:36 [INFO] [stderr] | [INFO] [stderr] 29 | fn write_file(path: &str, content: &String) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/converter.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | buf_writer.write(content.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/converter.rs:62:37 [INFO] [stderr] | [INFO] [stderr] 62 | Value::Array(s2.into_iter().map(|s| Value::String(s)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::String` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/converter.rs:142:38 [INFO] [stderr] | [INFO] [stderr] 142 | let jcells = Value::Array(zcells.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:15:43 [INFO] [stderr] | [INFO] [stderr] 15 | let mut v: Vec<&str> = self.split(".").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:43:18 [INFO] [stderr] | [INFO] [stderr] 43 | .unwrap_or(src.replace_extension("ipynb")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| src.replace_extension("ipynb"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `zeppelin2jupyter`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/converter.rs:29:36 [INFO] [stderr] | [INFO] [stderr] 29 | fn write_file(path: &str, content: &String) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/converter.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | buf_writer.write(content.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/converter.rs:62:37 [INFO] [stderr] | [INFO] [stderr] 62 | Value::Array(s2.into_iter().map(|s| Value::String(s)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::String` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/converter.rs:142:38 [INFO] [stderr] | [INFO] [stderr] 142 | let jcells = Value::Array(zcells.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:15:43 [INFO] [stderr] | [INFO] [stderr] 15 | let mut v: Vec<&str> = self.split(".").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:43:18 [INFO] [stderr] | [INFO] [stderr] 43 | .unwrap_or(src.replace_extension("ipynb")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| src.replace_extension("ipynb"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `zeppelin2jupyter`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "3dd7f8a4f40a9a81d9138a321be40827b16c9932c79c47420be0bdbde7b48169"` [INFO] running `"docker" "rm" "-f" "3dd7f8a4f40a9a81d9138a321be40827b16c9932c79c47420be0bdbde7b48169"` [INFO] [stdout] 3dd7f8a4f40a9a81d9138a321be40827b16c9932c79c47420be0bdbde7b48169