[INFO] updating cached repository nyantec/sensorlog [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nyantec/sensorlog [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nyantec/sensorlog" "work/ex/clippy-test-run/sources/stable/gh/nyantec/sensorlog"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nyantec/sensorlog'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nyantec/sensorlog" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nyantec/sensorlog"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nyantec/sensorlog'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d9b0506bfc05559ea21fbf75cd7d3d394203eca8 [INFO] sha for GitHub repo nyantec/sensorlog: d9b0506bfc05559ea21fbf75cd7d3d394203eca8 [INFO] validating manifest of nyantec/sensorlog on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nyantec/sensorlog on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nyantec/sensorlog [INFO] finished frobbing nyantec/sensorlog [INFO] frobbed toml for nyantec/sensorlog written to work/ex/clippy-test-run/sources/stable/gh/nyantec/sensorlog/Cargo.toml [INFO] started frobbing nyantec/sensorlog [INFO] finished frobbing nyantec/sensorlog [INFO] frobbed toml for nyantec/sensorlog written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nyantec/sensorlog/Cargo.toml [INFO] crate nyantec/sensorlog has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nyantec/sensorlog against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nyantec/sensorlog:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ff18cb0b28e0a35f25172b15c6af52e331f6f5fa7061faaaf77afc0e34c372ac [INFO] running `"docker" "start" "-a" "ff18cb0b28e0a35f25172b15c6af52e331f6f5fa7061faaaf77afc0e34c372ac"` [INFO] [stderr] Checking getopts v0.2.17 [INFO] [stderr] Checking time v0.1.40 [INFO] [stderr] Checking bytes v0.4.7 [INFO] [stderr] Compiling syn v0.13.9 [INFO] [stderr] Checking tokio-io v0.1.6 [INFO] [stderr] Checking tokio-reactor v0.1.1 [INFO] [stderr] Checking tokio-fs v0.1.0 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio-udp v0.1.0 [INFO] [stderr] Checking tokio v0.1.6 [INFO] [stderr] Compiling serde_derive v1.0.55 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking hyper v0.11.26 [INFO] [stderr] Checking sensorlog v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:60:4 [INFO] [stderr] | [INFO] [stderr] 60 | code: code [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:90:3 [INFO] [stderr] | [INFO] [stderr] 90 | measurements: measurements [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `measurements` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http.rs:124:4 [INFO] [stderr] | [INFO] [stderr] 124 | service: service [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `service` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logfile.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | storage_quota: storage_quota, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `storage_quota` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logfile_id.rs:57:4 [INFO] [stderr] | [INFO] [stderr] 57 | file_name: file_name [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logfile_map.rs:49:4 [INFO] [stderr] | [INFO] [stderr] 49 | directory: directory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logfile_map.rs:50:4 [INFO] [stderr] | [INFO] [stderr] 50 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logfile_partition.rs:53:4 [INFO] [stderr] | [INFO] [stderr] 53 | time_head: time_head, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_head` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logfile_partition.rs:54:4 [INFO] [stderr] | [INFO] [stderr] 54 | time_tail: time_tail, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_tail` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logfile_partition.rs:55:4 [INFO] [stderr] | [INFO] [stderr] 55 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logfile_reader.rs:33:4 [INFO] [stderr] | [INFO] [stderr] 33 | partitions: partitions [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `partitions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/measure.rs:78:4 [INFO] [stderr] | [INFO] [stderr] 78 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/measure.rs:79:4 [INFO] [stderr] | [INFO] [stderr] 79 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:43:4 [INFO] [stderr] | [INFO] [stderr] 43 | logfile_map: logfile_map [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `logfile_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:60:4 [INFO] [stderr] | [INFO] [stderr] 60 | code: code [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:90:3 [INFO] [stderr] | [INFO] [stderr] 90 | measurements: measurements [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `measurements` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http.rs:124:4 [INFO] [stderr] | [INFO] [stderr] 124 | service: service [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `service` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logfile.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | storage_quota: storage_quota, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `storage_quota` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logfile_id.rs:57:4 [INFO] [stderr] | [INFO] [stderr] 57 | file_name: file_name [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logfile_map.rs:49:4 [INFO] [stderr] | [INFO] [stderr] 49 | directory: directory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logfile_map.rs:50:4 [INFO] [stderr] | [INFO] [stderr] 50 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logfile_partition.rs:53:4 [INFO] [stderr] | [INFO] [stderr] 53 | time_head: time_head, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_head` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logfile_partition.rs:54:4 [INFO] [stderr] | [INFO] [stderr] 54 | time_tail: time_tail, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_tail` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logfile_partition.rs:55:4 [INFO] [stderr] | [INFO] [stderr] 55 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logfile_reader.rs:33:4 [INFO] [stderr] | [INFO] [stderr] 33 | partitions: partitions [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `partitions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/measure.rs:78:4 [INFO] [stderr] | [INFO] [stderr] 78 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/measure.rs:79:4 [INFO] [stderr] | [INFO] [stderr] 79 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:43:4 [INFO] [stderr] | [INFO] [stderr] 43 | logfile_map: logfile_map [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `logfile_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/error.rs:58:3 [INFO] [stderr] | [INFO] [stderr] 58 | return Error { [INFO] [stderr] | _________^ [INFO] [stderr] 59 | | message: message.to_owned(), [INFO] [stderr] 60 | | code: code [INFO] [stderr] 61 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 58 | Error { [INFO] [stderr] 59 | message: message.to_owned(), [INFO] [stderr] 60 | code: code [INFO] [stderr] 61 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api.rs:51:2 [INFO] [stderr] | [INFO] [stderr] 51 | return Ok(StoreMeasurementResponse { [INFO] [stderr] | _____^ [INFO] [stderr] 52 | | success: true [INFO] [stderr] 53 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 51 | Ok(StoreMeasurementResponse { [INFO] [stderr] 52 | success: true [INFO] [stderr] 53 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api.rs:89:2 [INFO] [stderr] | [INFO] [stderr] 89 | return Ok(FetchMeasurementsResponse{ [INFO] [stderr] | _____^ [INFO] [stderr] 90 | | measurements: measurements [INFO] [stderr] 91 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 89 | Ok(FetchMeasurementsResponse{ [INFO] [stderr] 90 | measurements: measurements [INFO] [stderr] 91 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api_json.rs:41:2 [INFO] [stderr] | [INFO] [stderr] 41 | return Ok(res_json); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res_json)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api_json.rs:50:2 [INFO] [stderr] | [INFO] [stderr] 50 | return match method { [INFO] [stderr] | _____^ [INFO] [stderr] 51 | | "store_measurement" => call(service, &::api::store_measurement, req), [INFO] [stderr] 52 | | "fetch_measurements" => call(service, &::api::fetch_measurements, req), [INFO] [stderr] 53 | | _ => Err(err_user!("invalid API method")) [INFO] [stderr] 54 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 50 | match method { [INFO] [stderr] 51 | "store_measurement" => call(service, &::api::store_measurement, req), [INFO] [stderr] 52 | "fetch_measurements" => call(service, &::api::fetch_measurements, req), [INFO] [stderr] 53 | _ => Err(err_user!("invalid API method")) [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api_json.rs:66:2 [INFO] [stderr] | [INFO] [stderr] 66 | return match method(service, req) { [INFO] [stderr] | _____^ [INFO] [stderr] 67 | | Ok(r) => Ok(json::to_value(r).unwrap()), [INFO] [stderr] 68 | | Err(e) => Err(e) [INFO] [stderr] 69 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 66 | match method(service, req) { [INFO] [stderr] 67 | Ok(r) => Ok(json::to_value(r).unwrap()), [INFO] [stderr] 68 | Err(e) => Err(e) [INFO] [stderr] 69 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:58:2 [INFO] [stderr] | [INFO] [stderr] 58 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:82:2 [INFO] [stderr] | [INFO] [stderr] 82 | return Ok( [INFO] [stderr] | _____^ [INFO] [stderr] 83 | | Response::new() [INFO] [stderr] 84 | | .with_status(StatusCode::NotFound) [INFO] [stderr] 85 | | .with_body("not found")); [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 82 | Ok( [INFO] [stderr] 83 | Response::new() [INFO] [stderr] 84 | .with_status(StatusCode::NotFound) [INFO] [stderr] 85 | .with_body("not found")) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:107:2 [INFO] [stderr] | [INFO] [stderr] 107 | return Ok( [INFO] [stderr] | _____^ [INFO] [stderr] 108 | | Response::new() [INFO] [stderr] 109 | | .with_status(StatusCode::Ok) [INFO] [stderr] 110 | | .with_body(rpc_response)); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 107 | Ok( [INFO] [stderr] 108 | Response::new() [INFO] [stderr] 109 | .with_status(StatusCode::Ok) [INFO] [stderr] 110 | .with_body(rpc_response)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:122:3 [INFO] [stderr] | [INFO] [stderr] 122 | return HTTPHandler { [INFO] [stderr] | _________^ [INFO] [stderr] 123 | | thread_pool: CpuPool::new_num_cpus(), [INFO] [stderr] 124 | | service: service [INFO] [stderr] 125 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 122 | HTTPHandler { [INFO] [stderr] 123 | thread_pool: CpuPool::new_num_cpus(), [INFO] [stderr] 124 | service: service [INFO] [stderr] 125 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:185:3 [INFO] [stderr] | [INFO] [stderr] 185 | return Box::new(res_future); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(res_future)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:182:4 [INFO] [stderr] | [INFO] [stderr] 182 | return futures::future::ok(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `futures::future::ok(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/logfile.rs:32:32 [INFO] [stderr] | [INFO] [stderr] 32 | const TRANSACTION_FILE_NAME : &'static str = "tx.lock"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile.rs:72:3 [INFO] [stderr] | [INFO] [stderr] 72 | return Ok(logfile); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(logfile)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile.rs:109:3 [INFO] [stderr] | [INFO] [stderr] 109 | return Ok(Some(logfile)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(logfile))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile.rs:118:3 [INFO] [stderr] | [INFO] [stderr] 118 | return storage_locked.id.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `storage_locked.id.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile.rs:158:3 [INFO] [stderr] | [INFO] [stderr] 158 | return storage_locked.commit(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `storage_locked.commit()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile.rs:172:3 [INFO] [stderr] | [INFO] [stderr] 172 | return reader.fetch_measurements( [INFO] [stderr] | _________^ [INFO] [stderr] 173 | | time_start, [INFO] [stderr] 174 | | time_limit, [INFO] [stderr] 175 | | limit); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 172 | reader.fetch_measurements( [INFO] [stderr] 173 | time_start, [INFO] [stderr] 174 | time_limit, [INFO] [stderr] 175 | limit) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile.rs:198:3 [INFO] [stderr] | [INFO] [stderr] 198 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile.rs:220:3 [INFO] [stderr] | [INFO] [stderr] 220 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile.rs:240:3 [INFO] [stderr] | [INFO] [stderr] 240 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_id.rs:35:3 [INFO] [stderr] | [INFO] [stderr] 35 | return LogfileID { [INFO] [stderr] | _________^ [INFO] [stderr] 36 | | id: string [INFO] [stderr] 37 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 35 | LogfileID { [INFO] [stderr] 36 | id: string [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_id.rs:41:3 [INFO] [stderr] | [INFO] [stderr] 41 | return self.id.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.id.to_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_id.rs:47:3 [INFO] [stderr] | [INFO] [stderr] 47 | return LogfilePath { [INFO] [stderr] | _________^ [INFO] [stderr] 48 | | file_name: format!("{:x}", id_digest) [INFO] [stderr] 49 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 47 | LogfilePath { [INFO] [stderr] 48 | file_name: format!("{:x}", id_digest) [INFO] [stderr] 49 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_id.rs:56:3 [INFO] [stderr] | [INFO] [stderr] 56 | return LogfilePath { [INFO] [stderr] | _________^ [INFO] [stderr] 57 | | file_name: file_name [INFO] [stderr] 58 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 56 | LogfilePath { [INFO] [stderr] 57 | file_name: file_name [INFO] [stderr] 58 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_id.rs:62:3 [INFO] [stderr] | [INFO] [stderr] 62 | return self.file_name.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.file_name.to_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_config.rs:36:3 [INFO] [stderr] | [INFO] [stderr] 36 | return LogfileConfig { [INFO] [stderr] | _________^ [INFO] [stderr] 37 | | quota_default: StorageQuota::Zero, [INFO] [stderr] 38 | | quota: HashMap::::new(), [INFO] [stderr] 39 | | partition_size_bytes_default: DEFAULT_PARTITION_SIZE_MAX_BYTES [INFO] [stderr] 40 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 36 | LogfileConfig { [INFO] [stderr] 37 | quota_default: StorageQuota::Zero, [INFO] [stderr] 38 | quota: HashMap::::new(), [INFO] [stderr] 39 | partition_size_bytes_default: DEFAULT_PARTITION_SIZE_MAX_BYTES [INFO] [stderr] 40 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_config.rs:44:3 [INFO] [stderr] | [INFO] [stderr] 44 | return self [INFO] [stderr] | _________^ [INFO] [stderr] 45 | | .quota [INFO] [stderr] 46 | | .get(logfile_id) [INFO] [stderr] 47 | | .unwrap_or(&self.quota_default) [INFO] [stderr] 48 | | .clone(); [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 44 | self [INFO] [stderr] 45 | .quota [INFO] [stderr] 46 | .get(logfile_id) [INFO] [stderr] 47 | .unwrap_or(&self.quota_default) [INFO] [stderr] 48 | .clone() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_config.rs:63:3 [INFO] [stderr] | [INFO] [stderr] 63 | return self.partition_size_bytes_default; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.partition_size_bytes_default` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/logfile_directory.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | const DATABASE_PATH : &'static str = "db"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_directory.rs:43:3 [INFO] [stderr] | [INFO] [stderr] 43 | return Ok(logfile_directory); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(logfile_directory)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_directory.rs:59:3 [INFO] [stderr] | [INFO] [stderr] 59 | return Ok(Arc::new(logfile)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Arc::new(logfile))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_directory.rs:74:3 [INFO] [stderr] | [INFO] [stderr] 74 | return Ok(logfile.map(|f| Arc::new(f))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(logfile.map(|f| Arc::new(f)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_directory.rs:87:3 [INFO] [stderr] | [INFO] [stderr] 87 | return Ok(logfiles); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(logfiles)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_map.rs:48:3 [INFO] [stderr] | [INFO] [stderr] 48 | return Ok(LogfileMap { [INFO] [stderr] | _________^ [INFO] [stderr] 49 | | directory: directory, [INFO] [stderr] 50 | | config: config, [INFO] [stderr] 51 | | logfiles: Arc::new(RwLock::new(logfile_map)), [INFO] [stderr] 52 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 48 | Ok(LogfileMap { [INFO] [stderr] 49 | directory: directory, [INFO] [stderr] 50 | config: config, [INFO] [stderr] 51 | logfiles: Arc::new(RwLock::new(logfile_map)), [INFO] [stderr] 52 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_map.rs:61:3 [INFO] [stderr] | [INFO] [stderr] 61 | return logfiles_locked [INFO] [stderr] | _________^ [INFO] [stderr] 62 | | .get(&logfile_id.get_string()) [INFO] [stderr] 63 | | .map(|l| l.clone()); [INFO] [stderr] | |____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 61 | logfiles_locked [INFO] [stderr] 62 | .get(&logfile_id.get_string()) [INFO] [stderr] 63 | .map(|l| l.clone()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_map.rs:89:3 [INFO] [stderr] | [INFO] [stderr] 89 | return Ok(logfile); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(logfile)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_partition.rs:43:3 [INFO] [stderr] | [INFO] [stderr] 43 | return Ok(partition); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(partition)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_partition.rs:51:3 [INFO] [stderr] | [INFO] [stderr] 51 | return LogfilePartition { [INFO] [stderr] | _________^ [INFO] [stderr] 52 | | path: path.to_owned(), [INFO] [stderr] 53 | | time_head: time_head, [INFO] [stderr] 54 | | time_tail: time_tail, [INFO] [stderr] 55 | | offset: offset, [INFO] [stderr] 56 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 51 | LogfilePartition { [INFO] [stderr] 52 | path: path.to_owned(), [INFO] [stderr] 53 | time_head: time_head, [INFO] [stderr] 54 | time_tail: time_tail, [INFO] [stderr] 55 | offset: offset, [INFO] [stderr] 56 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_partition.rs:80:3 [INFO] [stderr] | [INFO] [stderr] 80 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_partition.rs:86:3 [INFO] [stderr] | [INFO] [stderr] 86 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_partition.rs:94:3 [INFO] [stderr] | [INFO] [stderr] 94 | return self.path.join(self.get_file_name()).to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.path.join(self.get_file_name()).to_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_partition.rs:98:3 [INFO] [stderr] | [INFO] [stderr] 98 | return self.offset; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_partition.rs:102:3 [INFO] [stderr] | [INFO] [stderr] 102 | return self.time_head; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.time_head` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_partition.rs:106:3 [INFO] [stderr] | [INFO] [stderr] 106 | return self.time_tail; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.time_tail` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_transaction.rs:54:3 [INFO] [stderr] | [INFO] [stderr] 54 | return LogfileTransaction { [INFO] [stderr] | _________^ [INFO] [stderr] 55 | | id: id.get_string(), [INFO] [stderr] 56 | | partitions: partitions.collect() [INFO] [stderr] 57 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 54 | LogfileTransaction { [INFO] [stderr] 55 | id: id.get_string(), [INFO] [stderr] 56 | partitions: partitions.collect() [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_transaction.rs:47:4 [INFO] [stderr] | [INFO] [stderr] 47 | return LogfileTransactionPartition { [INFO] [stderr] | _____________^ [INFO] [stderr] 48 | | time_head: partition.get_time_head(), [INFO] [stderr] 49 | | time_tail: partition.get_time_tail(), [INFO] [stderr] 50 | | offset: partition.get_file_offset(), [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 47 | LogfileTransactionPartition { [INFO] [stderr] 48 | time_head: partition.get_time_head(), [INFO] [stderr] 49 | time_tail: partition.get_time_tail(), [INFO] [stderr] 50 | offset: partition.get_file_offset(), [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_transaction.rs:70:3 [INFO] [stderr] | [INFO] [stderr] 70 | return Ok(transaction); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(transaction)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_transaction.rs:94:3 [INFO] [stderr] | [INFO] [stderr] 94 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_reader.rs:32:3 [INFO] [stderr] | [INFO] [stderr] 32 | return LogfileReader { [INFO] [stderr] | _________^ [INFO] [stderr] 33 | | partitions: partitions [INFO] [stderr] 34 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 32 | LogfileReader { [INFO] [stderr] 33 | partitions: partitions [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_reader.rs:96:3 [INFO] [stderr] | [INFO] [stderr] 96 | return Ok(measurements); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(measurements)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_writer.rs:37:2 [INFO] [stderr] | [INFO] [stderr] 37 | return Ok(measurement.get_encoded_size()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(measurement.get_encoded_size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/quota.rs:41:3 [INFO] [stderr] | [INFO] [stderr] 41 | return match (value, modifier) { [INFO] [stderr] | _________^ [INFO] [stderr] 42 | | (None, "unlimited") | (None, "infinite") => [INFO] [stderr] 43 | | Ok(StorageQuota::Unlimited), [INFO] [stderr] 44 | | (None, "none") | (None, "zero") => [INFO] [stderr] ... | [INFO] [stderr] 59 | | Err(err_user!("invalid quota specification: {}", string)) [INFO] [stderr] 60 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 41 | match (value, modifier) { [INFO] [stderr] 42 | (None, "unlimited") | (None, "infinite") => [INFO] [stderr] 43 | Ok(StorageQuota::Unlimited), [INFO] [stderr] 44 | (None, "none") | (None, "zero") => [INFO] [stderr] 45 | Ok(StorageQuota::Zero), [INFO] [stderr] 46 | (Some(value), "KB") | (Some(value), "kb") => [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/quota.rs:64:3 [INFO] [stderr] | [INFO] [stderr] 64 | return match self { [INFO] [stderr] | _________^ [INFO] [stderr] 65 | | &StorageQuota::Unlimited => false, [INFO] [stderr] 66 | | &StorageQuota::Limited{limit_bytes} => limit_bytes == 0, [INFO] [stderr] 67 | | &StorageQuota::Zero => true, [INFO] [stderr] 68 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 64 | match self { [INFO] [stderr] 65 | &StorageQuota::Unlimited => false, [INFO] [stderr] 66 | &StorageQuota::Limited{limit_bytes} => limit_bytes == 0, [INFO] [stderr] 67 | &StorageQuota::Zero => true, [INFO] [stderr] 68 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/quota.rs:72:3 [INFO] [stderr] | [INFO] [stderr] 72 | return match self { [INFO] [stderr] | _________^ [INFO] [stderr] 73 | | &StorageQuota::Unlimited => true, [INFO] [stderr] 74 | | &StorageQuota::Limited{limit_bytes} => limit_bytes >= bytes, [INFO] [stderr] 75 | | &StorageQuota::Zero => false, [INFO] [stderr] 76 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 72 | match self { [INFO] [stderr] 73 | &StorageQuota::Unlimited => true, [INFO] [stderr] 74 | &StorageQuota::Limited{limit_bytes} => limit_bytes >= bytes, [INFO] [stderr] 75 | &StorageQuota::Zero => false, [INFO] [stderr] 76 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/measure.rs:82:3 [INFO] [stderr] | [INFO] [stderr] 82 | return Ok(measurement); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(measurement)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/measure.rs:106:3 [INFO] [stderr] | [INFO] [stderr] 106 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/measure.rs:110:3 [INFO] [stderr] | [INFO] [stderr] 110 | return (self.data.len() as u64 + FOOTER_SIZE) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.data.len() as u64 + FOOTER_SIZE) as u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/service.rs:46:3 [INFO] [stderr] | [INFO] [stderr] 46 | return Ok(service); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(service)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/time.rs:24:2 [INFO] [stderr] | [INFO] [stderr] 24 | return match SystemTime::now().duration_since(UNIX_EPOCH) { [INFO] [stderr] | _____^ [INFO] [stderr] 25 | | Ok(t) => Ok(t.as_secs() * 1000000 + t.subsec_nanos() as u64 / 1000), [INFO] [stderr] 26 | | Err(_) => Err(err_server!("cannot get current timestamp")) [INFO] [stderr] 27 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 24 | match SystemTime::now().duration_since(UNIX_EPOCH) { [INFO] [stderr] 25 | Ok(t) => Ok(t.as_secs() * 1000000 + t.subsec_nanos() as u64 / 1000), [INFO] [stderr] 26 | Err(_) => Err(err_server!("cannot get current timestamp")) [INFO] [stderr] 27 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/time.rs:25:29 [INFO] [stderr] | [INFO] [stderr] 25 | Ok(t) => Ok(t.as_secs() * 1000000 + t.subsec_nanos() as u64 / 1000), [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/server.rs:56:18 [INFO] [stderr] | [INFO] [stderr] 56 | const VERSION : &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/server.rs:57:27 [INFO] [stderr] | [INFO] [stderr] 57 | const LOGLEVEL_DEFAULT : &'static str = "info"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/server.rs:59:16 [INFO] [stderr] | [INFO] [stderr] 59 | const USAGE : &'static str = "\ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:210:2 [INFO] [stderr] | [INFO] [stderr] 210 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/error.rs:58:3 [INFO] [stderr] | [INFO] [stderr] 58 | return Error { [INFO] [stderr] | _________^ [INFO] [stderr] 59 | | message: message.to_owned(), [INFO] [stderr] 60 | | code: code [INFO] [stderr] 61 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 58 | Error { [INFO] [stderr] 59 | message: message.to_owned(), [INFO] [stderr] 60 | code: code [INFO] [stderr] 61 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api.rs:51:2 [INFO] [stderr] | [INFO] [stderr] 51 | return Ok(StoreMeasurementResponse { [INFO] [stderr] | _____^ [INFO] [stderr] 52 | | success: true [INFO] [stderr] 53 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 51 | Ok(StoreMeasurementResponse { [INFO] [stderr] 52 | success: true [INFO] [stderr] 53 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api.rs:89:2 [INFO] [stderr] | [INFO] [stderr] 89 | return Ok(FetchMeasurementsResponse{ [INFO] [stderr] | _____^ [INFO] [stderr] 90 | | measurements: measurements [INFO] [stderr] 91 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 89 | Ok(FetchMeasurementsResponse{ [INFO] [stderr] 90 | measurements: measurements [INFO] [stderr] 91 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api_json.rs:41:2 [INFO] [stderr] | [INFO] [stderr] 41 | return Ok(res_json); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res_json)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api_json.rs:50:2 [INFO] [stderr] | [INFO] [stderr] 50 | return match method { [INFO] [stderr] | _____^ [INFO] [stderr] 51 | | "store_measurement" => call(service, &::api::store_measurement, req), [INFO] [stderr] 52 | | "fetch_measurements" => call(service, &::api::fetch_measurements, req), [INFO] [stderr] 53 | | _ => Err(err_user!("invalid API method")) [INFO] [stderr] 54 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 50 | match method { [INFO] [stderr] 51 | "store_measurement" => call(service, &::api::store_measurement, req), [INFO] [stderr] 52 | "fetch_measurements" => call(service, &::api::fetch_measurements, req), [INFO] [stderr] 53 | _ => Err(err_user!("invalid API method")) [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api_json.rs:66:2 [INFO] [stderr] | [INFO] [stderr] 66 | return match method(service, req) { [INFO] [stderr] | _____^ [INFO] [stderr] 67 | | Ok(r) => Ok(json::to_value(r).unwrap()), [INFO] [stderr] 68 | | Err(e) => Err(e) [INFO] [stderr] 69 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 66 | match method(service, req) { [INFO] [stderr] 67 | Ok(r) => Ok(json::to_value(r).unwrap()), [INFO] [stderr] 68 | Err(e) => Err(e) [INFO] [stderr] 69 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:58:2 [INFO] [stderr] | [INFO] [stderr] 58 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:82:2 [INFO] [stderr] | [INFO] [stderr] 82 | return Ok( [INFO] [stderr] | _____^ [INFO] [stderr] 83 | | Response::new() [INFO] [stderr] 84 | | .with_status(StatusCode::NotFound) [INFO] [stderr] 85 | | .with_body("not found")); [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 82 | Ok( [INFO] [stderr] 83 | Response::new() [INFO] [stderr] 84 | .with_status(StatusCode::NotFound) [INFO] [stderr] 85 | .with_body("not found")) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:107:2 [INFO] [stderr] | [INFO] [stderr] 107 | return Ok( [INFO] [stderr] | _____^ [INFO] [stderr] 108 | | Response::new() [INFO] [stderr] 109 | | .with_status(StatusCode::Ok) [INFO] [stderr] 110 | | .with_body(rpc_response)); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 107 | Ok( [INFO] [stderr] 108 | Response::new() [INFO] [stderr] 109 | .with_status(StatusCode::Ok) [INFO] [stderr] 110 | .with_body(rpc_response)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:122:3 [INFO] [stderr] | [INFO] [stderr] 122 | return HTTPHandler { [INFO] [stderr] | _________^ [INFO] [stderr] 123 | | thread_pool: CpuPool::new_num_cpus(), [INFO] [stderr] 124 | | service: service [INFO] [stderr] 125 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 122 | HTTPHandler { [INFO] [stderr] 123 | thread_pool: CpuPool::new_num_cpus(), [INFO] [stderr] 124 | service: service [INFO] [stderr] 125 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:185:3 [INFO] [stderr] | [INFO] [stderr] 185 | return Box::new(res_future); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(res_future)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:182:4 [INFO] [stderr] | [INFO] [stderr] 182 | return futures::future::ok(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `futures::future::ok(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/logfile.rs:32:32 [INFO] [stderr] | [INFO] [stderr] 32 | const TRANSACTION_FILE_NAME : &'static str = "tx.lock"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile.rs:72:3 [INFO] [stderr] | [INFO] [stderr] 72 | return Ok(logfile); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(logfile)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile.rs:109:3 [INFO] [stderr] | [INFO] [stderr] 109 | return Ok(Some(logfile)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(logfile))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile.rs:118:3 [INFO] [stderr] | [INFO] [stderr] 118 | return storage_locked.id.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `storage_locked.id.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile.rs:158:3 [INFO] [stderr] | [INFO] [stderr] 158 | return storage_locked.commit(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `storage_locked.commit()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile.rs:172:3 [INFO] [stderr] | [INFO] [stderr] 172 | return reader.fetch_measurements( [INFO] [stderr] | _________^ [INFO] [stderr] 173 | | time_start, [INFO] [stderr] 174 | | time_limit, [INFO] [stderr] 175 | | limit); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 172 | reader.fetch_measurements( [INFO] [stderr] 173 | time_start, [INFO] [stderr] 174 | time_limit, [INFO] [stderr] 175 | limit) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile.rs:198:3 [INFO] [stderr] | [INFO] [stderr] 198 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile.rs:220:3 [INFO] [stderr] | [INFO] [stderr] 220 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile.rs:240:3 [INFO] [stderr] | [INFO] [stderr] 240 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_id.rs:35:3 [INFO] [stderr] | [INFO] [stderr] 35 | return LogfileID { [INFO] [stderr] | _________^ [INFO] [stderr] 36 | | id: string [INFO] [stderr] 37 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 35 | LogfileID { [INFO] [stderr] 36 | id: string [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_id.rs:41:3 [INFO] [stderr] | [INFO] [stderr] 41 | return self.id.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.id.to_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_id.rs:47:3 [INFO] [stderr] | [INFO] [stderr] 47 | return LogfilePath { [INFO] [stderr] | _________^ [INFO] [stderr] 48 | | file_name: format!("{:x}", id_digest) [INFO] [stderr] 49 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 47 | LogfilePath { [INFO] [stderr] 48 | file_name: format!("{:x}", id_digest) [INFO] [stderr] 49 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_id.rs:56:3 [INFO] [stderr] | [INFO] [stderr] 56 | return LogfilePath { [INFO] [stderr] | _________^ [INFO] [stderr] 57 | | file_name: file_name [INFO] [stderr] 58 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 56 | LogfilePath { [INFO] [stderr] 57 | file_name: file_name [INFO] [stderr] 58 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_id.rs:62:3 [INFO] [stderr] | [INFO] [stderr] 62 | return self.file_name.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.file_name.to_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_config.rs:36:3 [INFO] [stderr] | [INFO] [stderr] 36 | return LogfileConfig { [INFO] [stderr] | _________^ [INFO] [stderr] 37 | | quota_default: StorageQuota::Zero, [INFO] [stderr] 38 | | quota: HashMap::::new(), [INFO] [stderr] 39 | | partition_size_bytes_default: DEFAULT_PARTITION_SIZE_MAX_BYTES [INFO] [stderr] 40 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 36 | LogfileConfig { [INFO] [stderr] 37 | quota_default: StorageQuota::Zero, [INFO] [stderr] 38 | quota: HashMap::::new(), [INFO] [stderr] 39 | partition_size_bytes_default: DEFAULT_PARTITION_SIZE_MAX_BYTES [INFO] [stderr] 40 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_config.rs:44:3 [INFO] [stderr] | [INFO] [stderr] 44 | return self [INFO] [stderr] | _________^ [INFO] [stderr] 45 | | .quota [INFO] [stderr] 46 | | .get(logfile_id) [INFO] [stderr] 47 | | .unwrap_or(&self.quota_default) [INFO] [stderr] 48 | | .clone(); [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 44 | self [INFO] [stderr] 45 | .quota [INFO] [stderr] 46 | .get(logfile_id) [INFO] [stderr] 47 | .unwrap_or(&self.quota_default) [INFO] [stderr] 48 | .clone() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_config.rs:63:3 [INFO] [stderr] | [INFO] [stderr] 63 | return self.partition_size_bytes_default; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.partition_size_bytes_default` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/logfile_directory.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | const DATABASE_PATH : &'static str = "db"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_directory.rs:43:3 [INFO] [stderr] | [INFO] [stderr] 43 | return Ok(logfile_directory); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(logfile_directory)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_directory.rs:59:3 [INFO] [stderr] | [INFO] [stderr] 59 | return Ok(Arc::new(logfile)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Arc::new(logfile))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_directory.rs:74:3 [INFO] [stderr] | [INFO] [stderr] 74 | return Ok(logfile.map(|f| Arc::new(f))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(logfile.map(|f| Arc::new(f)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_directory.rs:87:3 [INFO] [stderr] | [INFO] [stderr] 87 | return Ok(logfiles); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(logfiles)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_map.rs:48:3 [INFO] [stderr] | [INFO] [stderr] 48 | return Ok(LogfileMap { [INFO] [stderr] | _________^ [INFO] [stderr] 49 | | directory: directory, [INFO] [stderr] 50 | | config: config, [INFO] [stderr] 51 | | logfiles: Arc::new(RwLock::new(logfile_map)), [INFO] [stderr] 52 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 48 | Ok(LogfileMap { [INFO] [stderr] 49 | directory: directory, [INFO] [stderr] 50 | config: config, [INFO] [stderr] 51 | logfiles: Arc::new(RwLock::new(logfile_map)), [INFO] [stderr] 52 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_map.rs:61:3 [INFO] [stderr] | [INFO] [stderr] 61 | return logfiles_locked [INFO] [stderr] | _________^ [INFO] [stderr] 62 | | .get(&logfile_id.get_string()) [INFO] [stderr] 63 | | .map(|l| l.clone()); [INFO] [stderr] | |____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 61 | logfiles_locked [INFO] [stderr] 62 | .get(&logfile_id.get_string()) [INFO] [stderr] 63 | .map(|l| l.clone()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_map.rs:89:3 [INFO] [stderr] | [INFO] [stderr] 89 | return Ok(logfile); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(logfile)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_partition.rs:43:3 [INFO] [stderr] | [INFO] [stderr] 43 | return Ok(partition); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(partition)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_partition.rs:51:3 [INFO] [stderr] | [INFO] [stderr] 51 | return LogfilePartition { [INFO] [stderr] | _________^ [INFO] [stderr] 52 | | path: path.to_owned(), [INFO] [stderr] 53 | | time_head: time_head, [INFO] [stderr] 54 | | time_tail: time_tail, [INFO] [stderr] 55 | | offset: offset, [INFO] [stderr] 56 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 51 | LogfilePartition { [INFO] [stderr] 52 | path: path.to_owned(), [INFO] [stderr] 53 | time_head: time_head, [INFO] [stderr] 54 | time_tail: time_tail, [INFO] [stderr] 55 | offset: offset, [INFO] [stderr] 56 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_partition.rs:80:3 [INFO] [stderr] | [INFO] [stderr] 80 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_partition.rs:86:3 [INFO] [stderr] | [INFO] [stderr] 86 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_partition.rs:94:3 [INFO] [stderr] | [INFO] [stderr] 94 | return self.path.join(self.get_file_name()).to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.path.join(self.get_file_name()).to_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_partition.rs:98:3 [INFO] [stderr] | [INFO] [stderr] 98 | return self.offset; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_partition.rs:102:3 [INFO] [stderr] | [INFO] [stderr] 102 | return self.time_head; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.time_head` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_partition.rs:106:3 [INFO] [stderr] | [INFO] [stderr] 106 | return self.time_tail; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.time_tail` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_transaction.rs:54:3 [INFO] [stderr] | [INFO] [stderr] 54 | return LogfileTransaction { [INFO] [stderr] | _________^ [INFO] [stderr] 55 | | id: id.get_string(), [INFO] [stderr] 56 | | partitions: partitions.collect() [INFO] [stderr] 57 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 54 | LogfileTransaction { [INFO] [stderr] 55 | id: id.get_string(), [INFO] [stderr] 56 | partitions: partitions.collect() [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_transaction.rs:47:4 [INFO] [stderr] | [INFO] [stderr] 47 | return LogfileTransactionPartition { [INFO] [stderr] | _____________^ [INFO] [stderr] 48 | | time_head: partition.get_time_head(), [INFO] [stderr] 49 | | time_tail: partition.get_time_tail(), [INFO] [stderr] 50 | | offset: partition.get_file_offset(), [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 47 | LogfileTransactionPartition { [INFO] [stderr] 48 | time_head: partition.get_time_head(), [INFO] [stderr] 49 | time_tail: partition.get_time_tail(), [INFO] [stderr] 50 | offset: partition.get_file_offset(), [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_transaction.rs:70:3 [INFO] [stderr] | [INFO] [stderr] 70 | return Ok(transaction); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(transaction)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_transaction.rs:94:3 [INFO] [stderr] | [INFO] [stderr] 94 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_reader.rs:32:3 [INFO] [stderr] | [INFO] [stderr] 32 | return LogfileReader { [INFO] [stderr] | _________^ [INFO] [stderr] 33 | | partitions: partitions [INFO] [stderr] 34 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 32 | LogfileReader { [INFO] [stderr] 33 | partitions: partitions [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_reader.rs:96:3 [INFO] [stderr] | [INFO] [stderr] 96 | return Ok(measurements); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(measurements)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logfile_writer.rs:37:2 [INFO] [stderr] | [INFO] [stderr] 37 | return Ok(measurement.get_encoded_size()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(measurement.get_encoded_size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/quota.rs:41:3 [INFO] [stderr] | [INFO] [stderr] 41 | return match (value, modifier) { [INFO] [stderr] | _________^ [INFO] [stderr] 42 | | (None, "unlimited") | (None, "infinite") => [INFO] [stderr] 43 | | Ok(StorageQuota::Unlimited), [INFO] [stderr] 44 | | (None, "none") | (None, "zero") => [INFO] [stderr] ... | [INFO] [stderr] 59 | | Err(err_user!("invalid quota specification: {}", string)) [INFO] [stderr] 60 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 41 | match (value, modifier) { [INFO] [stderr] 42 | (None, "unlimited") | (None, "infinite") => [INFO] [stderr] 43 | Ok(StorageQuota::Unlimited), [INFO] [stderr] 44 | (None, "none") | (None, "zero") => [INFO] [stderr] 45 | Ok(StorageQuota::Zero), [INFO] [stderr] 46 | (Some(value), "KB") | (Some(value), "kb") => [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/quota.rs:64:3 [INFO] [stderr] | [INFO] [stderr] 64 | return match self { [INFO] [stderr] | _________^ [INFO] [stderr] 65 | | &StorageQuota::Unlimited => false, [INFO] [stderr] 66 | | &StorageQuota::Limited{limit_bytes} => limit_bytes == 0, [INFO] [stderr] 67 | | &StorageQuota::Zero => true, [INFO] [stderr] 68 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 64 | match self { [INFO] [stderr] 65 | &StorageQuota::Unlimited => false, [INFO] [stderr] 66 | &StorageQuota::Limited{limit_bytes} => limit_bytes == 0, [INFO] [stderr] 67 | &StorageQuota::Zero => true, [INFO] [stderr] 68 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/quota.rs:72:3 [INFO] [stderr] | [INFO] [stderr] 72 | return match self { [INFO] [stderr] | _________^ [INFO] [stderr] 73 | | &StorageQuota::Unlimited => true, [INFO] [stderr] 74 | | &StorageQuota::Limited{limit_bytes} => limit_bytes >= bytes, [INFO] [stderr] 75 | | &StorageQuota::Zero => false, [INFO] [stderr] 76 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 72 | match self { [INFO] [stderr] 73 | &StorageQuota::Unlimited => true, [INFO] [stderr] 74 | &StorageQuota::Limited{limit_bytes} => limit_bytes >= bytes, [INFO] [stderr] 75 | &StorageQuota::Zero => false, [INFO] [stderr] 76 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/measure.rs:82:3 [INFO] [stderr] | [INFO] [stderr] 82 | return Ok(measurement); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(measurement)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/measure.rs:106:3 [INFO] [stderr] | [INFO] [stderr] 106 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/measure.rs:110:3 [INFO] [stderr] | [INFO] [stderr] 110 | return (self.data.len() as u64 + FOOTER_SIZE) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.data.len() as u64 + FOOTER_SIZE) as u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/service.rs:46:3 [INFO] [stderr] | [INFO] [stderr] 46 | return Ok(service); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(service)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/time.rs:24:2 [INFO] [stderr] | [INFO] [stderr] 24 | return match SystemTime::now().duration_since(UNIX_EPOCH) { [INFO] [stderr] | _____^ [INFO] [stderr] 25 | | Ok(t) => Ok(t.as_secs() * 1000000 + t.subsec_nanos() as u64 / 1000), [INFO] [stderr] 26 | | Err(_) => Err(err_server!("cannot get current timestamp")) [INFO] [stderr] 27 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 24 | match SystemTime::now().duration_since(UNIX_EPOCH) { [INFO] [stderr] 25 | Ok(t) => Ok(t.as_secs() * 1000000 + t.subsec_nanos() as u64 / 1000), [INFO] [stderr] 26 | Err(_) => Err(err_server!("cannot get current timestamp")) [INFO] [stderr] 27 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/time.rs:25:29 [INFO] [stderr] | [INFO] [stderr] 25 | Ok(t) => Ok(t.as_secs() * 1000000 + t.subsec_nanos() as u64 / 1000), [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/server.rs:56:18 [INFO] [stderr] | [INFO] [stderr] 56 | const VERSION : &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/server.rs:57:27 [INFO] [stderr] | [INFO] [stderr] 57 | const LOGLEVEL_DEFAULT : &'static str = "info"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/server.rs:59:16 [INFO] [stderr] | [INFO] [stderr] 59 | const USAGE : &'static str = "\ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:210:2 [INFO] [stderr] | [INFO] [stderr] 210 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/http.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | body: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/http.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | body: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/http.rs:101:11 [INFO] [stderr] | [INFO] [stderr] 101 | .split("/") [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/logfile.rs:231:7 [INFO] [stderr] | [INFO] [stderr] 231 | if self.partitions.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.partitions.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/logfile_directory.rs:74:25 [INFO] [stderr] | [INFO] [stderr] 74 | return Ok(logfile.map(|f| Arc::new(f))); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `Arc::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/logfile_map.rs:61:10 [INFO] [stderr] | [INFO] [stderr] 61 | return logfiles_locked [INFO] [stderr] | ________________^ [INFO] [stderr] 62 | | .get(&logfile_id.get_string()) [INFO] [stderr] 63 | | .map(|l| l.clone()); [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 61 | return logfiles_locked [INFO] [stderr] 62 | .get(&logfile_id.get_string()).cloned(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/http.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | body: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/http.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | body: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/http.rs:101:11 [INFO] [stderr] | [INFO] [stderr] 101 | .split("/") [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/logfile_transaction.rs:45:16 [INFO] [stderr] | [INFO] [stderr] 45 | partitions: &Vec) -> LogfileTransaction { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[LogfilePartition]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/logfile.rs:231:7 [INFO] [stderr] | [INFO] [stderr] 231 | if self.partitions.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.partitions.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/logfile_reader.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn new(partitions: &'a Vec) -> LogfileReader<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[LogfilePartition]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/logfile_directory.rs:74:25 [INFO] [stderr] | [INFO] [stderr] 74 | return Ok(logfile.map(|f| Arc::new(f))); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `Arc::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/logfile_map.rs:61:10 [INFO] [stderr] | [INFO] [stderr] 61 | return logfiles_locked [INFO] [stderr] | ________________^ [INFO] [stderr] 62 | | .get(&logfile_id.get_string()) [INFO] [stderr] 63 | | .map(|l| l.clone()); [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 61 | return logfiles_locked [INFO] [stderr] 62 | .get(&logfile_id.get_string()).cloned(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/quota.rs:32:31 [INFO] [stderr] | [INFO] [stderr] 32 | Some(len) => (Some(&string[0..len+1]), &string[len+1..]), [INFO] [stderr] | ^^^^^^^^ help: use: `0..=len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/quota.rs:64:10 [INFO] [stderr] | [INFO] [stderr] 64 | return match self { [INFO] [stderr] | ________________^ [INFO] [stderr] 65 | | &StorageQuota::Unlimited => false, [INFO] [stderr] 66 | | &StorageQuota::Limited{limit_bytes} => limit_bytes == 0, [INFO] [stderr] 67 | | &StorageQuota::Zero => true, [INFO] [stderr] 68 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 64 | return match *self { [INFO] [stderr] 65 | StorageQuota::Unlimited => false, [INFO] [stderr] 66 | StorageQuota::Limited{limit_bytes} => limit_bytes == 0, [INFO] [stderr] 67 | StorageQuota::Zero => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/quota.rs:72:10 [INFO] [stderr] | [INFO] [stderr] 72 | return match self { [INFO] [stderr] | ________________^ [INFO] [stderr] 73 | | &StorageQuota::Unlimited => true, [INFO] [stderr] 74 | | &StorageQuota::Limited{limit_bytes} => limit_bytes >= bytes, [INFO] [stderr] 75 | | &StorageQuota::Zero => false, [INFO] [stderr] 76 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 72 | return match *self { [INFO] [stderr] 73 | StorageQuota::Unlimited => true, [INFO] [stderr] 74 | StorageQuota::Limited{limit_bytes} => limit_bytes >= bytes, [INFO] [stderr] 75 | StorageQuota::Zero => false, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/measure.rs:61:29 [INFO] [stderr] | [INFO] [stderr] 61 | if offset < FOOTER_SIZE + data_size as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(data_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/measure.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | data_size as u64 - [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/measure.rs:71:3 [INFO] [stderr] | [INFO] [stderr] 70 | let mut data = Vec::::with_capacity(data_size as usize); [INFO] [stderr] | -------------------------------------------- help: consider replace allocation with: `vec![0; data_size as usize]` [INFO] [stderr] 71 | data.resize(data_size as usize, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/logfile_transaction.rs:45:16 [INFO] [stderr] | [INFO] [stderr] 45 | partitions: &Vec) -> LogfileTransaction { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[LogfilePartition]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/logfile_reader.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn new(partitions: &'a Vec) -> LogfileReader<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[LogfilePartition]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/quota.rs:32:31 [INFO] [stderr] | [INFO] [stderr] 32 | Some(len) => (Some(&string[0..len+1]), &string[len+1..]), [INFO] [stderr] | ^^^^^^^^ help: use: `0..=len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/time.rs:25:39 [INFO] [stderr] | [INFO] [stderr] 25 | Ok(t) => Ok(t.as_secs() * 1000000 + t.subsec_nanos() as u64 / 1000), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(t.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/quota.rs:64:10 [INFO] [stderr] | [INFO] [stderr] 64 | return match self { [INFO] [stderr] | ________________^ [INFO] [stderr] 65 | | &StorageQuota::Unlimited => false, [INFO] [stderr] 66 | | &StorageQuota::Limited{limit_bytes} => limit_bytes == 0, [INFO] [stderr] 67 | | &StorageQuota::Zero => true, [INFO] [stderr] 68 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 64 | return match *self { [INFO] [stderr] 65 | StorageQuota::Unlimited => false, [INFO] [stderr] 66 | StorageQuota::Limited{limit_bytes} => limit_bytes == 0, [INFO] [stderr] 67 | StorageQuota::Zero => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/quota.rs:72:10 [INFO] [stderr] | [INFO] [stderr] 72 | return match self { [INFO] [stderr] | ________________^ [INFO] [stderr] 73 | | &StorageQuota::Unlimited => true, [INFO] [stderr] 74 | | &StorageQuota::Limited{limit_bytes} => limit_bytes >= bytes, [INFO] [stderr] 75 | | &StorageQuota::Zero => false, [INFO] [stderr] 76 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 72 | return match *self { [INFO] [stderr] 73 | StorageQuota::Unlimited => true, [INFO] [stderr] 74 | StorageQuota::Limited{limit_bytes} => limit_bytes >= bytes, [INFO] [stderr] 75 | StorageQuota::Zero => false, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/measure.rs:61:29 [INFO] [stderr] | [INFO] [stderr] 61 | if offset < FOOTER_SIZE + data_size as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(data_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/measure.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | data_size as u64 - [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/measure.rs:71:3 [INFO] [stderr] | [INFO] [stderr] 70 | let mut data = Vec::::with_capacity(data_size as usize); [INFO] [stderr] | -------------------------------------------- help: consider replace allocation with: `vec![0; data_size as usize]` [INFO] [stderr] 71 | data.resize(data_size as usize, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/time.rs:25:39 [INFO] [stderr] | [INFO] [stderr] 25 | Ok(t) => Ok(t.as_secs() * 1000000 + t.subsec_nanos() as u64 / 1000), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(t.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/server.rs:147:3 [INFO] [stderr] | [INFO] [stderr] 147 | std::io::stdout().write(USAGE.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/server.rs:156:32 [INFO] [stderr] | [INFO] [stderr] 156 | flags.opt_str("loglevel").unwrap_or(LOGLEVEL_DEFAULT.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| LOGLEVEL_DEFAULT.into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/server.rs:157:32 [INFO] [stderr] | [INFO] [stderr] 157 | std::env::var("RUST_LOG").unwrap_or("".into()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/server.rs:168:7 [INFO] [stderr] | [INFO] [stderr] 168 | &match &flags.opt_str("quota_default") { [INFO] [stderr] | ______________________^ [INFO] [stderr] 169 | | &Some(ref v) => v, [INFO] [stderr] 170 | | &None => return Err(err_user!("missing option: --quota_default")) [INFO] [stderr] 171 | | })?); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 168 | &match flags.opt_str("quota_default") { [INFO] [stderr] 169 | Some(ref v) => v, [INFO] [stderr] 170 | None => return Err(err_user!("missing option: --quota_default")) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/server.rs:147:3 [INFO] [stderr] | [INFO] [stderr] 147 | std::io::stdout().write(USAGE.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/server.rs:156:32 [INFO] [stderr] | [INFO] [stderr] 156 | flags.opt_str("loglevel").unwrap_or(LOGLEVEL_DEFAULT.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| LOGLEVEL_DEFAULT.into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/server.rs:157:32 [INFO] [stderr] | [INFO] [stderr] 157 | std::env::var("RUST_LOG").unwrap_or("".into()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/server.rs:168:7 [INFO] [stderr] | [INFO] [stderr] 168 | &match &flags.opt_str("quota_default") { [INFO] [stderr] | ______________________^ [INFO] [stderr] 169 | | &Some(ref v) => v, [INFO] [stderr] 170 | | &None => return Err(err_user!("missing option: --quota_default")) [INFO] [stderr] 171 | | })?); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 168 | &match flags.opt_str("quota_default") { [INFO] [stderr] 169 | Some(ref v) => v, [INFO] [stderr] 170 | None => return Err(err_user!("missing option: --quota_default")) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `sensorlog`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `sensorlog`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "ff18cb0b28e0a35f25172b15c6af52e331f6f5fa7061faaaf77afc0e34c372ac"` [INFO] running `"docker" "rm" "-f" "ff18cb0b28e0a35f25172b15c6af52e331f6f5fa7061faaaf77afc0e34c372ac"` [INFO] [stdout] ff18cb0b28e0a35f25172b15c6af52e331f6f5fa7061faaaf77afc0e34c372ac