[INFO] updating cached repository numpad/kassensystem [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/numpad/kassensystem [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/numpad/kassensystem" "work/ex/clippy-test-run/sources/stable/gh/numpad/kassensystem"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/numpad/kassensystem'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/numpad/kassensystem" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/numpad/kassensystem"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/numpad/kassensystem'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4cfcf735d33adf92971f83816737bb4ea76fc068 [INFO] sha for GitHub repo numpad/kassensystem: 4cfcf735d33adf92971f83816737bb4ea76fc068 [INFO] validating manifest of numpad/kassensystem on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of numpad/kassensystem on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing numpad/kassensystem [INFO] finished frobbing numpad/kassensystem [INFO] frobbed toml for numpad/kassensystem written to work/ex/clippy-test-run/sources/stable/gh/numpad/kassensystem/Cargo.toml [INFO] started frobbing numpad/kassensystem [INFO] finished frobbing numpad/kassensystem [INFO] frobbed toml for numpad/kassensystem written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/numpad/kassensystem/Cargo.toml [INFO] crate numpad/kassensystem has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting numpad/kassensystem against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/numpad/kassensystem:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5896b266e7989da051cd25817dbe91624e94267dc14af68393ee4e86f5399770 [INFO] running `"docker" "start" "-a" "5896b266e7989da051cd25817dbe91624e94267dc14af68393ee4e86f5399770"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] [stderr] Checking unic-common v0.7.0 [INFO] [stderr] Checking unic-char-range v0.7.0 [INFO] [stderr] Checking chunked_transfer v0.3.1 [INFO] [stderr] Compiling sqlite3-src v0.2.10 [INFO] [stderr] Checking slug v0.1.4 [INFO] [stderr] Compiling pest_meta v2.0.3 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Compiling syn v0.15.17 [INFO] [stderr] Checking unic-ucd-version v0.7.0 [INFO] [stderr] Checking error-chain v0.12.0 [INFO] [stderr] Checking unic-char-property v0.7.0 [INFO] [stderr] Checking tiny_http v0.6.0 [INFO] [stderr] Checking unic-ucd-segment v0.7.0 [INFO] [stderr] Checking sqlite3-sys v0.12.0 [INFO] [stderr] Checking sqlite3 v0.24.0 [INFO] [stderr] Checking unic-segment v0.7.0 [INFO] [stderr] Compiling pest_generator v2.0.0 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Compiling pest_derive v2.0.1 [INFO] [stderr] Checking tera v0.11.18 [INFO] [stderr] Checking kassensystem v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/db/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | pub mod db; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/db/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | pub mod db; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/server.rs:35:2 [INFO] [stderr] | [INFO] [stderr] 35 | body.split("&").into_iter() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `body.split("&")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | body.split("&").into_iter() [INFO] [stderr] | ^^^ help: try using a char instead: `'&'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/server.rs:37:17 [INFO] [stderr] | [INFO] [stderr] 37 | let mut kv = e.split("=").into_iter(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `e.split("=")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | let mut kv = e.split("=").into_iter(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/server.rs:39:22 [INFO] [stderr] | [INFO] [stderr] 39 | let k = kv.nth(0).expect(&format!("1) e = {}", e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("1) e = {}", e))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/server.rs:40:22 [INFO] [stderr] | [INFO] [stderr] 40 | let v = kv.nth(0).expect(&format!("2) e = {}", e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("2) e = {}", e))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/server.rs:77:67 [INFO] [stderr] | [INFO] [stderr] 77 | let path = path.path_segments().map(|c| c.collect::>() ).unwrap_or(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/server.rs:35:2 [INFO] [stderr] | [INFO] [stderr] 35 | body.split("&").into_iter() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `body.split("&")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | body.split("&").into_iter() [INFO] [stderr] | ^^^ help: try using a char instead: `'&'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/server.rs:37:17 [INFO] [stderr] | [INFO] [stderr] 37 | let mut kv = e.split("=").into_iter(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `e.split("=")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | let mut kv = e.split("=").into_iter(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/server.rs:39:22 [INFO] [stderr] | [INFO] [stderr] 39 | let k = kv.nth(0).expect(&format!("1) e = {}", e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("1) e = {}", e))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/server.rs:40:22 [INFO] [stderr] | [INFO] [stderr] 40 | let v = kv.nth(0).expect(&format!("2) e = {}", e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("2) e = {}", e))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/server.rs:77:67 [INFO] [stderr] | [INFO] [stderr] 77 | let path = path.path_segments().map(|c| c.collect::>() ).unwrap_or(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 42.57s [INFO] running `"docker" "inspect" "5896b266e7989da051cd25817dbe91624e94267dc14af68393ee4e86f5399770"` [INFO] running `"docker" "rm" "-f" "5896b266e7989da051cd25817dbe91624e94267dc14af68393ee4e86f5399770"` [INFO] [stdout] 5896b266e7989da051cd25817dbe91624e94267dc14af68393ee4e86f5399770