[INFO] updating cached repository nuew/margen [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nuew/margen [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nuew/margen" "work/ex/clippy-test-run/sources/stable/gh/nuew/margen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nuew/margen'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nuew/margen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nuew/margen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nuew/margen'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c19ecf0f75d01b6fd67e71d87d11cffefcac93cd [INFO] sha for GitHub repo nuew/margen: c19ecf0f75d01b6fd67e71d87d11cffefcac93cd [INFO] validating manifest of nuew/margen on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nuew/margen on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nuew/margen [INFO] finished frobbing nuew/margen [INFO] frobbed toml for nuew/margen written to work/ex/clippy-test-run/sources/stable/gh/nuew/margen/Cargo.toml [INFO] started frobbing nuew/margen [INFO] finished frobbing nuew/margen [INFO] frobbed toml for nuew/margen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nuew/margen/Cargo.toml [INFO] crate nuew/margen has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nuew/margen against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nuew/margen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7f08898cebf5f129026b121577f3d84d851ad7326139aa8f60c5dbb28168a2fa [INFO] running `"docker" "start" "-a" "7f08898cebf5f129026b121577f3d84d851ad7326139aa8f60c5dbb28168a2fa"` [INFO] [stderr] Compiling miniz-sys v0.1.7 [INFO] [stderr] Compiling lua52-sys v0.0.4 [INFO] [stderr] Checking deque v0.3.1 [INFO] [stderr] Checking num-bigint v0.1.35 [INFO] [stderr] Checking env_logger v0.3.5 [INFO] [stderr] Checking rayon v0.5.0 [INFO] [stderr] Checking num-rational v0.1.35 [INFO] [stderr] Checking flate2 v0.2.14 [INFO] [stderr] Checking jpeg-decoder v0.1.8 [INFO] [stderr] Checking png v0.5.2 [INFO] [stderr] Checking image v0.10.3 [INFO] [stderr] Checking hlua v0.1.9 [INFO] [stderr] Checking margen v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/imagebuilder.rs:23:7 [INFO] [stderr] | [INFO] [stderr] 23 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/imagebuilder.rs:24:7 [INFO] [stderr] | [INFO] [stderr] 24 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/imagebuilder.rs:23:7 [INFO] [stderr] | [INFO] [stderr] 23 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/imagebuilder.rs:24:7 [INFO] [stderr] | [INFO] [stderr] 24 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | / fn construct_image<'a>(generator: &'a mut Generator) -> Result { [INFO] [stderr] 19 | | let width = generator.get_unsigned_32("width").expect("Width required."); [INFO] [stderr] 20 | | let height = generator.get_unsigned_32("height").expect("Height required."); [INFO] [stderr] 21 | | [INFO] [stderr] ... | [INFO] [stderr] 47 | | image_builder.build(generator) [INFO] [stderr] 48 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:63:6 [INFO] [stderr] | [INFO] [stderr] 63 | .unwrap_or(String::from("output.png")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("output.png"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | / fn construct_image<'a>(generator: &'a mut Generator) -> Result { [INFO] [stderr] 19 | | let width = generator.get_unsigned_32("width").expect("Width required."); [INFO] [stderr] 20 | | let height = generator.get_unsigned_32("height").expect("Height required."); [INFO] [stderr] 21 | | [INFO] [stderr] ... | [INFO] [stderr] 47 | | image_builder.build(generator) [INFO] [stderr] 48 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:63:6 [INFO] [stderr] | [INFO] [stderr] 63 | .unwrap_or(String::from("output.png")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("output.png"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.14s [INFO] running `"docker" "inspect" "7f08898cebf5f129026b121577f3d84d851ad7326139aa8f60c5dbb28168a2fa"` [INFO] running `"docker" "rm" "-f" "7f08898cebf5f129026b121577f3d84d851ad7326139aa8f60c5dbb28168a2fa"` [INFO] [stdout] 7f08898cebf5f129026b121577f3d84d851ad7326139aa8f60c5dbb28168a2fa