[INFO] updating cached repository nuew/fntpd
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/nuew/fntpd
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/nuew/fntpd" "work/ex/clippy-test-run/sources/stable/gh/nuew/fntpd"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nuew/fntpd'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/nuew/fntpd" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nuew/fntpd"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nuew/fntpd'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 7c6c9a5deb772a842cf87d42804ff94769e637e4
[INFO] sha for GitHub repo nuew/fntpd: 7c6c9a5deb772a842cf87d42804ff94769e637e4
[INFO] validating manifest of nuew/fntpd on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of nuew/fntpd on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing nuew/fntpd
[INFO] finished frobbing nuew/fntpd
[INFO] frobbed toml for nuew/fntpd written to work/ex/clippy-test-run/sources/stable/gh/nuew/fntpd/Cargo.toml
[INFO] started frobbing nuew/fntpd
[INFO] finished frobbing nuew/fntpd
[INFO] frobbed toml for nuew/fntpd written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nuew/fntpd/Cargo.toml
[INFO] crate nuew/fntpd has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting nuew/fntpd against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nuew/fntpd:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 0491647c5a4040ed9368484d033a0ab7167bcf64ae9174dc9709e2400534baa1
[INFO] running `"docker" "start" "-a" "0491647c5a4040ed9368484d033a0ab7167bcf64ae9174dc9709e2400534baa1"`
[INFO] [stderr]    Compiling quote v0.3.13
[INFO] [stderr]     Checking serde v0.9.7
[INFO] [stderr]    Compiling synom v0.11.0
[INFO] [stderr]     Checking daemonize v0.2.3
[INFO] [stderr]     Checking fern v0.3.5
[INFO] [stderr]    Compiling syn v0.11.6
[INFO] [stderr]    Compiling serde_codegen_internals v0.13.0
[INFO] [stderr]    Compiling serde_derive v0.9.7
[INFO] [stderr]     Checking chrono v0.3.0
[INFO] [stderr]     Checking toml v0.3.0
[INFO] [stderr]     Checking fntpd v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:40:30
[INFO] [stderr]    |
[INFO] [stderr] 40 |                              output: output,
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^ help: replace it with: `output`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]   --> src/main.rs:44:18
[INFO] [stderr]    |
[INFO] [stderr] 44 |                  "\n\tOFF",
[INFO] [stderr]    |                  ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::print_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]   --> src/main.rs:45:18
[INFO] [stderr]    |
[INFO] [stderr] 45 |                  "\n\tERROR",
[INFO] [stderr]    |                  ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]   --> src/main.rs:46:18
[INFO] [stderr]    |
[INFO] [stderr] 46 |                  "\n\tWARN",
[INFO] [stderr]    |                  ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]   --> src/main.rs:47:18
[INFO] [stderr]    |
[INFO] [stderr] 47 |                  "\n\tINFO",
[INFO] [stderr]    |                  ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]   --> src/main.rs:48:18
[INFO] [stderr]    |
[INFO] [stderr] 48 |                  "\n\tDEBUG",
[INFO] [stderr]    |                  ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]   --> src/main.rs:49:18
[INFO] [stderr]    |
[INFO] [stderr] 49 |                  "\n\tTRACE");
[INFO] [stderr]    |                  ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:40:30
[INFO] [stderr]    |
[INFO] [stderr] 40 |                              output: output,
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^ help: replace it with: `output`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]   --> src/main.rs:44:18
[INFO] [stderr]    |
[INFO] [stderr] 44 |                  "\n\tOFF",
[INFO] [stderr]    |                  ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::print_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]   --> src/main.rs:45:18
[INFO] [stderr]    |
[INFO] [stderr] 45 |                  "\n\tERROR",
[INFO] [stderr]    |                  ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]   --> src/main.rs:46:18
[INFO] [stderr]    |
[INFO] [stderr] 46 |                  "\n\tWARN",
[INFO] [stderr]    |                  ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]   --> src/main.rs:47:18
[INFO] [stderr]    |
[INFO] [stderr] 47 |                  "\n\tINFO",
[INFO] [stderr]    |                  ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]   --> src/main.rs:48:18
[INFO] [stderr]    |
[INFO] [stderr] 48 |                  "\n\tDEBUG",
[INFO] [stderr]    |                  ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]   --> src/main.rs:49:18
[INFO] [stderr]    |
[INFO] [stderr] 49 |                  "\n\tTRACE");
[INFO] [stderr]    |                  ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/ntp/pkt.rs:195:5
[INFO] [stderr]     |
[INFO] [stderr] 195 |     return true;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:25:24
[INFO] [stderr]    |
[INFO] [stderr] 25 | const DEFAULT_CONFIG: &'static str = "config.toml";
[INFO] [stderr]    |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/ntp/pkt.rs:195:5
[INFO] [stderr]     |
[INFO] [stderr] 195 |     return true;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:25:24
[INFO] [stderr]    |
[INFO] [stderr] 25 | const DEFAULT_CONFIG: &'static str = "config.toml";
[INFO] [stderr]    |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `TOLERANCE`
[INFO] [stderr]   --> src/ntp/mod.rs:13:1
[INFO] [stderr]    |
[INFO] [stderr] 13 | pub const TOLERANCE: f32 = 15e-6;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `MINPOLL`
[INFO] [stderr]   --> src/ntp/mod.rs:16:1
[INFO] [stderr]    |
[INFO] [stderr] 16 | pub const MINPOLL: u8 = 4;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `MAXPOLL`
[INFO] [stderr]   --> src/ntp/mod.rs:19:1
[INFO] [stderr]    |
[INFO] [stderr] 19 | pub const MAXPOLL: u8 = 17;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `MAXDISP`
[INFO] [stderr]   --> src/ntp/mod.rs:22:1
[INFO] [stderr]    |
[INFO] [stderr] 22 | pub const MAXDISP: u8 = 16;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `MINDISP`
[INFO] [stderr]   --> src/ntp/mod.rs:25:1
[INFO] [stderr]    |
[INFO] [stderr] 25 | pub const MINDISP: f32 = 0.005;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `MAXDIST`
[INFO] [stderr]   --> src/ntp/mod.rs:28:1
[INFO] [stderr]    |
[INFO] [stderr] 28 | pub const MAXDIST: u8 = 1;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/daesock.rs:51:7
[INFO] [stderr]    |
[INFO] [stderr] 51 |   let ref ip = network_cfg.ip;
[INFO] [stderr]    |   ----^^^^^^------------------ help: try: `let ip = &network_cfg.ip;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/ntp/pkt.rs:204:10
[INFO] [stderr]     |
[INFO] [stderr] 204 |       if ext.len() > 0 {
[INFO] [stderr]     |          ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!ext.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `TOLERANCE`
[INFO] [stderr]   --> src/ntp/mod.rs:13:1
[INFO] [stderr]    |
[INFO] [stderr] 13 | pub const TOLERANCE: f32 = 15e-6;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `MINPOLL`
[INFO] [stderr]   --> src/ntp/mod.rs:16:1
[INFO] [stderr]    |
[INFO] [stderr] 16 | pub const MINPOLL: u8 = 4;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `MAXPOLL`
[INFO] [stderr]   --> src/ntp/mod.rs:19:1
[INFO] [stderr]    |
[INFO] [stderr] 19 | pub const MAXPOLL: u8 = 17;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `MAXDISP`
[INFO] [stderr]   --> src/ntp/mod.rs:22:1
[INFO] [stderr]    |
[INFO] [stderr] 22 | pub const MAXDISP: u8 = 16;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `MINDISP`
[INFO] [stderr]   --> src/ntp/mod.rs:25:1
[INFO] [stderr]    |
[INFO] [stderr] 25 | pub const MINDISP: f32 = 0.005;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `MAXDIST`
[INFO] [stderr]   --> src/ntp/mod.rs:28:1
[INFO] [stderr]    |
[INFO] [stderr] 28 | pub const MAXDIST: u8 = 1;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/daesock.rs:51:7
[INFO] [stderr]    |
[INFO] [stderr] 51 |   let ref ip = network_cfg.ip;
[INFO] [stderr]    |   ----^^^^^^------------------ help: try: `let ip = &network_cfg.ip;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/ntp/pkt.rs:204:10
[INFO] [stderr]     |
[INFO] [stderr] 204 |       if ext.len() > 0 {
[INFO] [stderr]     |          ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!ext.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 24.21s
[INFO] running `"docker" "inspect" "0491647c5a4040ed9368484d033a0ab7167bcf64ae9174dc9709e2400534baa1"`
[INFO] running `"docker" "rm" "-f" "0491647c5a4040ed9368484d033a0ab7167bcf64ae9174dc9709e2400534baa1"`
[INFO] [stdout] 0491647c5a4040ed9368484d033a0ab7167bcf64ae9174dc9709e2400534baa1