[INFO] updating cached repository nsmryan/ccsds_primary_header
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/nsmryan/ccsds_primary_header
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/nsmryan/ccsds_primary_header" "work/ex/clippy-test-run/sources/stable/gh/nsmryan/ccsds_primary_header"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nsmryan/ccsds_primary_header'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/nsmryan/ccsds_primary_header" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nsmryan/ccsds_primary_header"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nsmryan/ccsds_primary_header'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] e3f6f316ae0422cf64827300cd8b90e3addbac7d
[INFO] sha for GitHub repo nsmryan/ccsds_primary_header: e3f6f316ae0422cf64827300cd8b90e3addbac7d
[INFO] validating manifest of nsmryan/ccsds_primary_header on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of nsmryan/ccsds_primary_header on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing nsmryan/ccsds_primary_header
[INFO] finished frobbing nsmryan/ccsds_primary_header
[INFO] frobbed toml for nsmryan/ccsds_primary_header written to work/ex/clippy-test-run/sources/stable/gh/nsmryan/ccsds_primary_header/Cargo.toml
[INFO] started frobbing nsmryan/ccsds_primary_header
[INFO] finished frobbing nsmryan/ccsds_primary_header
[INFO] frobbed toml for nsmryan/ccsds_primary_header written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nsmryan/ccsds_primary_header/Cargo.toml
[INFO] crate nsmryan/ccsds_primary_header has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting nsmryan/ccsds_primary_header against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nsmryan/ccsds_primary_header:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 533f0fa91e4f562a44496c1f7c7a4afd23082eb76c2a65388767010964b6623b
[INFO] running `"docker" "start" "-a" "533f0fa91e4f562a44496c1f7c7a4afd23082eb76c2a65388767010964b6623b"`
[INFO] [stderr]     Checking env_logger v0.5.12
[INFO] [stderr]     Checking quickcheck v0.6.2
[INFO] [stderr]     Checking ccsds_primary_header v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:237:20
[INFO] [stderr]     |
[INFO] [stderr] 237 |     pub fn version(&self) -> u16 {
[INFO] [stderr]     |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:247:24
[INFO] [stderr]     |
[INFO] [stderr] 247 |     pub fn packet_type(&self) -> PacketType {
[INFO] [stderr]     |                        ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:257:34
[INFO] [stderr]     |
[INFO] [stderr] 257 |     pub fn secondary_header_flag(&self) -> SecondaryHeaderFlag {
[INFO] [stderr]     |                                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:267:17
[INFO] [stderr]     |
[INFO] [stderr] 267 |     pub fn apid(&self) -> u16 {
[INFO] [stderr]     |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:292:26
[INFO] [stderr]     |
[INFO] [stderr] 292 |     pub fn sequence_type(&self) -> SeqFlag {
[INFO] [stderr]     |                          ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:302:27
[INFO] [stderr]     |
[INFO] [stderr] 302 |     pub fn sequence_count(&self) -> u16 {
[INFO] [stderr]     |                           ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:327:25
[INFO] [stderr]     |
[INFO] [stderr] 327 |     pub fn length_field(&self) -> u16 {
[INFO] [stderr]     |                         ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:361:26
[INFO] [stderr]     |
[INFO] [stderr] 361 |     pub fn packet_length(&self) -> u16 {
[INFO] [stderr]     |                          ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:237:20
[INFO] [stderr]     |
[INFO] [stderr] 237 |     pub fn version(&self) -> u16 {
[INFO] [stderr]     |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:247:24
[INFO] [stderr]     |
[INFO] [stderr] 247 |     pub fn packet_type(&self) -> PacketType {
[INFO] [stderr]     |                        ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:257:34
[INFO] [stderr]     |
[INFO] [stderr] 257 |     pub fn secondary_header_flag(&self) -> SecondaryHeaderFlag {
[INFO] [stderr]     |                                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:267:17
[INFO] [stderr]     |
[INFO] [stderr] 267 |     pub fn apid(&self) -> u16 {
[INFO] [stderr]     |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:292:26
[INFO] [stderr]     |
[INFO] [stderr] 292 |     pub fn sequence_type(&self) -> SeqFlag {
[INFO] [stderr]     |                          ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:302:27
[INFO] [stderr]     |
[INFO] [stderr] 302 |     pub fn sequence_count(&self) -> u16 {
[INFO] [stderr]     |                           ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:327:25
[INFO] [stderr]     |
[INFO] [stderr] 327 |     pub fn length_field(&self) -> u16 {
[INFO] [stderr]     |                         ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:361:26
[INFO] [stderr]     |
[INFO] [stderr] 361 |     pub fn packet_length(&self) -> u16 {
[INFO] [stderr]     |                          ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 6.39s
[INFO] running `"docker" "inspect" "533f0fa91e4f562a44496c1f7c7a4afd23082eb76c2a65388767010964b6623b"`
[INFO] running `"docker" "rm" "-f" "533f0fa91e4f562a44496c1f7c7a4afd23082eb76c2a65388767010964b6623b"`
[INFO] [stdout] 533f0fa91e4f562a44496c1f7c7a4afd23082eb76c2a65388767010964b6623b