[INFO] updating cached repository nrxus/stock_clerk [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nrxus/stock_clerk [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nrxus/stock_clerk" "work/ex/clippy-test-run/sources/stable/gh/nrxus/stock_clerk"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nrxus/stock_clerk'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nrxus/stock_clerk" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nrxus/stock_clerk"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nrxus/stock_clerk'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3bb20657f154191bc6e44410e34fed6ce2ab2735 [INFO] sha for GitHub repo nrxus/stock_clerk: 3bb20657f154191bc6e44410e34fed6ce2ab2735 [INFO] validating manifest of nrxus/stock_clerk on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nrxus/stock_clerk on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nrxus/stock_clerk [INFO] finished frobbing nrxus/stock_clerk [INFO] frobbed toml for nrxus/stock_clerk written to work/ex/clippy-test-run/sources/stable/gh/nrxus/stock_clerk/Cargo.toml [INFO] started frobbing nrxus/stock_clerk [INFO] finished frobbing nrxus/stock_clerk [INFO] frobbed toml for nrxus/stock_clerk written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nrxus/stock_clerk/Cargo.toml [INFO] crate nrxus/stock_clerk has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nrxus/stock_clerk against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nrxus/stock_clerk:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6a98e40d87d19802cfb5a99417fb72b329a82b296ad5b75799f86a22ae8f80ff [INFO] running `"docker" "start" "-a" "6a98e40d87d19802cfb5a99417fb72b329a82b296ad5b75799f86a22ae8f80ff"` [INFO] [stderr] Compiling serde v1.0.71 [INFO] [stderr] Checking array-macro v1.0.2 [INFO] [stderr] Checking reexport-proc-macro v1.0.5 [INFO] [stderr] Checking encoding_rs v0.7.2 [INFO] [stderr] Checking uuid v0.6.5 [INFO] [stderr] Checking csv v0.15.0 [INFO] [stderr] Checking want v0.0.4 [INFO] [stderr] Checking mio v0.6.15 [INFO] [stderr] Compiling quote v0.6.5 [INFO] [stderr] Checking tokio-io v0.1.7 [INFO] [stderr] Checking mime v0.3.8 [INFO] [stderr] Checking prettytable-rs v0.7.0 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Compiling syn v0.14.7 [INFO] [stderr] Checking tokio-threadpool v0.1.5 [INFO] [stderr] Checking mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking tokio-reactor v0.1.3 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Checking tokio-udp v0.1.1 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Compiling serde_derive v1.0.71 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Compiling enum-map-derive v0.4.0 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking serde_urlencoded v0.5.2 [INFO] [stderr] Checking serde_json v1.0.24 [INFO] [stderr] Checking docopt v1.0.0 [INFO] [stderr] Checking enum-map v0.4.1 [INFO] [stderr] Checking chrono v0.4.5 [INFO] [stderr] Checking reqwest v0.8.7 [INFO] [stderr] Checking stock_clerk v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/taxes.rs:103:34 [INFO] [stderr] | [INFO] [stderr] 103 | income: Dollars::new(170000.0), [INFO] [stderr] | ^^^^^^^^ help: consider: `170_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/taxes.rs:121:34 [INFO] [stderr] | [INFO] [stderr] 121 | income: Dollars::new(170000.0), [INFO] [stderr] | ^^^^^^^^ help: consider: `170_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/taxes.rs:157:34 [INFO] [stderr] | [INFO] [stderr] 157 | income: Dollars::new(520000.0), [INFO] [stderr] | ^^^^^^^^ help: consider: `520_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/taxes.rs:168:53 [INFO] [stderr] | [INFO] [stderr] 168 | assert_eq!(taxed_value.amount, Dollars::new(300000.0)); [INFO] [stderr] | ^^^^^^^^ help: consider: `300_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Sub` impl [INFO] [stderr] --> src/dollars.rs:67:31 [INFO] [stderr] | [INFO] [stderr] 67 | cents: (cents + 100) as u8, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/dollars.rs:87:30 [INFO] [stderr] | [INFO] [stderr] 87 | cents: cents - 100, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/dollars.rs:126:15 [INFO] [stderr] | [INFO] [stderr] 126 | whole + cents [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/dollars.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | assert_eq!(amount / divisor, 2.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/dollars.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | assert_eq!(amount / divisor, 2.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Sub` impl [INFO] [stderr] --> src/dollars.rs:67:31 [INFO] [stderr] | [INFO] [stderr] 67 | cents: (cents + 100) as u8, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/dollars.rs:87:30 [INFO] [stderr] | [INFO] [stderr] 87 | cents: cents - 100, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/dollars.rs:126:15 [INFO] [stderr] | [INFO] [stderr] 126 | whole + cents [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:86:22 [INFO] [stderr] | [INFO] [stderr] 86 | .context(format!( [INFO] [stderr] | ______________________^ [INFO] [stderr] 87 | | "Failed to fetch current PVTL stock price.\nTry passing it with --price PRICE" [INFO] [stderr] 88 | | ))?; [INFO] [stderr] | |_____________^ help: consider using .to_string(): `"Failed to fetch current PVTL stock price.\nTry passing it with --price PRICE".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:107:18 [INFO] [stderr] | [INFO] [stderr] 107 | .context(format!("Failed to make request for PVTL stock price"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Failed to make request for PVTL stock price".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `stock_clerk`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:86:22 [INFO] [stderr] | [INFO] [stderr] 86 | .context(format!( [INFO] [stderr] | ______________________^ [INFO] [stderr] 87 | | "Failed to fetch current PVTL stock price.\nTry passing it with --price PRICE" [INFO] [stderr] 88 | | ))?; [INFO] [stderr] | |_____________^ help: consider using .to_string(): `"Failed to fetch current PVTL stock price.\nTry passing it with --price PRICE".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:107:18 [INFO] [stderr] | [INFO] [stderr] 107 | .context(format!("Failed to make request for PVTL stock price"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Failed to make request for PVTL stock price".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `stock_clerk`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6a98e40d87d19802cfb5a99417fb72b329a82b296ad5b75799f86a22ae8f80ff"` [INFO] running `"docker" "rm" "-f" "6a98e40d87d19802cfb5a99417fb72b329a82b296ad5b75799f86a22ae8f80ff"` [INFO] [stdout] 6a98e40d87d19802cfb5a99417fb72b329a82b296ad5b75799f86a22ae8f80ff