[INFO] updating cached repository npm/shelby [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/npm/shelby [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/npm/shelby" "work/ex/clippy-test-run/sources/stable/gh/npm/shelby"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/npm/shelby'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/npm/shelby" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/npm/shelby"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/npm/shelby'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 06fea2dd56e1b64c3f670e4d58f9843c43faa822 [INFO] sha for GitHub repo npm/shelby: 06fea2dd56e1b64c3f670e4d58f9843c43faa822 [INFO] validating manifest of npm/shelby on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of npm/shelby on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing npm/shelby [INFO] finished frobbing npm/shelby [INFO] frobbed toml for npm/shelby written to work/ex/clippy-test-run/sources/stable/gh/npm/shelby/Cargo.toml [INFO] started frobbing npm/shelby [INFO] finished frobbing npm/shelby [INFO] frobbed toml for npm/shelby written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/npm/shelby/Cargo.toml [INFO] crate npm/shelby has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting npm/shelby against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/npm/shelby:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b6e694d6045aeefc5ad4b0b6d52b8139f8ab378cca73ba974fc97ebec4b6661d [INFO] running `"docker" "start" "-a" "b6e694d6045aeefc5ad4b0b6d52b8139f8ab378cca73ba974fc97ebec4b6661d"` [INFO] [stderr] Checking num_cpus v0.2.13 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking serde_json v0.8.6 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking hyper v0.10.13 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Checking linux-stats v0.2.0 [INFO] [stderr] Checking numbat v1.0.0 [INFO] [stderr] Checking timer v0.1.6 [INFO] [stderr] Checking shelby v1.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plugins/heartbeat.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | emitter: emitter [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `emitter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plugins/load_average.rs:31:7 [INFO] [stderr] | [INFO] [stderr] 31 | emitter: emitter [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `emitter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plugins/heartbeat.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | emitter: emitter [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `emitter` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plugins/memory.rs:16:7 [INFO] [stderr] | [INFO] [stderr] 16 | emitter: emitter [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `emitter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plugins/disk_usage.rs:49:7 [INFO] [stderr] | [INFO] [stderr] 49 | emitter: emitter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `emitter` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plugins/load_average.rs:31:7 [INFO] [stderr] | [INFO] [stderr] 31 | emitter: emitter [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `emitter` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plugins/disk_usage.rs:50:7 [INFO] [stderr] | [INFO] [stderr] 50 | mounts: mounts [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `mounts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plugins/memory.rs:16:7 [INFO] [stderr] | [INFO] [stderr] 16 | emitter: emitter [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `emitter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plugins/netstat.rs:14:7 [INFO] [stderr] | [INFO] [stderr] 14 | emitter: emitter [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `emitter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plugins/uptime.rs:16:7 [INFO] [stderr] | [INFO] [stderr] 16 | emitter: emitter [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `emitter` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plugins/disk_usage.rs:49:7 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 49 | emitter: emitter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `emitter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plugins/disk_usage.rs:50:7 [INFO] [stderr] | [INFO] [stderr] 50 | mounts: mounts [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `mounts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plugins/netstat.rs:14:7 [INFO] [stderr] | [INFO] [stderr] 14 | emitter: emitter [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `emitter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plugins/uptime.rs:16:7 [INFO] [stderr] | [INFO] [stderr] 16 | emitter: emitter [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `emitter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/plugins/disk_usage.rs:18:25 [INFO] [stderr] | [INFO] [stderr] 18 | match libc::statvfs(CString::new(mountpoint).unwrap().as_ptr(), &mut stats) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/plugins/disk_usage.rs:18:25 [INFO] [stderr] | [INFO] [stderr] 18 | match libc::statvfs(CString::new(mountpoint).unwrap().as_ptr(), &mut stats) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/plugins/disk_usage.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / match usage { [INFO] [stderr] 63 | | Ok(u) => { [INFO] [stderr] 64 | | self.emitter.emit(&(String::from("disk-usage.") + mountpoint), u.blocks); [INFO] [stderr] 65 | | self.emitter.emit(&(String::from("inode-usage.") + mountpoint), u.inodes); [INFO] [stderr] 66 | | }, [INFO] [stderr] 67 | | Err(_) => {} [INFO] [stderr] 68 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | if let Ok(u) = usage { [INFO] [stderr] 63 | self.emitter.emit(&(String::from("disk-usage.") + mountpoint), u.blocks); [INFO] [stderr] 64 | self.emitter.emit(&(String::from("inode-usage.") + mountpoint), u.inodes); [INFO] [stderr] 65 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/plugins/netstat.rs:20:8 [INFO] [stderr] | [INFO] [stderr] 20 | if !check.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `check.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `shelby`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/plugins/disk_usage.rs:18:25 [INFO] [stderr] | [INFO] [stderr] 18 | match libc::statvfs(CString::new(mountpoint).unwrap().as_ptr(), &mut stats) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/plugins/disk_usage.rs:18:25 [INFO] [stderr] | [INFO] [stderr] 18 | match libc::statvfs(CString::new(mountpoint).unwrap().as_ptr(), &mut stats) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/plugins/disk_usage.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / match usage { [INFO] [stderr] 63 | | Ok(u) => { [INFO] [stderr] 64 | | self.emitter.emit(&(String::from("disk-usage.") + mountpoint), u.blocks); [INFO] [stderr] 65 | | self.emitter.emit(&(String::from("inode-usage.") + mountpoint), u.inodes); [INFO] [stderr] 66 | | }, [INFO] [stderr] 67 | | Err(_) => {} [INFO] [stderr] 68 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | if let Ok(u) = usage { [INFO] [stderr] 63 | self.emitter.emit(&(String::from("disk-usage.") + mountpoint), u.blocks); [INFO] [stderr] 64 | self.emitter.emit(&(String::from("inode-usage.") + mountpoint), u.inodes); [INFO] [stderr] 65 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/plugins/netstat.rs:20:8 [INFO] [stderr] | [INFO] [stderr] 20 | if !check.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `check.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `shelby`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "b6e694d6045aeefc5ad4b0b6d52b8139f8ab378cca73ba974fc97ebec4b6661d"` [INFO] running `"docker" "rm" "-f" "b6e694d6045aeefc5ad4b0b6d52b8139f8ab378cca73ba974fc97ebec4b6661d"` [INFO] [stdout] b6e694d6045aeefc5ad4b0b6d52b8139f8ab378cca73ba974fc97ebec4b6661d