[INFO] updating cached repository noxecane/raycane [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/noxecane/raycane [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/noxecane/raycane" "work/ex/clippy-test-run/sources/stable/gh/noxecane/raycane"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/noxecane/raycane'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/noxecane/raycane" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/noxecane/raycane"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/noxecane/raycane'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fd4fdfe719f422a1f557afa97b867136b44fbfd4 [INFO] sha for GitHub repo noxecane/raycane: fd4fdfe719f422a1f557afa97b867136b44fbfd4 [INFO] validating manifest of noxecane/raycane on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of noxecane/raycane on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing noxecane/raycane [INFO] finished frobbing noxecane/raycane [INFO] frobbed toml for noxecane/raycane written to work/ex/clippy-test-run/sources/stable/gh/noxecane/raycane/Cargo.toml [INFO] started frobbing noxecane/raycane [INFO] finished frobbing noxecane/raycane [INFO] frobbed toml for noxecane/raycane written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/noxecane/raycane/Cargo.toml [INFO] crate noxecane/raycane has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting noxecane/raycane against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/noxecane/raycane:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4c98fd850efb3bd79c30cabde4f302f523dd84490d5f48569341ae5f5a49ec8d [INFO] running `"docker" "start" "-a" "4c98fd850efb3bd79c30cabde4f302f523dd84490d5f48569341ae5f5a49ec8d"` [INFO] [stderr] Checking rand v0.3.19 [INFO] [stderr] Checking mio v0.6.11 [INFO] [stderr] Checking ws v0.7.3 [INFO] [stderr] Checking raycane v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/io.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / pub fn new(address: &str) { [INFO] [stderr] 53 | | ws::listen(address, |out| { Server { out }}).unwrap(); [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/io.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / pub fn new(address: &str) { [INFO] [stderr] 59 | | let mut client_address = String::from("ws://"); [INFO] [stderr] 60 | | client_address.push_str(address); [INFO] [stderr] 61 | | ws::connect(client_address, |out| { Client { out }}).unwrap(); [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:7:18 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn run(args: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/io.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / pub fn new(address: &str) { [INFO] [stderr] 53 | | ws::listen(address, |out| { Server { out }}).unwrap(); [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/io.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / pub fn new(address: &str) { [INFO] [stderr] 59 | | let mut client_address = String::from("ws://"); [INFO] [stderr] 60 | | client_address.push_str(address); [INFO] [stderr] 61 | | ws::connect(client_address, |out| { Client { out }}).unwrap(); [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:7:18 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn run(args: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.00s [INFO] running `"docker" "inspect" "4c98fd850efb3bd79c30cabde4f302f523dd84490d5f48569341ae5f5a49ec8d"` [INFO] running `"docker" "rm" "-f" "4c98fd850efb3bd79c30cabde4f302f523dd84490d5f48569341ae5f5a49ec8d"` [INFO] [stdout] 4c98fd850efb3bd79c30cabde4f302f523dd84490d5f48569341ae5f5a49ec8d