[INFO] updating cached repository noxecane/agenda
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/noxecane/agenda
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/noxecane/agenda" "work/ex/clippy-test-run/sources/stable/gh/noxecane/agenda"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/noxecane/agenda'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/noxecane/agenda" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/noxecane/agenda"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/noxecane/agenda'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 5561692d8c330b4f97c12ae04136b03a30796725
[INFO] sha for GitHub repo noxecane/agenda: 5561692d8c330b4f97c12ae04136b03a30796725
[INFO] validating manifest of noxecane/agenda on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of noxecane/agenda on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing noxecane/agenda
[INFO] finished frobbing noxecane/agenda
[INFO] frobbed toml for noxecane/agenda written to work/ex/clippy-test-run/sources/stable/gh/noxecane/agenda/Cargo.toml
[INFO] started frobbing noxecane/agenda
[INFO] finished frobbing noxecane/agenda
[INFO] frobbed toml for noxecane/agenda written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/noxecane/agenda/Cargo.toml
[INFO] crate noxecane/agenda has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting noxecane/agenda against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/noxecane/agenda:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] fd569f47eccc0a882df1cfee00b6064c48803af62862187cee01132ac32640bd
[INFO] running `"docker" "start" "-a" "fd569f47eccc0a882df1cfee00b6064c48803af62862187cee01132ac32640bd"`
[INFO] [stderr]     Checking agenda v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]   --> src/terminal.rs:51:13
[INFO] [stderr]    |
[INFO] [stderr] 51 |             print!("Control character - {}\r\n", c);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]   --> src/terminal.rs:51:13
[INFO] [stderr]    |
[INFO] [stderr] 51 |             print!("Control character - {}\r\n", c);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]   --> src/terminal.rs:53:13
[INFO] [stderr]    |
[INFO] [stderr] 53 |             print!("Normal character - {} as {}\r\n", c as char, c);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]   --> src/terminal.rs:53:13
[INFO] [stderr]    |
[INFO] [stderr] 53 |             print!("Normal character - {} as {}\r\n", c as char, c);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/terminal.rs:28:23
[INFO] [stderr]    |
[INFO] [stderr] 28 |         term_backup = term.clone();
[INFO] [stderr]    |                       ^^^^^^^^^^^^ help: try removing the `clone` call: `term`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `libc::tcsetattr` doesn't need a mutable reference
[INFO] [stderr]   --> src/terminal.rs:33:46
[INFO] [stderr]    |
[INFO] [stderr] 33 |         libc::tcsetattr(fd, libc::TCSAFLUSH, &mut term);
[INFO] [stderr]    |                                              ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `libc::tcsetattr` doesn't need a mutable reference
[INFO] [stderr]   --> src/terminal.rs:40:46
[INFO] [stderr]    |
[INFO] [stderr] 40 |         libc::tcsetattr(fd, libc::TCSAFLUSH, &mut term);
[INFO] [stderr]    |                                              ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/terminal.rs:50:26
[INFO] [stderr]    |
[INFO] [stderr] 50 |         if libc::iscntrl(c as i32) != 0 {
[INFO] [stderr]    |                          ^^^^^^^^ help: try: `i32::from(c)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/terminal.rs:67:5
[INFO] [stderr]    |
[INFO] [stderr] 67 | /     loop {
[INFO] [stderr] 68 | |         match handle.read(&mut buf) {
[INFO] [stderr] 69 | |             Ok(_) => {
[INFO] [stderr] 70 | |                 if !read_char(buf[0]) {
[INFO] [stderr] ...  |
[INFO] [stderr] 75 | |         }
[INFO] [stderr] 76 | |     }
[INFO] [stderr]    | |_____^ help: try: `while let Ok(_) = handle.read(&mut buf) { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/terminal.rs:28:23
[INFO] [stderr]    |
[INFO] [stderr] 28 |         term_backup = term.clone();
[INFO] [stderr]    |                       ^^^^^^^^^^^^ help: try removing the `clone` call: `term`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `libc::tcsetattr` doesn't need a mutable reference
[INFO] [stderr]   --> src/terminal.rs:33:46
[INFO] [stderr]    |
[INFO] [stderr] 33 |         libc::tcsetattr(fd, libc::TCSAFLUSH, &mut term);
[INFO] [stderr]    |                                              ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `libc::tcsetattr` doesn't need a mutable reference
[INFO] [stderr]   --> src/terminal.rs:40:46
[INFO] [stderr]    |
[INFO] [stderr] 40 |         libc::tcsetattr(fd, libc::TCSAFLUSH, &mut term);
[INFO] [stderr]    |                                              ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/terminal.rs:50:26
[INFO] [stderr]    |
[INFO] [stderr] 50 |         if libc::iscntrl(c as i32) != 0 {
[INFO] [stderr]    |                          ^^^^^^^^ help: try: `i32::from(c)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/terminal.rs:67:5
[INFO] [stderr]    |
[INFO] [stderr] 67 | /     loop {
[INFO] [stderr] 68 | |         match handle.read(&mut buf) {
[INFO] [stderr] 69 | |             Ok(_) => {
[INFO] [stderr] 70 | |                 if !read_char(buf[0]) {
[INFO] [stderr] ...  |
[INFO] [stderr] 75 | |         }
[INFO] [stderr] 76 | |     }
[INFO] [stderr]    | |_____^ help: try: `while let Ok(_) = handle.read(&mut buf) { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.32s
[INFO] running `"docker" "inspect" "fd569f47eccc0a882df1cfee00b6064c48803af62862187cee01132ac32640bd"`
[INFO] running `"docker" "rm" "-f" "fd569f47eccc0a882df1cfee00b6064c48803af62862187cee01132ac32640bd"`
[INFO] [stdout] fd569f47eccc0a882df1cfee00b6064c48803af62862187cee01132ac32640bd