[INFO] updating cached repository nouwaarom/ArmController [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nouwaarom/ArmController [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nouwaarom/ArmController" "work/ex/clippy-test-run/sources/stable/gh/nouwaarom/ArmController"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nouwaarom/ArmController'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nouwaarom/ArmController" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nouwaarom/ArmController"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nouwaarom/ArmController'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0bec050986e1fa3300e9c8e65a98e94743e20728 [INFO] sha for GitHub repo nouwaarom/ArmController: 0bec050986e1fa3300e9c8e65a98e94743e20728 [INFO] validating manifest of nouwaarom/ArmController on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nouwaarom/ArmController on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nouwaarom/ArmController [INFO] finished frobbing nouwaarom/ArmController [INFO] frobbed toml for nouwaarom/ArmController written to work/ex/clippy-test-run/sources/stable/gh/nouwaarom/ArmController/Cargo.toml [INFO] started frobbing nouwaarom/ArmController [INFO] finished frobbing nouwaarom/ArmController [INFO] frobbed toml for nouwaarom/ArmController written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nouwaarom/ArmController/Cargo.toml [INFO] crate nouwaarom/ArmController has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nouwaarom/ArmController against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nouwaarom/ArmController:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c589bb47094ecc049fc7a2f0dd4dfbd0b7266a4b5d31cdf7a8aa71fa37f6d123 [INFO] running `"docker" "start" "-a" "c589bb47094ecc049fc7a2f0dd4dfbd0b7266a4b5d31cdf7a8aa71fa37f6d123"` [INFO] [stderr] Checking arm_controller v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `size_t` [INFO] [stderr] --> src/lib.rs:5:12 [INFO] [stderr] | [INFO] [stderr] 5 | use libc::{size_t}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return 1; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `size_t` [INFO] [stderr] --> src/lib.rs:5:12 [INFO] [stderr] | [INFO] [stderr] 5 | use libc::{size_t}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return 1; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `position` [INFO] [stderr] --> src/lib.rs:41:49 [INFO] [stderr] | [INFO] [stderr] 41 | pub extern fn set_desired_end_effector_position(position: Vec, rotation: Vec) [INFO] [stderr] | ^^^^^^^^ help: consider using `_position` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rotation` [INFO] [stderr] --> src/lib.rs:41:69 [INFO] [stderr] | [INFO] [stderr] 41 | pub extern fn set_desired_end_effector_position(position: Vec, rotation: Vec) [INFO] [stderr] | ^^^^^^^^ help: consider using `_rotation` instead [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | joint as f64 * 3.0 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(joint)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:24:31 [INFO] [stderr] | [INFO] [stderr] 24 | slice::from_raw_parts(dh_table, (joint_cnt*4) as usize) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `arm_controller`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `position` [INFO] [stderr] --> src/lib.rs:41:49 [INFO] [stderr] | [INFO] [stderr] 41 | pub extern fn set_desired_end_effector_position(position: Vec, rotation: Vec) [INFO] [stderr] | ^^^^^^^^ help: consider using `_position` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rotation` [INFO] [stderr] --> src/lib.rs:41:69 [INFO] [stderr] | [INFO] [stderr] 41 | pub extern fn set_desired_end_effector_position(position: Vec, rotation: Vec) [INFO] [stderr] | ^^^^^^^^ help: consider using `_rotation` instead [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | joint as f64 * 3.0 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(joint)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:24:31 [INFO] [stderr] | [INFO] [stderr] 24 | slice::from_raw_parts(dh_table, (joint_cnt*4) as usize) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `arm_controller`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c589bb47094ecc049fc7a2f0dd4dfbd0b7266a4b5d31cdf7a8aa71fa37f6d123"` [INFO] running `"docker" "rm" "-f" "c589bb47094ecc049fc7a2f0dd4dfbd0b7266a4b5d31cdf7a8aa71fa37f6d123"` [INFO] [stdout] c589bb47094ecc049fc7a2f0dd4dfbd0b7266a4b5d31cdf7a8aa71fa37f6d123