[INFO] updating cached repository nopjmp/pastabin [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nopjmp/pastabin [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nopjmp/pastabin" "work/ex/clippy-test-run/sources/stable/gh/nopjmp/pastabin"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nopjmp/pastabin'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nopjmp/pastabin" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nopjmp/pastabin"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nopjmp/pastabin'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4eb1a465b4dfd998ace28eb47ab7ba171af70c9f [INFO] sha for GitHub repo nopjmp/pastabin: 4eb1a465b4dfd998ace28eb47ab7ba171af70c9f [INFO] validating manifest of nopjmp/pastabin on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nopjmp/pastabin on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nopjmp/pastabin [INFO] finished frobbing nopjmp/pastabin [INFO] frobbed toml for nopjmp/pastabin written to work/ex/clippy-test-run/sources/stable/gh/nopjmp/pastabin/Cargo.toml [INFO] started frobbing nopjmp/pastabin [INFO] finished frobbing nopjmp/pastabin [INFO] frobbed toml for nopjmp/pastabin written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nopjmp/pastabin/Cargo.toml [INFO] crate nopjmp/pastabin has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nopjmp/pastabin against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nopjmp/pastabin:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 463b79bde593b2950fa9c9ffe93e6f759b420d9b27d1bb7e41e16e8186ce5655 [INFO] running `"docker" "start" "-a" "463b79bde593b2950fa9c9ffe93e6f759b420d9b27d1bb7e41e16e8186ce5655"` [INFO] [stderr] Checking xattr v0.1.11 [INFO] [stderr] Compiling hyper v0.10.9 [INFO] [stderr] Checking idna v0.1.1 [INFO] [stderr] Checking url v1.4.0 [INFO] [stderr] Checking pastabin v0.0.3 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strgen.rs:3:24 [INFO] [stderr] | [INFO] [stderr] 3 | pub const CHARACTERS: &'static [u8] = [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:25:24 [INFO] [stderr] | [INFO] [stderr] 25 | const XATTR_PASSWORD: &'static str = "system.password"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:27:15 [INFO] [stderr] | [INFO] [stderr] 27 | const USAGE: &'static [u8] = b" [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strgen.rs:3:24 [INFO] [stderr] | [INFO] [stderr] 3 | pub const CHARACTERS: &'static [u8] = [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:25:24 [INFO] [stderr] | [INFO] [stderr] 25 | const XATTR_PASSWORD: &'static str = "system.password"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:27:15 [INFO] [stderr] | [INFO] [stderr] 27 | const USAGE: &'static [u8] = b" [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:119:86 [INFO] [stderr] | [INFO] [stderr] 119 | if let Ok(id) = PasteID::from_str(path.trim_left_matches("/")) { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:193:89 [INFO] [stderr] | [INFO] [stderr] 193 | PasteID::from_str(url.path().trim_left_matches("/")), [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/main.rs:198:25 [INFO] [stderr] | [INFO] [stderr] 198 | / if let Some(data) = xattr::get(path, XATTR_PASSWORD).ok() { [INFO] [stderr] 199 | | if password != [INFO] [stderr] 200 | | try_handle!(res, [INFO] [stderr] 201 | | std::str::from_utf8(data.as_slice()), [INFO] [stderr] ... | [INFO] [stderr] 205 | | } [INFO] [stderr] 206 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(data)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:119:86 [INFO] [stderr] | [INFO] [stderr] 119 | if let Ok(id) = PasteID::from_str(path.trim_left_matches("/")) { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:193:89 [INFO] [stderr] | [INFO] [stderr] 193 | PasteID::from_str(url.path().trim_left_matches("/")), [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/main.rs:198:25 [INFO] [stderr] | [INFO] [stderr] 198 | / if let Some(data) = xattr::get(path, XATTR_PASSWORD).ok() { [INFO] [stderr] 199 | | if password != [INFO] [stderr] 200 | | try_handle!(res, [INFO] [stderr] 201 | | std::str::from_utf8(data.as_slice()), [INFO] [stderr] ... | [INFO] [stderr] 205 | | } [INFO] [stderr] 206 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(data)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.16s [INFO] running `"docker" "inspect" "463b79bde593b2950fa9c9ffe93e6f759b420d9b27d1bb7e41e16e8186ce5655"` [INFO] running `"docker" "rm" "-f" "463b79bde593b2950fa9c9ffe93e6f759b420d9b27d1bb7e41e16e8186ce5655"` [INFO] [stdout] 463b79bde593b2950fa9c9ffe93e6f759b420d9b27d1bb7e41e16e8186ce5655