[INFO] updating cached repository noogen-projects/reactor [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/noogen-projects/reactor [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/noogen-projects/reactor" "work/ex/clippy-test-run/sources/stable/gh/noogen-projects/reactor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/noogen-projects/reactor'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/noogen-projects/reactor" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/noogen-projects/reactor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/noogen-projects/reactor'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cd512a38e0d378816dcfe460215c589a6b3c8dcf [INFO] sha for GitHub repo noogen-projects/reactor: cd512a38e0d378816dcfe460215c589a6b3c8dcf [INFO] validating manifest of noogen-projects/reactor on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of noogen-projects/reactor on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing noogen-projects/reactor [INFO] finished frobbing noogen-projects/reactor [INFO] frobbed toml for noogen-projects/reactor written to work/ex/clippy-test-run/sources/stable/gh/noogen-projects/reactor/Cargo.toml [INFO] started frobbing noogen-projects/reactor [INFO] finished frobbing noogen-projects/reactor [INFO] frobbed toml for noogen-projects/reactor written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/noogen-projects/reactor/Cargo.toml [INFO] crate noogen-projects/reactor has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting noogen-projects/reactor against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/noogen-projects/reactor:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f91cd95716bb2a60c1084997e11e27131c5bee9ac86444237ed1a9f6a0d039bb [INFO] running `"docker" "start" "-a" "f91cd95716bb2a60c1084997e11e27131c5bee9ac86444237ed1a9f6a0d039bb"` [INFO] [stderr] Compiling cgmath v0.16.1 [INFO] [stderr] Compiling log v0.4.1 [INFO] [stderr] Compiling cmake v0.1.30 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Checking semver v0.2.3 [INFO] [stderr] Checking num-bigint v0.1.43 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Compiling glfw-sys v3.2.2 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking glfw v0.21.0 [INFO] [stderr] Checking reactor v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/engine/shader.rs:25:54 [INFO] [stderr] | [INFO] [stderr] 25 | let mut vShaderFile = File::open(vertexPath).expect(&format!("Failed to open {}", vertexPath)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to open {}", vertexPath))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/engine/shader.rs:26:56 [INFO] [stderr] | [INFO] [stderr] 26 | let mut fShaderFile = File::open(fragmentPath).expect(&format!("Failed to open {}", fragmentPath)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to open {}", fragmentPath))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/engine/shader.rs:105:27 [INFO] [stderr] | [INFO] [stderr] 105 | let mut success = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/engine/shader.rs:110:27 [INFO] [stderr] | [INFO] [stderr] 110 | if success != gl::TRUE as GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/engine/shader.rs:120:27 [INFO] [stderr] | [INFO] [stderr] 120 | if success != gl::TRUE as GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/engine/shader.rs:135:54 [INFO] [stderr] | [INFO] [stderr] 135 | let mut vShaderFile = File::open(vertexPath).expect(&format!("Failed to open {}", vertexPath)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to open {}", vertexPath))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/engine/shader.rs:136:56 [INFO] [stderr] | [INFO] [stderr] 136 | let mut fShaderFile = File::open(fragmentPath).expect(&format!("Failed to open {}", fragmentPath)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to open {}", fragmentPath))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/engine/shader.rs:137:56 [INFO] [stderr] | [INFO] [stderr] 137 | let mut gShaderFile = File::open(geometryPath).expect(&format!("Failed to open {}", geometryPath)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to open {}", geometryPath))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/engine/window.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | / match event { [INFO] [stderr] 189 | | KeyEvent(Key::Escape, _, Action::Press, _) => self.window.set_should_close(true), [INFO] [stderr] 190 | | _ => () [INFO] [stderr] 191 | | } [INFO] [stderr] | |_________^ help: try this: `if let KeyEvent(Key::Escape, _, Action::Press, _) = event { self.window.set_should_close(true) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/engine/shader.rs:25:54 [INFO] [stderr] | [INFO] [stderr] 25 | let mut vShaderFile = File::open(vertexPath).expect(&format!("Failed to open {}", vertexPath)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to open {}", vertexPath))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/engine/shader.rs:26:56 [INFO] [stderr] | [INFO] [stderr] 26 | let mut fShaderFile = File::open(fragmentPath).expect(&format!("Failed to open {}", fragmentPath)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to open {}", fragmentPath))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/engine/shader.rs:105:27 [INFO] [stderr] | [INFO] [stderr] 105 | let mut success = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/engine/shader.rs:110:27 [INFO] [stderr] | [INFO] [stderr] 110 | if success != gl::TRUE as GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/engine/shader.rs:120:27 [INFO] [stderr] | [INFO] [stderr] 120 | if success != gl::TRUE as GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/engine/shader.rs:135:54 [INFO] [stderr] | [INFO] [stderr] 135 | let mut vShaderFile = File::open(vertexPath).expect(&format!("Failed to open {}", vertexPath)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to open {}", vertexPath))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/engine/shader.rs:136:56 [INFO] [stderr] | [INFO] [stderr] 136 | let mut fShaderFile = File::open(fragmentPath).expect(&format!("Failed to open {}", fragmentPath)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to open {}", fragmentPath))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/engine/shader.rs:137:56 [INFO] [stderr] | [INFO] [stderr] 137 | let mut gShaderFile = File::open(geometryPath).expect(&format!("Failed to open {}", geometryPath)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to open {}", geometryPath))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/engine/window.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | / match event { [INFO] [stderr] 189 | | KeyEvent(Key::Escape, _, Action::Press, _) => self.window.set_should_close(true), [INFO] [stderr] 190 | | _ => () [INFO] [stderr] 191 | | } [INFO] [stderr] | |_________^ help: try this: `if let KeyEvent(Key::Escape, _, Action::Press, _) = event { self.window.set_should_close(true) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.83s [INFO] running `"docker" "inspect" "f91cd95716bb2a60c1084997e11e27131c5bee9ac86444237ed1a9f6a0d039bb"` [INFO] running `"docker" "rm" "-f" "f91cd95716bb2a60c1084997e11e27131c5bee9ac86444237ed1a9f6a0d039bb"` [INFO] [stdout] f91cd95716bb2a60c1084997e11e27131c5bee9ac86444237ed1a9f6a0d039bb