[INFO] updating cached repository noc7c9/pyfection [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/noc7c9/pyfection [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/noc7c9/pyfection" "work/ex/clippy-test-run/sources/stable/gh/noc7c9/pyfection"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/noc7c9/pyfection'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/noc7c9/pyfection" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/noc7c9/pyfection"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/noc7c9/pyfection'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5a65a4a6bc39410a9153afa0bb5c511d1ebf285b [INFO] sha for GitHub repo noc7c9/pyfection: 5a65a4a6bc39410a9153afa0bb5c511d1ebf285b [INFO] validating manifest of noc7c9/pyfection on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of noc7c9/pyfection on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing noc7c9/pyfection [INFO] finished frobbing noc7c9/pyfection [INFO] frobbed toml for noc7c9/pyfection written to work/ex/clippy-test-run/sources/stable/gh/noc7c9/pyfection/Cargo.toml [INFO] started frobbing noc7c9/pyfection [INFO] finished frobbing noc7c9/pyfection [INFO] frobbed toml for noc7c9/pyfection written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/noc7c9/pyfection/Cargo.toml [INFO] crate noc7c9/pyfection has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting noc7c9/pyfection against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/noc7c9/pyfection:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 96216a9b9a4bd04e5df652ac6e60b9f345116d6ef9272bf09dcd4c6a9856e5fe [INFO] running `"docker" "start" "-a" "96216a9b9a4bd04e5df652ac6e60b9f345116d6ef9272bf09dcd4c6a9856e5fe"` [INFO] [stderr] Checking unindent v0.1.0 [INFO] [stderr] Checking pyfection v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / return TokenList { [INFO] [stderr] 40 | | tokens: Vec::new(), [INFO] [stderr] 41 | | indent_stack: Vec::new(), [INFO] [stderr] 42 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 39 | TokenList { [INFO] [stderr] 40 | tokens: Vec::new(), [INFO] [stderr] 41 | indent_stack: Vec::new(), [INFO] [stderr] 42 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:199:5 [INFO] [stderr] | [INFO] [stderr] 199 | return token_list.tokens; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `token_list.tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:251:5 [INFO] [stderr] | [INFO] [stderr] 251 | return output; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:269:5 [INFO] [stderr] | [INFO] [stderr] 269 | return code; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:277:5 [INFO] [stderr] | [INFO] [stderr] 277 | return code; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:282:5 [INFO] [stderr] | [INFO] [stderr] 282 | return process(code); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process(code)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:299:5 [INFO] [stderr] | [INFO] [stderr] 299 | / return match file.read_to_string(&mut buf) { [INFO] [stderr] 300 | | Err(why) => panic!("couldn't read {}", why.description()), [INFO] [stderr] 301 | | Ok(_) => process(&buf), [INFO] [stderr] 302 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 299 | match file.read_to_string(&mut buf) { [INFO] [stderr] 300 | Err(why) => panic!("couldn't read {}", why.description()), [INFO] [stderr] 301 | Ok(_) => process(&buf), [INFO] [stderr] 302 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / return TokenList { [INFO] [stderr] 40 | | tokens: Vec::new(), [INFO] [stderr] 41 | | indent_stack: Vec::new(), [INFO] [stderr] 42 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 39 | TokenList { [INFO] [stderr] 40 | tokens: Vec::new(), [INFO] [stderr] 41 | indent_stack: Vec::new(), [INFO] [stderr] 42 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:199:5 [INFO] [stderr] | [INFO] [stderr] 199 | return token_list.tokens; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `token_list.tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:251:5 [INFO] [stderr] | [INFO] [stderr] 251 | return output; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:269:5 [INFO] [stderr] | [INFO] [stderr] 269 | return code; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:277:5 [INFO] [stderr] | [INFO] [stderr] 277 | return code; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:282:5 [INFO] [stderr] | [INFO] [stderr] 282 | return process(code); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process(code)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:299:5 [INFO] [stderr] | [INFO] [stderr] 299 | / return match file.read_to_string(&mut buf) { [INFO] [stderr] 300 | | Err(why) => panic!("couldn't read {}", why.description()), [INFO] [stderr] 301 | | Ok(_) => process(&buf), [INFO] [stderr] 302 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 299 | match file.read_to_string(&mut buf) { [INFO] [stderr] 300 | Err(why) => panic!("couldn't read {}", why.description()), [INFO] [stderr] 301 | Ok(_) => process(&buf), [INFO] [stderr] 302 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | let r = iter.peek().map(|c| *c); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `iter.peek().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:117:24 [INFO] [stderr] | [INFO] [stderr] 117 | if buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:202:37 [INFO] [stderr] | [INFO] [stderr] 202 | fn index_of_last_code_token(tokens: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:254:26 [INFO] [stderr] | [INFO] [stderr] 254 | fn generate_code(tokens: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | / match tok { [INFO] [stderr] 259 | | &Token::Code(ref string) => code.push_str(&string), [INFO] [stderr] 260 | | &Token::Whitespace(ref string) => code.push_str(&string), [INFO] [stderr] 261 | | &Token::Newline => code.push('\n'), [INFO] [stderr] ... | [INFO] [stderr] 265 | | &Token::CloseBrace => code.push('}'), [INFO] [stderr] 266 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 258 | match *tok { [INFO] [stderr] 259 | Token::Code(ref string) => code.push_str(&string), [INFO] [stderr] 260 | Token::Whitespace(ref string) => code.push_str(&string), [INFO] [stderr] 261 | Token::Newline => code.push('\n'), [INFO] [stderr] 262 | Token::Indent(ref string) => code.push_str(&string), [INFO] [stderr] 263 | Token::Dedent => (), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | let r = iter.peek().map(|c| *c); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `iter.peek().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:117:24 [INFO] [stderr] | [INFO] [stderr] 117 | if buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:202:37 [INFO] [stderr] | [INFO] [stderr] 202 | fn index_of_last_code_token(tokens: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:254:26 [INFO] [stderr] | [INFO] [stderr] 254 | fn generate_code(tokens: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | / match tok { [INFO] [stderr] 259 | | &Token::Code(ref string) => code.push_str(&string), [INFO] [stderr] 260 | | &Token::Whitespace(ref string) => code.push_str(&string), [INFO] [stderr] 261 | | &Token::Newline => code.push('\n'), [INFO] [stderr] ... | [INFO] [stderr] 265 | | &Token::CloseBrace => code.push('}'), [INFO] [stderr] 266 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 258 | match *tok { [INFO] [stderr] 259 | Token::Code(ref string) => code.push_str(&string), [INFO] [stderr] 260 | Token::Whitespace(ref string) => code.push_str(&string), [INFO] [stderr] 261 | Token::Newline => code.push('\n'), [INFO] [stderr] 262 | Token::Indent(ref string) => code.push_str(&string), [INFO] [stderr] 263 | Token::Dedent => (), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/lib.rs:412:22 [INFO] [stderr] | [INFO] [stderr] 412 | let output = input.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 412 | let output = &(*input).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 412 | let output = &str::clone(input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/lib.rs:424:22 [INFO] [stderr] | [INFO] [stderr] 424 | let output = input.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 424 | let output = &(*input).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 424 | let output = &str::clone(input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `pyfection`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "96216a9b9a4bd04e5df652ac6e60b9f345116d6ef9272bf09dcd4c6a9856e5fe"` [INFO] running `"docker" "rm" "-f" "96216a9b9a4bd04e5df652ac6e60b9f345116d6ef9272bf09dcd4c6a9856e5fe"` [INFO] [stdout] 96216a9b9a4bd04e5df652ac6e60b9f345116d6ef9272bf09dcd4c6a9856e5fe