[INFO] updating cached repository noar-t/rsh [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/noar-t/rsh [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/noar-t/rsh" "work/ex/clippy-test-run/sources/stable/gh/noar-t/rsh"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/noar-t/rsh'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/noar-t/rsh" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/noar-t/rsh"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/noar-t/rsh'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] df0a6856e99ed8e9760e3b2b1586715943615a65 [INFO] sha for GitHub repo noar-t/rsh: df0a6856e99ed8e9760e3b2b1586715943615a65 [INFO] validating manifest of noar-t/rsh on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of noar-t/rsh on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing noar-t/rsh [INFO] finished frobbing noar-t/rsh [INFO] frobbed toml for noar-t/rsh written to work/ex/clippy-test-run/sources/stable/gh/noar-t/rsh/Cargo.toml [INFO] started frobbing noar-t/rsh [INFO] finished frobbing noar-t/rsh [INFO] frobbed toml for noar-t/rsh written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/noar-t/rsh/Cargo.toml [INFO] crate noar-t/rsh has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting noar-t/rsh against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/noar-t/rsh:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eb1f9101c0728171c3c4ac013fb4f34f262cbaa9adb17dfea098c086c8636cc3 [INFO] running `"docker" "start" "-a" "eb1f9101c0728171c3c4ac013fb4f34f262cbaa9adb17dfea098c086c8636cc3"` [INFO] [stderr] Checking rsh v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:146:25 [INFO] [stderr] | [INFO] [stderr] 146 | let new_job = Job { process: process, pid: pid, command: String::from("test") }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `process` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:146:43 [INFO] [stderr] | [INFO] [stderr] 146 | let new_job = Job { process: process, pid: pid, command: String::from("test") }; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:146:25 [INFO] [stderr] | [INFO] [stderr] 146 | let new_job = Job { process: process, pid: pid, command: String::from("test") }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `process` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:146:43 [INFO] [stderr] | [INFO] [stderr] 146 | let new_job = Job { process: process, pid: pid, command: String::from("test") }; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused variable: `status` [INFO] [stderr] --> src/main.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | let status = Command::new(command) [INFO] [stderr] | ^^^^^^ help: consider using `_status` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:79:17 [INFO] [stderr] | [INFO] [stderr] 79 | i = i + 1 [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:151:25 [INFO] [stderr] | [INFO] [stderr] 151 | fn print_jobs(job_list: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Job]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused variable: `status` [INFO] [stderr] --> src/main.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | let status = Command::new(command) [INFO] [stderr] | ^^^^^^ help: consider using `_status` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:79:17 [INFO] [stderr] | [INFO] [stderr] 79 | i = i + 1 [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:151:25 [INFO] [stderr] | [INFO] [stderr] 151 | fn print_jobs(job_list: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Job]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.59s [INFO] running `"docker" "inspect" "eb1f9101c0728171c3c4ac013fb4f34f262cbaa9adb17dfea098c086c8636cc3"` [INFO] running `"docker" "rm" "-f" "eb1f9101c0728171c3c4ac013fb4f34f262cbaa9adb17dfea098c086c8636cc3"` [INFO] [stdout] eb1f9101c0728171c3c4ac013fb4f34f262cbaa9adb17dfea098c086c8636cc3