[INFO] updating cached repository noahrinehart/sonic [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/noahrinehart/sonic [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/noahrinehart/sonic" "work/ex/clippy-test-run/sources/stable/gh/noahrinehart/sonic"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/noahrinehart/sonic'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/noahrinehart/sonic" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/noahrinehart/sonic"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/noahrinehart/sonic'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9ed1813c8386b30102f5defbaf6ffdfec0f7f88f [INFO] sha for GitHub repo noahrinehart/sonic: 9ed1813c8386b30102f5defbaf6ffdfec0f7f88f [INFO] validating manifest of noahrinehart/sonic on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of noahrinehart/sonic on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing noahrinehart/sonic [INFO] finished frobbing noahrinehart/sonic [INFO] frobbed toml for noahrinehart/sonic written to work/ex/clippy-test-run/sources/stable/gh/noahrinehart/sonic/Cargo.toml [INFO] started frobbing noahrinehart/sonic [INFO] finished frobbing noahrinehart/sonic [INFO] frobbed toml for noahrinehart/sonic written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/noahrinehart/sonic/Cargo.toml [INFO] crate noahrinehart/sonic has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting noahrinehart/sonic against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/noahrinehart/sonic:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6bd62e75d4b3adafa307b1b126ce725d0a243b66c4c46a0d4c5cc4c531274626 [INFO] running `"docker" "start" "-a" "6bd62e75d4b3adafa307b1b126ce725d0a243b66c4c46a0d4c5cc4c531274626"` [INFO] [stderr] Checking lazy_static v0.2.10 [INFO] [stderr] Checking scan_fmt v0.1.1 [INFO] [stderr] Checking separator v0.3.1 [INFO] [stderr] Checking hostname v0.1.3 [INFO] [stderr] Checking iovec v0.1.1 [INFO] [stderr] Checking mustache v0.8.2 [INFO] [stderr] Checking serde_json v1.0.6 [INFO] [stderr] Checking semver v0.8.0 [INFO] [stderr] Checking thread_local v0.3.4 [INFO] [stderr] Checking rust-crypto v0.2.36 [INFO] [stderr] Checking hyper v0.10.13 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking bytes v0.4.5 [INFO] [stderr] Checking mio v0.6.11 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking ws v0.7.3 [INFO] [stderr] Checking textnonce v0.6.3 [INFO] [stderr] Checking iron v0.5.1 [INFO] [stderr] Checking nickel v0.10.0 [INFO] [stderr] Checking mount v0.3.0 [INFO] [stderr] Checking bson v0.10.0 [INFO] [stderr] Checking staticfile v0.4.0 [INFO] [stderr] Checking mongodb v0.3.7 [INFO] [stderr] Checking sonic v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/html_server.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | format!("{}", api_result) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `api_result.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/db.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / db.insert_one(doc.clone(), None) [INFO] [stderr] 25 | | .ok() [INFO] [stderr] 26 | | .expect("Failed to insert document"); [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/html_server.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | format!("{}", api_result) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `api_result.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/db.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / db.insert_one(doc.clone(), None) [INFO] [stderr] 25 | | .ok() [INFO] [stderr] 26 | | .expect("Failed to insert document"); [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 26.80s [INFO] running `"docker" "inspect" "6bd62e75d4b3adafa307b1b126ce725d0a243b66c4c46a0d4c5cc4c531274626"` [INFO] running `"docker" "rm" "-f" "6bd62e75d4b3adafa307b1b126ce725d0a243b66c4c46a0d4c5cc4c531274626"` [INFO] [stdout] 6bd62e75d4b3adafa307b1b126ce725d0a243b66c4c46a0d4c5cc4c531274626