[INFO] updating cached repository noahrinehart/mangsh [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/noahrinehart/mangsh [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/noahrinehart/mangsh" "work/ex/clippy-test-run/sources/stable/gh/noahrinehart/mangsh"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/noahrinehart/mangsh'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/noahrinehart/mangsh" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/noahrinehart/mangsh"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/noahrinehart/mangsh'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8acfe5e1e7c10f477f67f55c3af74593aa1e7fee [INFO] sha for GitHub repo noahrinehart/mangsh: 8acfe5e1e7c10f477f67f55c3af74593aa1e7fee [INFO] validating manifest of noahrinehart/mangsh on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of noahrinehart/mangsh on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing noahrinehart/mangsh [INFO] finished frobbing noahrinehart/mangsh [INFO] frobbed toml for noahrinehart/mangsh written to work/ex/clippy-test-run/sources/stable/gh/noahrinehart/mangsh/Cargo.toml [INFO] started frobbing noahrinehart/mangsh [INFO] finished frobbing noahrinehart/mangsh [INFO] frobbed toml for noahrinehart/mangsh written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/noahrinehart/mangsh/Cargo.toml [INFO] crate noahrinehart/mangsh has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting noahrinehart/mangsh against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/noahrinehart/mangsh:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5932000e365a63132978bef9ee083bfbad773198dfab67875c41f009ea07818b [INFO] running `"docker" "start" "-a" "5932000e365a63132978bef9ee083bfbad773198dfab67875c41f009ea07818b"` [INFO] [stderr] Checking bitflags v1.0.2 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking nix v0.10.0 [INFO] [stderr] Checking rustyline v1.0.0 [INFO] [stderr] Checking mangsh v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `child` [INFO] [stderr] --> src/parser.rs:30:33 [INFO] [stderr] | [INFO] [stderr] 30 | Ok(ForkResult::Parent { child, .. }) => { [INFO] [stderr] | ^^^^^ help: try ignoring the field: `child: _` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `child` [INFO] [stderr] --> src/parser.rs:30:33 [INFO] [stderr] | [INFO] [stderr] 30 | Ok(ForkResult::Parent { child, .. }) => { [INFO] [stderr] | ^^^^^ help: try ignoring the field: `child: _` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:9:40 [INFO] [stderr] | [INFO] [stderr] 9 | let tokens: Vec<&str> = line.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:26:20 [INFO] [stderr] | [INFO] [stderr] 26 | fn command(tokens: &Vec<&str>) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/parser.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | Err(_) => panic!("Fork failed!"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | / match execvp(&cmd[0], &cmd) { [INFO] [stderr] 37 | | Err(_) => panic!("execpv failed!"), [INFO] [stderr] 38 | | _ => (), [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Err(_) = execvp(&cmd[0], &cmd) { panic!("execpv failed!") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/parser.rs:37:17 [INFO] [stderr] | [INFO] [stderr] 37 | Err(_) => panic!("execpv failed!"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:45:31 [INFO] [stderr] | [INFO] [stderr] 45 | fn vec_str_to_cstring(tokens: &Vec<&str>) -> Vec { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/builtins.rs:10:19 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn cd(tokens: &Vec<&str>) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:12:12 [INFO] [stderr] | [INFO] [stderr] 12 | if let Err(_) = rl.load_history("history.txt") { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 13 | | println!("No previous history."); [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____- help: try this: `if rl.load_history("history.txt").is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:9:40 [INFO] [stderr] | [INFO] [stderr] 9 | let tokens: Vec<&str> = line.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:26:20 [INFO] [stderr] | [INFO] [stderr] 26 | fn command(tokens: &Vec<&str>) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/parser.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | Err(_) => panic!("Fork failed!"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | / match execvp(&cmd[0], &cmd) { [INFO] [stderr] 37 | | Err(_) => panic!("execpv failed!"), [INFO] [stderr] 38 | | _ => (), [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Err(_) = execvp(&cmd[0], &cmd) { panic!("execpv failed!") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/parser.rs:37:17 [INFO] [stderr] | [INFO] [stderr] 37 | Err(_) => panic!("execpv failed!"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:45:31 [INFO] [stderr] | [INFO] [stderr] 45 | fn vec_str_to_cstring(tokens: &Vec<&str>) -> Vec { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/builtins.rs:10:19 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn cd(tokens: &Vec<&str>) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:12:12 [INFO] [stderr] | [INFO] [stderr] 12 | if let Err(_) = rl.load_history("history.txt") { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 13 | | println!("No previous history."); [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____- help: try this: `if rl.load_history("history.txt").is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.07s [INFO] running `"docker" "inspect" "5932000e365a63132978bef9ee083bfbad773198dfab67875c41f009ea07818b"` [INFO] running `"docker" "rm" "-f" "5932000e365a63132978bef9ee083bfbad773198dfab67875c41f009ea07818b"` [INFO] [stdout] 5932000e365a63132978bef9ee083bfbad773198dfab67875c41f009ea07818b