[INFO] updating cached repository noahrinehart/lrg [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/noahrinehart/lrg [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/noahrinehart/lrg" "work/ex/clippy-test-run/sources/stable/gh/noahrinehart/lrg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/noahrinehart/lrg'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/noahrinehart/lrg" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/noahrinehart/lrg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/noahrinehart/lrg'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5612ca917335af5d0d0ada00d9c797d796405f46 [INFO] sha for GitHub repo noahrinehart/lrg: 5612ca917335af5d0d0ada00d9c797d796405f46 [INFO] validating manifest of noahrinehart/lrg on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of noahrinehart/lrg on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing noahrinehart/lrg [INFO] finished frobbing noahrinehart/lrg [INFO] frobbed toml for noahrinehart/lrg written to work/ex/clippy-test-run/sources/stable/gh/noahrinehart/lrg/Cargo.toml [INFO] started frobbing noahrinehart/lrg [INFO] finished frobbing noahrinehart/lrg [INFO] frobbed toml for noahrinehart/lrg written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/noahrinehart/lrg/Cargo.toml [INFO] crate noahrinehart/lrg has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting noahrinehart/lrg against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/noahrinehart/lrg:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4a3c57aa0b208a046e6ab6b3a1546db2b6359cfb474cb7516ca229da5aa53263 [INFO] running `"docker" "start" "-a" "4a3c57aa0b208a046e6ab6b3a1546db2b6359cfb474cb7516ca229da5aa53263"` [INFO] [stderr] Checking env_logger v0.6.0 [INFO] [stderr] Checking lrg v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lrg_size_test.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | 1024000, [INFO] [stderr] | ^^^^^^^ help: consider: `1_024_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lrg_size_test.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | 204800, [INFO] [stderr] | ^^^^^^ help: consider: `204_800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lrg_size_test.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | 102400, [INFO] [stderr] | ^^^^^^ help: consider: `102_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lrg_size_test.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | 1024000, [INFO] [stderr] | ^^^^^^^ help: consider: `1_024_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lrg_size_test.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | 1024000, [INFO] [stderr] | ^^^^^^^ help: consider: `1_024_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lrg_size_test.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | 1024000, [INFO] [stderr] | ^^^^^^^ help: consider: `1_024_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lrg_size_test.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | 204800, [INFO] [stderr] | ^^^^^^ help: consider: `204_800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lrg_size_test.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | 102400, [INFO] [stderr] | ^^^^^^ help: consider: `102_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lrg_size_test.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | 1024000, [INFO] [stderr] | ^^^^^^^ help: consider: `1_024_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lrg_size_test.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | 1024000, [INFO] [stderr] | ^^^^^^^ help: consider: `1_024_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lrg_size_test.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | 204800, [INFO] [stderr] | ^^^^^^ help: consider: `204_800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lrg_size_test.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | 102400, [INFO] [stderr] | ^^^^^^ help: consider: `102_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lrg_size_test.rs:194:13 [INFO] [stderr] | [INFO] [stderr] 194 | 204800, [INFO] [stderr] | ^^^^^^ help: consider: `204_800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lrg_size_test.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | 102400, [INFO] [stderr] | ^^^^^^ help: consider: `102_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> tests/lrg_size_test.rs:7:40 [INFO] [stderr] | [INFO] [stderr] 7 | fn test_entries_against_sizes(entries: &Vec, sizes: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[DirEntry]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> tests/lrg_size_test.rs:7:63 [INFO] [stderr] | [INFO] [stderr] 7 | fn test_entries_against_sizes(entries: &Vec, sizes: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> tests/lrg_order_test.rs:12:44 [INFO] [stderr] | [INFO] [stderr] 12 | fn test_entries_against_filenames(entries: &Vec, filenames: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[DirEntry]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> tests/lrg_order_test.rs:12:71 [INFO] [stderr] | [INFO] [stderr] 12 | fn test_entries_against_filenames(entries: &Vec, filenames: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/bin/main.rs:179:81 [INFO] [stderr] | [INFO] [stderr] 179 | format!("{}", diff_paths(entry.path(), ¤t_dir).unwrap_or_else(|| PathBuf::new()).display()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/bin/main.rs:179:81 [INFO] [stderr] | [INFO] [stderr] 179 | format!("{}", diff_paths(entry.path(), ¤t_dir).unwrap_or_else(|| PathBuf::new()).display()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.93s [INFO] running `"docker" "inspect" "4a3c57aa0b208a046e6ab6b3a1546db2b6359cfb474cb7516ca229da5aa53263"` [INFO] running `"docker" "rm" "-f" "4a3c57aa0b208a046e6ab6b3a1546db2b6359cfb474cb7516ca229da5aa53263"` [INFO] [stdout] 4a3c57aa0b208a046e6ab6b3a1546db2b6359cfb474cb7516ca229da5aa53263