[INFO] updating cached repository nnarain/silica
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/nnarain/silica
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/nnarain/silica" "work/ex/clippy-test-run/sources/stable/gh/nnarain/silica"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nnarain/silica'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/nnarain/silica" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nnarain/silica"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nnarain/silica'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] f53593f632c224cde0b0ab438ce92bf32841c289
[INFO] sha for GitHub repo nnarain/silica: f53593f632c224cde0b0ab438ce92bf32841c289
[INFO] validating manifest of nnarain/silica on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of nnarain/silica on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing nnarain/silica
[INFO] finished frobbing nnarain/silica
[INFO] frobbed toml for nnarain/silica written to work/ex/clippy-test-run/sources/stable/gh/nnarain/silica/Cargo.toml
[INFO] started frobbing nnarain/silica
[INFO] finished frobbing nnarain/silica
[INFO] frobbed toml for nnarain/silica written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nnarain/silica/Cargo.toml
[INFO] crate nnarain/silica has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting nnarain/silica against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nnarain/silica:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 6a153eddf8851e763b30cdbe1fdd11e06574f6f2163c64a4e69a3f16a2bb017e
[INFO] running `"docker" "start" "-a" "6a153eddf8851e763b30cdbe1fdd11e06574f6f2163c64a4e69a3f16a2bb017e"`
[INFO] [stderr]     Checking libc v0.2.29
[INFO] [stderr]     Checking serde v1.0.11
[INFO] [stderr]    Compiling serde_derive v1.0.11
[INFO] [stderr]     Checking memchr v1.0.1
[INFO] [stderr]     Checking aho-corasick v0.6.3
[INFO] [stderr]     Checking nom v3.2.0
[INFO] [stderr]     Checking regex v0.2.2
[INFO] [stderr]     Checking docopt v0.8.1
[INFO] [stderr]     Checking silica v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/assembler/codegenerator.rs:16:13
[INFO] [stderr]    |
[INFO] [stderr] 16 |             address: address,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `address`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/assembler/codegenerator.rs:17:13
[INFO] [stderr]    |
[INFO] [stderr] 17 |             expr: expr
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `expr`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/assembler/codegenerator.rs:16:13
[INFO] [stderr]    |
[INFO] [stderr] 16 |             address: address,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `address`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/assembler/codegenerator.rs:17:13
[INFO] [stderr]    |
[INFO] [stderr] 17 |             expr: expr
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `expr`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/assembler/semantics.rs:25:29
[INFO] [stderr]    |
[INFO] [stderr] 25 |                             return Ok(())
[INFO] [stderr]    |                             ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/assembler/semantics.rs:27:30
[INFO] [stderr]    |
[INFO] [stderr] 27 |                         _ => return Err(SemanticsError{message: String::from("Invalid token in directive expression")})
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(SemanticsError{message: String::from("Invalid token in directive expression")})`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/assembler/semantics.rs:39:21
[INFO] [stderr]    |
[INFO] [stderr] 39 |                     return Ok(())
[INFO] [stderr]    |                     ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/assembler/codegenerator.rs:61:13
[INFO] [stderr]    |
[INFO] [stderr] 61 |             return reduced_mem
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `reduced_mem`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/assembler/codegenerator.rs:69:13
[INFO] [stderr]    |
[INFO] [stderr] 69 |             return output
[INFO] [stderr]    |             ^^^^^^^^^^^^^ help: remove `return` as shown: `output`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/assembler/codegenerator.rs:218:14
[INFO] [stderr]     |
[INFO] [stderr] 218 |           else {
[INFO] [stderr]     |  ______________^
[INFO] [stderr] 219 | |             if let Token::Register(ref reg) = expr[2] {
[INFO] [stderr] 220 | |                 let reg_num = self.register_name_to_u8(reg);
[INFO] [stderr] 221 | |                 self.append_opcode(0xF0u8 | reg_num, 0x1Eu8);
[INFO] [stderr] 222 | |             }
[INFO] [stderr] 223 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 218 |         else if let Token::Register(ref reg) = expr[2] {
[INFO] [stderr] 219 |     let reg_num = self.register_name_to_u8(reg);
[INFO] [stderr] 220 |     self.append_opcode(0xF0u8 | reg_num, 0x1Eu8);
[INFO] [stderr] 221 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/lib.rs:17:19
[INFO] [stderr]    |
[INFO] [stderr] 17 |     const USAGE: &'static str = "
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/assembler/semantics.rs:25:29
[INFO] [stderr]    |
[INFO] [stderr] 25 |                             return Ok(())
[INFO] [stderr]    |                             ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/assembler/semantics.rs:27:30
[INFO] [stderr]    |
[INFO] [stderr] 27 |                         _ => return Err(SemanticsError{message: String::from("Invalid token in directive expression")})
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(SemanticsError{message: String::from("Invalid token in directive expression")})`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/assembler/semantics.rs:39:21
[INFO] [stderr]    |
[INFO] [stderr] 39 |                     return Ok(())
[INFO] [stderr]    |                     ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/assembler/codegenerator.rs:61:13
[INFO] [stderr]    |
[INFO] [stderr] 61 |             return reduced_mem
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `reduced_mem`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/assembler/codegenerator.rs:69:13
[INFO] [stderr]    |
[INFO] [stderr] 69 |             return output
[INFO] [stderr]    |             ^^^^^^^^^^^^^ help: remove `return` as shown: `output`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/assembler/codegenerator.rs:218:14
[INFO] [stderr]     |
[INFO] [stderr] 218 |           else {
[INFO] [stderr]     |  ______________^
[INFO] [stderr] 219 | |             if let Token::Register(ref reg) = expr[2] {
[INFO] [stderr] 220 | |                 let reg_num = self.register_name_to_u8(reg);
[INFO] [stderr] 221 | |                 self.append_opcode(0xF0u8 | reg_num, 0x1Eu8);
[INFO] [stderr] 222 | |             }
[INFO] [stderr] 223 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 218 |         else if let Token::Register(ref reg) = expr[2] {
[INFO] [stderr] 219 |     let reg_num = self.register_name_to_u8(reg);
[INFO] [stderr] 220 |     self.append_opcode(0xF0u8 | reg_num, 0x1Eu8);
[INFO] [stderr] 221 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/lib.rs:17:19
[INFO] [stderr]    |
[INFO] [stderr] 17 |     const USAGE: &'static str = "
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/assembler/lexer.rs:35:17
[INFO] [stderr]    |
[INFO] [stderr] 35 | /                 if reg.contains("V") {
[INFO] [stderr] 36 | |                     true
[INFO] [stderr] 37 | |                 }
[INFO] [stderr] 38 | |                 else {
[INFO] [stderr] 39 | |                     false
[INFO] [stderr] 40 | |                 }
[INFO] [stderr]    | |_________________^ help: you can reduce it to: `reg.contains("V")`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/assembler/lexer.rs:35:33
[INFO] [stderr]    |
[INFO] [stderr] 35 |                 if reg.contains("V") {
[INFO] [stderr]    |                                 ^^^ help: try using a char instead: `'V'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/assembler/semantics.rs:10:20
[INFO] [stderr]    |
[INFO] [stderr] 10 | pub fn check(expr: &Expression) -> Result<(), SemanticsError> {
[INFO] [stderr]    |                    ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `expr`.
[INFO] [stderr]   --> src/assembler/semantics.rs:31:30
[INFO] [stderr]    |
[INFO] [stderr] 31 |                     for i in 1..expr.len() {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 31 |                     for <item> in expr.iter().skip(1) {
[INFO] [stderr]    |                         ^^^^^^    ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/assembler/semantics.rs:55:39
[INFO] [stderr]    |
[INFO] [stderr] 55 | fn check_instruction_semantics(instr: &String, expr: &Expression) -> Result<(), SemanticsError> {
[INFO] [stderr]    |                                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/assembler/semantics.rs:55:54
[INFO] [stderr]    |
[INFO] [stderr] 55 | fn check_instruction_semantics(instr: &String, expr: &Expression) -> Result<(), SemanticsError> {
[INFO] [stderr]    |                                                      ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 40
[INFO] [stderr]    --> src/assembler/semantics.rs:55:1
[INFO] [stderr]     |
[INFO] [stderr] 55  | / fn check_instruction_semantics(instr: &String, expr: &Expression) -> Result<(), SemanticsError> {
[INFO] [stderr] 56  | |     match instr.as_ref() {
[INFO] [stderr] 57  | |         "CLS" => {
[INFO] [stderr] 58  | |             if expr.len() == 1 {
[INFO] [stderr] ...   |
[INFO] [stderr] 313 | |     }
[INFO] [stderr] 314 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/assembler/codegenerator.rs:66:22
[INFO] [stderr]    |
[INFO] [stderr] 66 |             for i in 0..output.len() {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^ help: try replacing the loop by: `output.clone_from_slice(&reduced_mem[512..(output.len() + 512)])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/assembler/codegenerator.rs:74:44
[INFO] [stderr]    |
[INFO] [stderr] 74 |     fn process_expression(&mut self, expr: &Expression) {
[INFO] [stderr]    |                                            ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/assembler/codegenerator.rs:94:43
[INFO] [stderr]    |
[INFO] [stderr] 94 |     fn process_directive(&mut self, expr: &Expression) {
[INFO] [stderr]    |                                           ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `expr`.
[INFO] [stderr]    --> src/assembler/codegenerator.rs:104:30
[INFO] [stderr]     |
[INFO] [stderr] 104 |                     for i in 1..expr.len() {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 104 |                     for <item> in expr.iter().skip(1) {
[INFO] [stderr]     |                         ^^^^^^    ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/assembler/codegenerator.rs:116:39
[INFO] [stderr]     |
[INFO] [stderr] 116 |     fn process_label(&mut self, expr: &Expression) {
[INFO] [stderr]     |                                       ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/assembler/codegenerator.rs:127:45
[INFO] [stderr]     |
[INFO] [stderr] 127 |     fn process_instruction(&mut self, expr: &Expression) {
[INFO] [stderr]     |                                             ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/assembler/codegenerator.rs:155:61
[INFO] [stderr]     |
[INFO] [stderr] 155 |     fn process_jump_instruction(&mut self, first: u8, expr: &Expression) {
[INFO] [stderr]     |                                                             ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/assembler/codegenerator.rs:178:71
[INFO] [stderr]     |
[INFO] [stderr] 178 |     fn process_se_instruction(&mut self, first: u8, second: u8, expr: &Expression) {
[INFO] [stderr]     |                                                                       ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/assembler/codegenerator.rs:192:64
[INFO] [stderr]     |
[INFO] [stderr] 192 |     fn process_logical_instruction(&mut self, first: u8, expr: &Expression) {
[INFO] [stderr]     |                                                                ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/assembler/codegenerator.rs:204:49
[INFO] [stderr]     |
[INFO] [stderr] 204 |     fn process_add_instruction(&mut self, expr: &Expression) {
[INFO] [stderr]     |                                                 ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/assembler/codegenerator.rs:205:13
[INFO] [stderr]     |
[INFO] [stderr] 205 |         let ref reg1 = expr[1];
[INFO] [stderr]     |         ----^^^^^^^^----------- help: try: `let reg1 = &expr[1];`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/assembler/codegenerator.rs:226:49
[INFO] [stderr]     |
[INFO] [stderr] 226 |     fn process_sub_instruction(&mut self, expr: &Expression, last: u8) {
[INFO] [stderr]     |                                                 ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/assembler/codegenerator.rs:237:50
[INFO] [stderr]     |
[INFO] [stderr] 237 |     fn process_skip_instruction(&mut self, expr: &Expression, last: u8) {
[INFO] [stderr]     |                                                  ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/assembler/codegenerator.rs:244:49
[INFO] [stderr]     |
[INFO] [stderr] 244 |     fn process_rnd_instruction(&mut self, expr: &Expression) {
[INFO] [stderr]     |                                                 ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/assembler/codegenerator.rs:253:50
[INFO] [stderr]     |
[INFO] [stderr] 253 |     fn process_draw_instruction(&mut self, expr: &Expression) {
[INFO] [stderr]     |                                                  ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/assembler/codegenerator.rs:266:50
[INFO] [stderr]     |
[INFO] [stderr] 266 |     fn process_load_instruction(&mut self, expr: &Expression) {
[INFO] [stderr]     |                                                  ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/assembler/codegenerator.rs:337:54
[INFO] [stderr]     |
[INFO] [stderr] 337 |     fn queue_incomplete_instruction(&mut self, expr: &Expression) {
[INFO] [stderr]     |                                                      ^^^^^^^^^^^
[INFO] [stderr] 338 |         let incomplete = IncompleteInstruction::new(self.address_counter, expr.clone());
[INFO] [stderr]     |                                                                           ------------ help: change `expr.clone()` to: `expr.to_owned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/assembler/codegenerator.rs:360:45
[INFO] [stderr]     |
[INFO] [stderr] 360 |     fn register_name_to_u8(&mut self, name: &String) -> u8 {
[INFO] [stderr]     |                                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:41:28
[INFO] [stderr]    |
[INFO] [stderr] 41 | pub fn load_file(rom_file: &String) -> Result<Vec<u8>, Box<Error>> {
[INFO] [stderr]    |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/assembler/lexer.rs:35:17
[INFO] [stderr]    |
[INFO] [stderr] 35 | /                 if reg.contains("V") {
[INFO] [stderr] 36 | |                     true
[INFO] [stderr] 37 | |                 }
[INFO] [stderr] 38 | |                 else {
[INFO] [stderr] 39 | |                     false
[INFO] [stderr] 40 | |                 }
[INFO] [stderr]    | |_________________^ help: you can reduce it to: `reg.contains("V")`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/assembler/lexer.rs:35:33
[INFO] [stderr]    |
[INFO] [stderr] 35 |                 if reg.contains("V") {
[INFO] [stderr]    |                                 ^^^ help: try using a char instead: `'V'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/assembler/lexer.rs:399:21
[INFO] [stderr]     |
[INFO] [stderr] 399 |         let input = "start".as_bytes();
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"start"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/assembler/lexer.rs:407:21
[INFO] [stderr]     |
[INFO] [stderr] 407 |         let input = "$A0".as_bytes();
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"$A0"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/assembler/lexer.rs:415:21
[INFO] [stderr]     |
[INFO] [stderr] 415 |         let input = "57".as_bytes();
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"57"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/assembler/lexer.rs:423:21
[INFO] [stderr]     |
[INFO] [stderr] 423 |         let input = "$FF".as_bytes();
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"$FF"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/assembler/lexer.rs:431:21
[INFO] [stderr]     |
[INFO] [stderr] 431 |         let input = "255".as_bytes();
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"255"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/assembler/lexer.rs:455:21
[INFO] [stderr]     |
[INFO] [stderr] 455 |         let input = ",".as_bytes();
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b","`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/assembler/lexer.rs:463:21
[INFO] [stderr]     |
[INFO] [stderr] 463 |         let input = "#label".as_bytes();
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"#label"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/assembler/semantics.rs:10:20
[INFO] [stderr]    |
[INFO] [stderr] 10 | pub fn check(expr: &Expression) -> Result<(), SemanticsError> {
[INFO] [stderr]    |                    ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `expr`.
[INFO] [stderr]   --> src/assembler/semantics.rs:31:30
[INFO] [stderr]    |
[INFO] [stderr] 31 |                     for i in 1..expr.len() {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 31 |                     for <item> in expr.iter().skip(1) {
[INFO] [stderr]    |                         ^^^^^^    ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/assembler/semantics.rs:55:39
[INFO] [stderr]    |
[INFO] [stderr] 55 | fn check_instruction_semantics(instr: &String, expr: &Expression) -> Result<(), SemanticsError> {
[INFO] [stderr]    |                                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/assembler/semantics.rs:55:54
[INFO] [stderr]    |
[INFO] [stderr] 55 | fn check_instruction_semantics(instr: &String, expr: &Expression) -> Result<(), SemanticsError> {
[INFO] [stderr]    |                                                      ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 40
[INFO] [stderr]    --> src/assembler/semantics.rs:55:1
[INFO] [stderr]     |
[INFO] [stderr] 55  | / fn check_instruction_semantics(instr: &String, expr: &Expression) -> Result<(), SemanticsError> {
[INFO] [stderr] 56  | |     match instr.as_ref() {
[INFO] [stderr] 57  | |         "CLS" => {
[INFO] [stderr] 58  | |             if expr.len() == 1 {
[INFO] [stderr] ...   |
[INFO] [stderr] 313 | |     }
[INFO] [stderr] 314 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/assembler/codegenerator.rs:66:22
[INFO] [stderr]    |
[INFO] [stderr] 66 |             for i in 0..output.len() {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^ help: try replacing the loop by: `output.clone_from_slice(&reduced_mem[512..(output.len() + 512)])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/assembler/codegenerator.rs:74:44
[INFO] [stderr]    |
[INFO] [stderr] 74 |     fn process_expression(&mut self, expr: &Expression) {
[INFO] [stderr]    |                                            ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/assembler/codegenerator.rs:94:43
[INFO] [stderr]    |
[INFO] [stderr] 94 |     fn process_directive(&mut self, expr: &Expression) {
[INFO] [stderr]    |                                           ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `expr`.
[INFO] [stderr]    --> src/assembler/codegenerator.rs:104:30
[INFO] [stderr]     |
[INFO] [stderr] 104 |                     for i in 1..expr.len() {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 104 |                     for <item> in expr.iter().skip(1) {
[INFO] [stderr]     |                         ^^^^^^    ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/assembler/codegenerator.rs:116:39
[INFO] [stderr]     |
[INFO] [stderr] 116 |     fn process_label(&mut self, expr: &Expression) {
[INFO] [stderr]     |                                       ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/assembler/codegenerator.rs:127:45
[INFO] [stderr]     |
[INFO] [stderr] 127 |     fn process_instruction(&mut self, expr: &Expression) {
[INFO] [stderr]     |                                             ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/assembler/codegenerator.rs:155:61
[INFO] [stderr]     |
[INFO] [stderr] 155 |     fn process_jump_instruction(&mut self, first: u8, expr: &Expression) {
[INFO] [stderr]     |                                                             ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/assembler/codegenerator.rs:178:71
[INFO] [stderr]     |
[INFO] [stderr] 178 |     fn process_se_instruction(&mut self, first: u8, second: u8, expr: &Expression) {
[INFO] [stderr]     |                                                                       ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/assembler/codegenerator.rs:192:64
[INFO] [stderr]     |
[INFO] [stderr] 192 |     fn process_logical_instruction(&mut self, first: u8, expr: &Expression) {
[INFO] [stderr]     |                                                                ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/assembler/codegenerator.rs:204:49
[INFO] [stderr]     |
[INFO] [stderr] 204 |     fn process_add_instruction(&mut self, expr: &Expression) {
[INFO] [stderr]     |                                                 ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/assembler/codegenerator.rs:205:13
[INFO] [stderr]     |
[INFO] [stderr] 205 |         let ref reg1 = expr[1];
[INFO] [stderr]     |         ----^^^^^^^^----------- help: try: `let reg1 = &expr[1];`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/assembler/codegenerator.rs:226:49
[INFO] [stderr]     |
[INFO] [stderr] 226 |     fn process_sub_instruction(&mut self, expr: &Expression, last: u8) {
[INFO] [stderr]     |                                                 ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/assembler/codegenerator.rs:237:50
[INFO] [stderr]     |
[INFO] [stderr] 237 |     fn process_skip_instruction(&mut self, expr: &Expression, last: u8) {
[INFO] [stderr]     |                                                  ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/assembler/codegenerator.rs:244:49
[INFO] [stderr]     |
[INFO] [stderr] 244 |     fn process_rnd_instruction(&mut self, expr: &Expression) {
[INFO] [stderr]     |                                                 ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/assembler/codegenerator.rs:253:50
[INFO] [stderr]     |
[INFO] [stderr] 253 |     fn process_draw_instruction(&mut self, expr: &Expression) {
[INFO] [stderr]     |                                                  ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/assembler/codegenerator.rs:266:50
[INFO] [stderr]     |
[INFO] [stderr] 266 |     fn process_load_instruction(&mut self, expr: &Expression) {
[INFO] [stderr]     |                                                  ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/assembler/codegenerator.rs:337:54
[INFO] [stderr]     |
[INFO] [stderr] 337 |     fn queue_incomplete_instruction(&mut self, expr: &Expression) {
[INFO] [stderr]     |                                                      ^^^^^^^^^^^
[INFO] [stderr] 338 |         let incomplete = IncompleteInstruction::new(self.address_counter, expr.clone());
[INFO] [stderr]     |                                                                           ------------ help: change `expr.clone()` to: `expr.to_owned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/assembler/codegenerator.rs:360:45
[INFO] [stderr]     |
[INFO] [stderr] 360 |     fn register_name_to_u8(&mut self, name: &String) -> u8 {
[INFO] [stderr]     |                                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:41:28
[INFO] [stderr]    |
[INFO] [stderr] 41 | pub fn load_file(rom_file: &String) -> Result<Vec<u8>, Box<Error>> {
[INFO] [stderr]    |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 22.99s
[INFO] running `"docker" "inspect" "6a153eddf8851e763b30cdbe1fdd11e06574f6f2163c64a4e69a3f16a2bb017e"`
[INFO] running `"docker" "rm" "-f" "6a153eddf8851e763b30cdbe1fdd11e06574f6f2163c64a4e69a3f16a2bb017e"`
[INFO] [stdout] 6a153eddf8851e763b30cdbe1fdd11e06574f6f2163c64a4e69a3f16a2bb017e